Re: [rebase PATCH] Introduce --with-posix-shell configure flag.

ROG_MKDIR_P > diff --git a/peflagsall.in b/peflagsall.in > index d838201..6839db4 100644 > --- a/peflagsall.in > +++ b/peflagsall.in > @@ -1,4 +1,4 @@ > -#!/bin/@ASH@ > +#!@POSIXSHELL@ > > # > # Copyright (c) 2009,2011 Charles Wilson > diff --git a/rebaseall.in b/rebaseall.in > index 076cc32..af4fe3f 100644 > --- a/rebaseall.in > +++ b/rebaseall.in > @@ -1,4 +1,4 @@ > -#!/bin/@ASH@ > +#!@POSIXSHELL@ > > # > # Copyright (c) 2003, 2005, 2006, 2008, 2011, 2012 Jason Tishler > -- > 2.19.2 -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [rebase PATCH] On error, avoid a close on the -1 file descriptor.

char *pathname) > >fd = open (pathname, O_RDONLY); >if (fd == -1) > -goto done; > +return status; > >offset = lseek (fd, pe_signature_offset_offset, SEEK_SET); >if (offset == -1) > -- > 2.19.2 Pushed. Thanks, Corinna -- Corinna Vi

Re: [rebase PATCH] Introduce --with-posix-shell configure flag.

On Apr 10 14:34, Michael Haubenwallner wrote: > On 4/10/19 2:32 PM, Michael Haubenwallner wrote: > > On 4/10/19 11:02 AM, Corinna Vinschen wrote: > >> On Apr 9 11:23, Michael Haubenwallner wrote: > >>> Some distros prefer a POSIX shell other than /bin/ash and /bin/d

Re: [PATCH] Improve error handling in /proc/[pid]/ virtual files.

/proc/[pid]/maps for zombie processes (in this case the > file can be read but is zero-length, which is consistent with observed > behavior on Linux. Pushed. New snapshots building right now. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Implement sched_[gs]etaffinity()

- PROCESS_QUERY_LIMITED_INFORMATION should be sufficent per MSDN. PROCESS_QUERY_INFORMATION was required pre-Vista only. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH RFC] fork: reduce chances for "address space is already occupied" errors

Hi Michael, On Apr 3 14:22, Corinna Vinschen wrote: > On Apr 3 11:18, Michael Haubenwallner wrote: > > On 4/1/19 5:56 PM, Corinna Vinschen wrote: > > > On Apr 1 16:56, Corinna Vinschen wrote: > > >> On Apr 1 16:28, Michael Haubenwallner wrote: > > >

Re: [PATCH] Cygwin: fork: remember child as late as possible

debugging. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: use win pid+threadid for forkables dirname

s avoid conflicts between dlls not having the newest last > write time. > --- > winsup/cygwin/forkable.cc | 26 +++--- > 1 file changed, 7 insertions(+), 19 deletions(-) Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [rebase PATCH] Introduce --no-rebase flag

On Apr 12 15:52, Michael Haubenwallner wrote: > The --no-rebase flag is to update the database for new files, without Wouldn't something like --merge-files be more descriptive? Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH RFC] fork: reduce chances for "address space is already occupied" errors

On Apr 13 09:46, Achim Gratz wrote: > Corinna Vinschen writes: > > Nick Clifton, one of the binutils maintainers, made the following > > suggestion in PM: > > > > Allow the ld flag --enable-auto-image-base to take a filename as > > argument. > > > > The

Re: [PATCH 13/14] Cygwin: FIFO: improve raw_write

andler_fifo.cc:711:8: error: ‘status’ may be used uninitialized in this function [-Werror=maybe-uninitialized] else if (status == STATUS_THREAD_CANCELED) ^~ You only see this with -O2. There's actually a chance this may occur if the incoming len is 0. Can you check, especially in term

Re: [PATCH 00/14] FIFO bug fixes and code simplifications

+- > winsup/cygwin/fhandler.h | 43 +-- > winsup/cygwin/fhandler_fifo.cc | 580 + > winsup/cygwin/select.cc| 4 +- > 4 files changed, 342 insertions(+), 299 deletions(-) > > -- > 2.17.0 > Pushed with v2 of patch 13. Deve

Re: [PATCH] Cygwin: FIFO: avoid hang after exec

gt; void > fhandler_fifo::set_close_on_exec (bool val) > { > -- > 2.17.0 Pushed. Developer snapshots should be up in 15 mins, give or take. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Cygwin patches (was Re: [PATCH 00/14] FIFO bug fixes and code simplifications)

and review and ultimately push patches from others. This also applies to Takashi's ConPTY patch as soon as he wants to go mainline, as well as Mark's sched_[gs]etaffinity patches, after review. You know the drill :) Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: Cygwin patches (was Re: [PATCH 00/14] FIFO bug fixes and code simplifications)

On Apr 18 21:34, Achim Gratz wrote: > Corinna Vinschen writes: > >> No testing will be possible for me in the next two weeks, sorry. > > > > I'll be afk all of March, too. > > So, the past month? :-D s/March/May/ Sorry, Corinna -- Corinna Vinsche

Re: Cygwin patches (was Re: [PATCH 00/14] FIFO bug fixes and code simplifications)

On Apr 18 21:00, Ken Brown wrote: > On 4/18/2019 3:04 PM, Corinna Vinschen wrote: > > Ken, you have an account on sware and check-in rights to the cygwin repo > > anyway, so you don't really need me to push patches. > > > > If you feel up to the task, you

Re: [PATCH 0/5] More FIFO bug fixes

> winsup/cygwin/fhandler_fifo.cc | 55 -- > 2 files changed, 42 insertions(+), 16 deletions(-) Reviewed. I don't see anything evidently wrong. Please push. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Minor improvements to socket error handling:

rn EPERM; > + return EACCES; > } > > void > -- > 2.15.1 Pushed, thanks! I'm building dev snapshots right now, should be up in a couple of mins. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH RFC] fork: reduce chances for "address space is already occupied" errors

On Apr 24 17:09, Michael Haubenwallner wrote: > On 4/12/19 7:40 PM, Corinna Vinschen wrote: > > Hi Michael, > > > Nick Clifton, one of the binutils maintainers, made the following > > suggestion in PM: > > > > Allow the ld flag --enable-auto-image-bas

Re: [PATCH v2] Cygwin: Implement sched_[gs]etaffinity()

mask = pbi.AffinityMask; > +} > + else > +set[0] = procmask; > +} > + else > +status = ESRCH; > + > +done: > + if (process && process != GetCurrentProcess ()) > +CloseHandle (process); > + > + return status; > +} > +[...] Other than that, the code looks good to me. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v2] Cygwin: Implement sched_[gs]etaffinity()

On Apr 29 01:54, Mark Geisert wrote: > Corinna Vinschen wrote: > > Hi Mark, > > > > Howdy! FTR Here's the intro paragraph left out of my patch submission: > > Second version of CPU affinity patch set. Attempts to mimic operation > of Linux affinity funct

Re: [PATCH fifo 0/2] Add support for duplex FIFOs

s. Looking at MSDN, it now seems > clear to me that you can't do I/O on the server side of a pipe until > the pipe connects to a client. So I'll have to rethink how to deal > with the O_RDWR case. Sorry being late, but yeah, STATUS_PIPE_LISTENING means no client is connected. This is one of the more ugly implementation details of Windows pipes. There just isn't a generic buffer which can be filled even if no one is listening yet on the other side :-P Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 2/2] Cygwin: fork: Remember child not before success.

? What's that fixing and what effect does this have on the performance of the already very slow fork()? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 1/3] Cygwin: dll_list: drop FILE_BASIC_INFORMATION

(fhandle, &d->fii)) > system_printf ("WARNING: Unable to read real file attributes for %W", > pmsi1->SectionFileName.Buffer); > >NtClose (fhandle); > - return d->fbi.FileAttributes != INVALID_FILE_ATTRIBUTES; > + return d->fii.IndexNumber.QuadPart != -1LL; > } > > /* easy use of NtOpenFile */ > -- > 2.19.2 Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 1/3] Cygwin: dll_list: drop FILE_BASIC_INFORMATION

On Apr 30 18:13, Corinna Vinschen wrote: > On Apr 30 16:14, Michael Haubenwallner wrote: > > Querying FILE_BASIC_INFORMATION is needless since using win pid+threadid > > for forkables dirname rather than newest last write time. > > --- > > winsup/cygwin/dll_init.

Re: [rebase PATCH] Introduce --merge-files (-M) flag (WAS: Introduce --no-rebase flag)

On May 6 10:31, Michael Haubenwallner wrote: > > On 5/4/19 4:33 PM, Brian Inglis wrote: > > On 2019-05-03 09:32, Michael Haubenwallner wrote: > >> On 4/12/19 8:03 PM, Corinna Vinschen wrote: > >>> On Apr 12 15:52, Michael Haubenwallner wrote: > >>>>

Re: [PATCH] cygcheck: expand common_apps list

wn", 0}, > > {"ssh-add", 0}, > > {"ssh-agent", 0}, > > {"sshd", 0}, > > {"ssh-keygen", 0}, > > {"ssh-keyscan", 0}, > > > > from ls *.exe | sort in each set of dirs then join both. > > I don't have /Windows/OpenSSH on my system. Is it added to PATH when > present? > > -- > Yaakov Brian? Ping? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH draft 0/6] Remove the fhandler_base_overlapped class

acs (-j13 in this case): > > make: INTERNAL: Exiting with 14 jobserver tokens available; should be > 13! > > This would seem to indicate problems with make's jobserver pipe. I've > already found two bugs in patch 4, but I'm still seeing this error >

Re: [rebase PATCH] Introduce --merge-files (-M) flag (WAS: Introduce --no-rebase flag)

On Jun 3 18:30, Corinna Vinschen wrote: > On May 6 10:31, Michael Haubenwallner wrote: > > > > On 5/4/19 4:33 PM, Brian Inglis wrote: > > > On 2019-05-03 09:32, Michael Haubenwallner wrote: > > >> On 4/12/19 8:03 PM, Corinna Vinschen wrote: > > >&g

Re: [PATCH] Cygwin: dll_list: no recursive use of nt_max_path_buf

+ > 1 file changed, 9 insertions(+), 4 deletions(-) Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: dll_list: stat_real_file_once with ntname

- > 2 files changed, 8 insertions(+), 34 deletions(-) Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 1/2] Cygwin: fork: Always pause child after fixups.

process was successfully initialized already. > > This is a preparation for when the parent does remember the child no > earlier than after successful child initialization. Patchset pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] mkdir: alway check-for-existence

CS it would just erroneously return STATUS_SUCCESS, so fhandler_disk_file::mkdir would have to check io.Information for FILE_OPENED or something like that. Maybe this paragraph can just go away? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] cygcheck: expand common_apps list

between them. > > Also, fix the alphabetization of ssh. on second thought you don't have to wait for Brian's reply. Just push this. If Brian has some more input, you can easily add another patch, right? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] mkdir: always check-for-existence

utput? If all else fails, you could attach your patch as plain/text attachement to your mail, usually that's left alone by the MUA. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v2] cygcheck: expand common_apps list

between them. > > Also, fix the alphabetization of ssh. Sure, please push. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] mkdir: always check-for-existence

. This applies fine. Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH draft 0/6] Remove the fhandler_base_overlapped class

:44 2019 +0200 > > Cygwin: fork: Remember child not before success. > > Do not remember the child before it was successfully initialized, or we > would need more sophisticated cleanup on child initialization failure, > like cleaning up the process table and suppressing SIGCHILD delivery > with multiple threads ("waitproc") involved. Compared to that, the > potential slowdown due to an extra yield () call should be negligible. Please revert the patch for the time being. Michael, this needs some more work, apparently. Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v3] Cygwin: Implement sched_[gs]etaffinity()

+++ > winsup/cygwin/thread.cc| 19 ++ > winsup/doc/new-features.xml| 6 + > winsup/doc/posix.xml | 4 + > 11 files changed, 389 insertions(+), 5 deletions(-) This looks great! I pushed it. Thanks, Corinna -- Corin

Re: [PATCH] Cygwin: Fix return value of sched_getaffinity

nt? I think it's a bit puzzeling that status indicates an error code as well as the non-errno return code from this function. Kind of like this: if (status) { set_errno (status) return -1; } return 0; Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: timerfd: avoid a deadlock

WFMO on cancel_evt and _access_mtx, in this order, so that a cancel event is honored. Or maybe introduce another function like enter_critical_section_cancelable() which is only called in this single instance in timerfd_tracker::thread_func? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: Build cygwin-console-helper with correct compiler

an unsigned long. Mingw compiles for native Windows, which is LLP64 rather than LP64: mingw:sizeof(long) == 4 cygwin:sizeof(long) == 8 This needs fixing as well (use strtoull). Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: Fix return value of sched_getaffinity

On Jun 25 01:17, Mark Geisert wrote: > Corinna Vinschen wrote: > > Hi Mark, > > > > On Jun 24 22:25, Mark Geisert wrote: > > > Return what the documentation says, instead of a misreading of it. > > > --- > > > winsup/cygwin/sched.cc | 2 +- &g

Re: [PATCH v2] Cygwin: timerfd: avoid a deadlock

rtions(+), 1 deletion(-) LGTM. Please push. Can you add a bugfix release msg to release/3.10, please? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v2] Fix return value of sched_getaffinity

__CYGWIN__ > +int __sched_getaffinity_sys (pid_t, size_t, cpu_set_t *); #endif ideally outside the #if __GNU_VISIBLE bracketing. The rest of the patch looks good. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: Build cygwin-console-helper with correct compiler

On Jun 26 01:48, Mark Geisert wrote: > Corinna Vinschen wrote: > > On Jun 25 00:54, Mark Geisert wrote: > > > --- > > > winsup/utils/Makefile.in | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/winsup/ut

Re: [PATCH] Cygwin: honor the O_PATH flag when opening a FIFO

On Jun 27 01:10, Ken Brown wrote: > Previously fhandler_fifo::open would treat the FIFO as a reader and > would block, waiting for a writer. Yup, thanks for catching. Please push. Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v3] Cygwin: Fix return value of sched_getaffinity

lems with using the RTEMS headers are fixed. Basically the patch is fine, but *if* we introduce our own headers, it might be a good idea to move the definition of __sched_getaffinity_sys into our own headers. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: Use correct string conversion

h, INFINITE); >exit (0); > } > -- > 2.21.0 Both patches pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v3] Cygwin: Fix return value of sched_getaffinity

On Jun 27 09:13, Corinna Vinschen wrote: > On Jun 26 02:44, Mark Geisert wrote: > > Have sched_getaffinity() interface like glibc's, and provide an > > undocumented internal interface __sched_getaffinity_sys() like the Linux > > kernel's sched_getaffinity() for be

Re: [PATCH v3] Cygwin: Fix return value of sched_getaffinity

On Jun 28 17:13, Corinna Vinschen wrote: > On Jun 27 09:13, Corinna Vinschen wrote: > > On Jun 26 02:44, Mark Geisert wrote: > > > Have sched_getaffinity() interface like glibc's, and provide an > > > undocumented internal interface __sched_getaffinity_sys

Re: [PATCH] Cygwin: Implement CPU_SET(3) macros

f from RTEMS and Cygwin into a single definition. It's not exactly straightforward given the different definition of cpuset_t from FreeBSD, but it's probably not very complicated either. Maybe something for after your vaca? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 4/5] Cygwin: fix GCC 8.3 'asm volatile' errors

Hi Ken, On Jul 16 17:34, Ken Brown wrote: > Remove 'volatile'. What happened to asm volatile? Can you add a short description (single sentence) to the commit msg explaining why this is a problem now? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Des

Re: [PATCH 0/5] Port to GCC 8.3

-- > 2.21.0 ACK to the series with just a short description in terms of asm volatile. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: make path_conv::isdevice() return false on socket files

ce() is used by is_lnk_special() only, is_auto_device() doesn't have much meaning, some funcs have underscores, some don't. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: unbreak the build with GCC 7

On Jul 19 18:27, Ken Brown wrote: > The recent port to GCC 8 used the 'nonstring' attribute, which is > unknown to GCC 7. Define and use an 'ATTRIBUTE_NONSTRING' macro > instead. LGTM, please push. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer s

Re: [PATCH 0/4] Fix rename bug with socket files

push. Corinna P.S: Did you see https://cygwin.com/ml/cygwin/2019-07/msg00152.html, by any chance? Looks like a regression from the new FIFO code. -- Corinna Vinschen Cygwin Maintainer

Re: [PATCH] Cygwin: fix one more check for positive virtual_ftype_t values

buf->st_gid = gid; > buf->st_mode &= ~(S_IWUSR | S_IWGRP | S_IWOTH); > - if (file_type > virt_none) > + if (virt_ftype_isdir (file_type)) > buf->st_mode |= S_IFDIR; > else > buf->st_mode &= NO_X; > -- > 2.21.0 -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 1/1] Cygwin: don't allow getpgrp() to fail

. > Change getpgrp() so that it doesn't fail even if getpgid() fails. Instead of calling getpgid(0), we could just as well return myself->pgid. This never fails for sure. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 1/1] Cygwin: don't allow getpgrp() to fail

On Jul 23 18:54, Corinna Vinschen wrote: > Hi Ken, > > On Jul 23 16:12, Ken Brown wrote: > > According to POSIX, "The getpgrp() function shall always be successful > > and no return value is reserved to indicate an error." Cygwin's > > getpgrp() is defin

Re: [PATCH 1/1] Cygwin: don't allow getpgrp() to fail

On Jul 23 18:59, Corinna Vinschen wrote: > On Jul 23 18:54, Corinna Vinschen wrote: > > Hi Ken, > > > > On Jul 23 16:12, Ken Brown wrote: > > > According to POSIX, "The getpgrp() function shall always be successful > > > and no return value

Re: [PATCH 1/1] Cygwin: don't allow getpgrp() to fail

On Jul 23 19:07, Jon Turney wrote: > On 23/07/2019 17:54, Corinna Vinschen wrote: > > Hi Ken, > > > > On Jul 23 16:12, Ken Brown wrote: > > > According to POSIX, "The getpgrp() function shall always be successful > > > and no return value is reserved to

Re: [PATCH 1/1] Cygwin: don't allow getpgrp() to fail

On Jul 24 15:04, Ken Brown wrote: > On 7/23/2019 3:16 PM, Corinna Vinschen wrote: > > On Jul 23 19:07, Jon Turney wrote: > >> On 23/07/2019 17:54, Corinna Vinschen wrote: > >>> Hi Ken, > >>> > >>> On Jul 23 16:12, Ken Brown wrote: > >>

Re: [PATCH] Cygwin: fhandler_termios::tcsetpgrp: check that argument is non-negative

tion why this fixes the problem and it's GTG. Unfortunately it doesn't fix what I'm seeing under GDB 8.1.1, but I'm more and more convinced this is GDB's fault. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

[PATCH] Cygwin: Fix the address of myself

From: Corinna Vinschen Introducing an independent Cygwin PID introduced a regression: The expectation is that the myself pinfo pointer always points to a specific address right in front of the loaded Cygwin DLL. However, commit b5e1003722cb14235c4f166be72c09acdffc62ea "Cygwin: processes

[PATCH v2] Cygwin: Fix the address of myself

From: Corinna Vinschen v2: rephrase commit message Introducing an independent Cygwin PID introduced a regression: The expectation is that the myself pinfo pointer always points to a specific address right in front of the loaded Cygwin DLL. However, the independent Cygwin PID changes broke

Re: [PATCH v2] Cygwin: Fix the address of myself

On Jul 24 19:11, Ken Brown wrote: > On 7/24/2019 12:54 PM, Corinna Vinschen wrote: > > From: Corinna Vinschen > > > > v2: rephrase commit message > > > > Introducing an independent Cygwin PID introduced a regression: > > > > The expectation is tha

Re: [PATCH] Cygwin: Implement CPU_SET(3) macros

Hi Mark, On Jul 1 01:55, Mark Geisert wrote: > Corinna Vinschen wrote: > > On Jun 30 15:59, Mark Geisert wrote: > > > This patch supplies an implementation of the CPU_SET(3) processor > > > affinity macros as documented on the relevant Linux man page. > > > -

Re: [PATCH v2] Cygwin: Fix the address of myself

On Jul 25 19:59, Ken Brown wrote: > On 7/25/2019 9:37 AM, Corinna Vinschen wrote: > > On Jul 24 19:11, Ken Brown wrote: > >> On 7/24/2019 12:54 PM, Corinna Vinschen wrote: > >>> From: Corinna Vinschen > >>> > >>> v2: rephrase commit mes

Re: [PATCH] Cygwin: Implement CPU_SET(3) macros

On Jul 25 14:15, Mark Geisert wrote: > Corinna Vinschen wrote: > > Hi Mark, > > > > On Jul 1 01:55, Mark Geisert wrote: > > > Corinna Vinschen wrote: > > > > On Jun 30 15:59, Mark Geisert wrote: > > > > > This patch supplies an implementat

Re: [PATCH] Cygwin: Implement CPU_SET(3) macros

On Jul 30 02:25, Mark Geisert wrote: > On Fri, 26 Jul 2019, Corinna Vinschen wrote: > > On Jul 25 14:15, Mark Geisert wrote: > > > Corinna Vinschen wrote: > > > > Hi Mark, > > > > > > > > On Jul 1 01:55, Mark Geisert wrote: > > >

Re: [PATCH 0/2] silent fork retry with shm (broke emacs-X11)

uot;_and_attach" does feel wrong. I'd prefer to drop the reattach call from remember, calling both of them where appropriate. Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v2 0/2] silent fork retry with shm (broke emacs-X11)

On Jul 31 12:35, Michael Haubenwallner wrote: > Hi Corinna, > > On 7/30/19 6:07 PM, Corinna Vinschen wrote: > > Hi Michael, > > > > On Jul 30 17:22, Michael Haubenwallner wrote: > >> Hi, > >> > >> following up > >> https://cygwin.com

Re: [PATCH v2] Cygwin: Implement CPU_SET(3) macros

eak and additional doc changes. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

[PATCH] Cygwin: exec: check execute bit prior to evaluating script

From: Corinna Vinschen When the exec family of functions is called for a script-like file, the av::setup function handles the exec[vl]p case as well. The execve case for files not starting with a she-bang is handled first by returning ENOEXEC. Only after that, the file's executabili

Re: [PATCH] Cygwin: exec: check execute bit prior to evaluating script

On Aug 6 12:09, Ken Brown wrote: > On 8/6/2019 4:53 AM, Corinna Vinschen wrote: > > From: Corinna Vinschen > > > > When the exec family of functions is called for a script-like > > file, the av::setup function handles the exec[vl]p case as > > well. The execve

Re: [PATCH] Cygwin: build_env: fix off-by-one bug when re-adding PATH

(WCHAR) + 5; > + new_tl += cygheap->installation_dir.Length / sizeof (WCHAR) + 5 + 1; > if (new_tl > tl) > tl = raise_envblock (new_tl, envblock, s); > s = wcpcpy (wcpcpy (s, L"PATH="), > -- > 2.21.0 Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: shmat: use mmap allocator strategy on 64 bit

On Aug 8 16:06, Ken Brown wrote: > On 8/8/2019 4:55 AM, corinna-cyg...@cygwin.com wrote: > > From: Corinna Vinschen > > > > This avoids collisions of shmat maps with Windows own datastructures > > when allocating top-down. > > > > This patch moves the m

Re: [PATCH 0/1] Fix deadlock at calling fork() in console

rk(). > > winsup/cygwin/fhandler_console.cc | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > -- > 2.21.0 Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 1/1] Cygwin: console: Add workaround for windows xterm compatible mode bug.

amp;dwLen, 0); > + } > + /* Restore cursor position */ > + SetConsoleCursorPosition (get_output_handle (), sbi.dwCursorPosition); > + } >get_ttyp ()->kill_pgrp (SIGWINCH); >return true; > } > -- > 2.21.0 Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 0/1] Fix cursor position restoration on console

h fixes this problem. > > Takashi Yano (1): > Cygwin: console: Fix cursor position restore after screen alternation. > > winsup/cygwin/fhandler_console.cc | 3 +++ > 1 file changed, 3 insertions(+) > > -- > 2.21.0 Pushed. Thanks, Corinna -- Corinna Vin

Re: [PATCH 1/1] Cygwin: console: Fix the condition to interrupt select() by SIGWINCH

.sa_handler != SIG_IGN > + && global_sigs[SIGWINCH].sa_handler != SIG_DFL) > { > set_sig_errno (EINTR); > fh->release_input_mutex (); > -- > 2.21.0 Do you think a similar workaround would help for the signalfd problem? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 1/1] Cygwin: console: Fix workaround for horizontal tab position

t; 1 file changed, 29 insertions(+), 18 deletions(-) Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 1/1] Cygwin: console: Fix the condition to interrupt select() by SIGWINCH

.sa_handler != SIG_IGN > + && global_sigs[SIGWINCH].sa_handler != SIG_DFL) > { > set_sig_errno (EINTR); > fh->release_input_mutex (); > -- > 2.21.0 Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: ldd: Try harder to get dll names

; --- > winsup/utils/Makefile.in | 2 +- > winsup/utils/ldd.cc | 44 +++- > 2 files changed, 44 insertions(+), 2 deletions(-) Great idea, pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: get_posix_access: avoid negative subscript

has_def_class_perm = true; > + def_class_perm = lacl[pos].a_perm; > } > - has_def_class_perm = true; > - def_class_perm = lacl[pos].a_perm; > } > } > } > -- > 2.21.0 -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: get_posix_access: avoid negative subscript

On Aug 27 20:00, Ken Brown wrote: > On 8/27/2019 4:13 AM, Corinna Vinschen wrote: > > On Aug 26 17:43, Ken Brown wrote: > >> Don't refer to lacl[pos] unless we know that pos >= 0. > > > > I'm not sure this is entirely right. Moving the assignmen

Re: [PATCH v4 1/1] Cygwin: pty: Fix state management for pseudo console support.

a lot? We're still not using the NT functions throughout outside of the console/tty code. In terms of USE_OWN_NLS_FUNC: - Why do we need this function at all? Can't this be handled by __loadlocale instead? If not, what is __loadlocale missing to make this work without duplicating the function? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v4 1/1] Cygwin: pty: Fix state management for pseudo console support.

t; Ideally, the cause of the error should be found out, I suppose. Indeed. We can keep the code in for now, but the end result should call a tweaked version of __loadlocale instead. As long as the tweak only requires a single extra argument, or if the category or new_locale argument can be used as indicator to trigger the required special behavour, we should have no problem to get that into newlib. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 4/4] Cygwin: pty: Limit API hook to the program linked with the APIs.

only this througout. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v5 0/1] Fix PTY state management in pseudo console support.

cygwin/fhandler.h | 6 +- > winsup/cygwin/fhandler_console.cc | 25 +- > winsup/cygwin/fhandler_tty.cc | 385 -- > winsup/cygwin/fork.cc | 24 +- > winsup/cygwin/spawn.cc| 65 ++--- > 6 files changed, 289 insertions(+

Re: [PATCH 1/2] Cygwin: pty: Add a workaround for ^C handling.

t; patch is a workaround for this issue. If this workaround works, what about making it the standard behaviour, rather than pseudo-console only? Would there be a downside? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 2/2] Cygwin: pty: Disable clear screen on new pty if TERM=dumb or emacs*.

r_screen) > +{ > + const char *term = getenv ("TERM"); > + if (term && strcmp (term, "dumb") && !strstr (term, "emacs")) Why do you check the TERMs again here? After all, need_clear_screen is only true if one of these terms are used. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 4/4] Cygwin: pty: Limit API hook to the program linked with the APIs.

Hi Takashi, On Sep 4 21:39, Takashi Yano wrote: > Hi Corinna, > > On Wed, 4 Sep 2019 12:03:51 +0200 > Corinna Vinschen wrote: > > I'll push the other 3 patches from this series. For this patch, > > I wonder why you create set_ishybrid_and_switch_to_pcon while

Re: [PATCH 1/2] Cygwin: pty: Add a workaround for ^C handling.

On Sep 4 22:30, Takashi Yano wrote: > On Wed, 4 Sep 2019 12:42:22 +0200 > Corinna Vinschen wrote: > > If this workaround works, what about making it the standard behaviour, > > rather than pseudo-console only? Would there be a downside? > > I am not sure why, but co

Re: [PATCH 2/2] Cygwin: pty: Disable clear screen on new pty if TERM=dumb or emacs*.

On Sep 4 21:49, Takashi Yano wrote: > On Wed, 4 Sep 2019 12:47:38 +0200 > Corinna Vinschen wrote: > > Why do you check the TERMs again here? After all, need_clear_screen > > is only true if one of these terms are used. > > Because, emacs seems to set environment TER

Re: [PATCH v2 1/1] Cygwin: pty: Limit API hook to the program linked with the APIs.

p/cygwin/fhandler_tty.cc | 106 +++--- > winsup/cygwin/smallprint.cc | 2 + > winsup/cygwin/strace.cc | 26 + > winsup/cygwin/winsup.h| 3 + > 4 files changed, 66 insertions(+), 71 deletions(-) Pushed. Thanks, Corinna -- Corinna Vinschen Cyg

Re: [PATCH v2 0/1] Cygwin: pty: Add a workaround for ^C handling.

nsertions(+), 1 deletion(-) > > -- > 2.21.0 Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 2/2] Cygwin: pty: Disable clear screen on new pty if TERM=dumb or emacs*.

On Sep 4 15:11, Ken Brown wrote: > On 9/4/2019 10:42 AM, Takashi Yano wrote: > > On Wed, 4 Sep 2019 15:55:03 +0200 > > Corinna Vinschen wrote: > >> The code in fixup_after_attach() is the only code snippet setting > >> need_clear_screen = true. And that

Re: [PATCH v2 0/1] Disable clear screen on new pty if TERM=dumb or emacs*.

p/cygwin/tty.h | 1 + > 3 files changed, 16 insertions(+), 5 deletions(-) > > -- > 2.21.0 Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

<    4   5   6   7   8   9   10   11   12   13   >