Re: [PATCH v2] Introduce the 'usertemp' filesystem type

2015-12-07 Thread Corinna Vinschen
On Dec 1 15:50, Johannes Schindelin wrote: > Hi Corinna, > > On Tue, 1 Dec 2015, Corinna Vinschen wrote: > > > On Dec 1 15:02, Johannes Schindelin wrote: > > > * mount.cc (mount_info::from_fstab_line): support mounting the > > > current user's t

Re: Trivial fix to last change

2015-12-14 Thread Corinna Vinschen
5-12-11 Ken Brown > + > + * fhandler_disk_file.cc (fhandler_base::fstat_helper): Align > + regparm attribute to declaration in fhandler.h. > + > 2015-12-10 Corinna Vinschen > > * path.h (class path_conv_handle): Use FILE_ALL_INFORMATION instead of > di

Re: Trivial fix to last change

2015-12-14 Thread Corinna Vinschen
On Dec 14 08:38, cyg Simple wrote: > On 12/14/2015 4:25 AM, Corinna Vinschen wrote: > > On Dec 11 17:14, Ken Brown wrote: > >> cygwin1.dll doesn't build on x86 after the last commit (eed35ef). The > >> trivial patch attached fixes

Re: [PATCH v2 1/2] Allow deriving the current user's home directory via the HOME variable

2015-12-17 Thread Corinna Vinschen
> +env > +Derives the home directory of the current user from the > + environment variable HOME (falling back to > + HOMEDRIVE\HOMEPATH and > + USERPROFILE, in that order). This is faster > + than the windows schema at the &

Re: [PATCH v2 2/2] Respect `db_home` setting even for the SYSTEM account

2015-12-17 Thread Corinna Vinschen
in accounts. The better approach might be to call the PUSER_INFO_3 variant of cygheap_pwdgrp::get_home with a NULL ui pointer and just check for ui in the NSS_SCHEME_DESC case. The other called functions fetch_windows_home and fetch_from_path both can live with both pointers, pldap and ui

Re: [PATCH v2 2/2] Respect `db_home` setting even for the SYSTEM account

2015-12-17 Thread Corinna Vinschen
On Dec 17 21:49, Corinna Vinschen wrote: > On Dec 17 19:05, Johannes Schindelin wrote: > > We should not blindly set the home directory of the SYSTEM account to > > /home/SYSTEM, especially not when that value disagrees with what is > > configured via the `db_home` line in th

Re: [PATCH] Update FAQ question and answer about gdb and signals

2016-01-14 Thread Corinna Vinschen
led (second chance) > +exception occurs. > > + > + > +There is also an experimental feature to notify gdb of purely Cygwin signals > +like SIGABRT, SIGHUP or SIGUSR1. This currently has some known problems, for > +example, single-stepping from these signals may not work a

Re: [PATCH][RFC] POSIX barrier implementation, take 1

2016-02-11 Thread Corinna Vinschen
#x27;t be unhappy if you'd have a more stern look into the pthread implementation apart from barriers. There are probably more shortcomings... Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT

Re: [PATCH] cygwin: fix errors with GCC 5

2016-02-12 Thread Corinna Vinschen
not the right fix. debugging is still a bool and you changed the condition just to get rid of the warning. The right fix is to keep the condition and change the type of debugging to, e.g, int. The gnu_inline snippets are ok, but I'd like to see a description of what effect this is fixing

Re: [PATCH] cygwin: update child info magic

2016-02-12 Thread Corinna Vinschen
get a message indicating that it is out-of-sync. > */ > -#define CURR_CHILD_INFO_MAGIC 0x30ea98f6U > +#define CURR_CHILD_INFO_MAGIC 0xf67f938cU This needs an explanation. CHILD_INFO_MAGIC is still 0x30ea98f6U for me. Corinna -- Corinna Vinschen Please, send mails regard

Re: [PATCH] POSIX barrier implementation, take 2

2016-02-12 Thread Corinna Vinschen
SIGFE > pthread_continue SIGFE > pthread_create SIGFE > pthread_detach SIGFE These should be added in alphabetic order. > +#define LIKELY(X) __builtin_expect (!!(X), 1) > +#define UNLIKELY(X) __builtin_expect (!!(X), 0) May I suggest to use lowercase "likely/unlikely"

Re: [PATCH] cygwin: update child info magic

2016-02-12 Thread Corinna Vinschen
On Feb 12 10:53, Yaakov Selkowitz wrote: > On 2016-02-12 03:33, Corinna Vinschen wrote: > >On Feb 11 20:38, Yaakov Selkowitz wrote: > >>winsup/cygwin/ > >>* child_info.h (CURR_CHILD_INFO_MAGIC): Update. > > > >This needs an explanation. CHILD_IN

Re: [PATCH v2] cygwin: fix errors with GCC 5

2016-02-12 Thread Corinna Vinschen
e. > * winbase.h (ilockcmpexch, ilockcmpexch64): Ditto. > > Signed-off-by: Yaakov Selkowitz ACK Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] cygwin: update child info magic

2016-02-12 Thread Corinna Vinschen
On Feb 12 14:05, Yaakov Selkowitz wrote: > On 2016-02-12 11:18, Corinna Vinschen wrote: > >On Feb 12 10:53, Yaakov Selkowitz wrote: > >>On 2016-02-12 03:33, Corinna Vinschen wrote: > >>>On Feb 11 20:38, Yaakov Selkowitz wrote: > >>>> winsup/cygwin/

Re: [PATCH v2] cygwin: work around GCC 5 preprocessor changes

2016-02-13 Thread Corinna Vinschen
-by: Yaakov Selkowitz Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] POSIX barrier implementation, take 3

2016-02-13 Thread Corinna Vinschen
On Feb 12 22:25, Václav Haisman wrote: > On 12.2.2016 15:25, Corinna Vinschen wrote: > > Hi Václav, > > > > > > the patch looks pretty good, I have just a few (minor) nits: > > [...] > The attached patch should address all of the review comments.

Re: Cygwin select() issues and improvements

2016-02-15 Thread Corinna Vinschen
;re also available on > <https://github.com/cgull/newlib-cygwin>, branch 'microsecond-select'. > I think it's all Windows XP compatible. I've put some test programs up > at <https://github.com/cgull/cygwin-timeouts> too. XP/2K3 compatibility is not requi

Re: gprof profiling of multi-threaded Cygwin programs

2016-02-17 Thread Corinna Vinschen
gt;lowpc && pc < p->highpc) > - { > - idx = PROFIDX (pc, p->lowpc, p->scale); > - p->counter[idx]++; > - } > + // record profiling sample for main thread > + profthr_byhandle (p->targthr); > + > + // record profiling sa

Re: gprof profiling of multi-threaded Cygwin programs

2016-02-18 Thread Corinna Vinschen
On Feb 17 22:35, Mark Geisert wrote: > On Wed, 17 Feb 2016, Corinna Vinschen wrote: > >On Feb 16 21:28, Mark Geisert wrote: > >>There is a behavioral change that ought to be documented somewhere: If a > > > >If it ought to be documented, what about providing the doc

Re: [PATCH] cygwin: accept SIGIOT as alias of SIGABRT

2016-02-18 Thread Corinna Vinschen
: Yaakov Selkowitz ACK, please apply. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] Multiple timer issues

2016-02-18 Thread Corinna Vinschen
ely, but as far as I can see it relies on patch 1. Without patch 1, exchanging gtod with ntod will not change anything since it's still a non-monotonic timer. Or am I missing something? Thanks a lot, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: gprof profiling of multi-threaded Cygwin programs

2016-02-18 Thread Corinna Vinschen
ss could be > tricky. > > A brief search tells me that apparently glibc supports the (undocumented) > GMON_OUT_PREFIX env var which enables a similar behaviour. Good point. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] ssp: Fixes for 64-bit

2016-02-18 Thread Corinna Vinschen
Even so, better than today. Feel free to apply the patch. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: Cygwin select() issues and improvements

2016-02-19 Thread Corinna Vinschen
On Feb 18 20:20, john hood wrote: > On 2/15/16 7:57 AM, Corinna Vinschen wrote: > > On Feb 14 03:09, john hood wrote: > >> Various issues with Cygwin's select() annoyed me, and I've spent some > >> time gnawing on them. > > One of them is that they are

Re: gprof profiling of multi-threaded Cygwin programs

2016-02-19 Thread Corinna Vinschen
On Feb 18 16:57, Mark Geisert wrote: > On Thu, 18 Feb 2016, Corinna Vinschen wrote: > >On Feb 17 22:35, Mark Geisert wrote: > >>I do see that a case could be made for general profiling documentation in > >>winsup/doc/programming.xml but that's more than I w

Re: [PATCH] cygwin: Export clog10, clog10f

2016-02-19 Thread Corinna Vinschen
newlib patch is ok. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] Multiple timer issues + new [PATCH]

2016-02-19 Thread Corinna Vinschen
On Feb 19 00:39, Irányossy Knoblauch Artúr wrote: > Hi, > > On Thu, Feb 18, 2016 at 12:28 PM, Corinna Vinschen > wrote: > > > Would you mind terribly to send a copyright assignment per > > https://cygwin.com/contrib.html? If you send it as PDF by mail it takes > &

Re: [PATCH] gprof profiling of multi-threaded Cygwin programs, ver 2

2016-02-22 Thread Corinna Vinschen
ht on space here so we should err on the side of caution and leave room for the entire possible size of a Windows PID. That's a LONG, 32 bit, 10 decimal digits. Other than that, the patch looks good to me. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] gprof profiling of multi-threaded Cygwin programs, ver 2

2016-02-22 Thread Corinna Vinschen
gt; > Hmm.. so why isn't this written as cygheap_profthr_all (profthr_byhandle) ? I asked for it: https://cygwin.com/ml/cygwin-patches/2016-q1/msg00028.html Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT

Re: [PATCH] gprof profiling of multi-threaded Cygwin programs, ver 2

2016-02-22 Thread Corinna Vinschen
On Feb 22 16:14, Jon Turney wrote: > On 22/02/2016 14:25, Corinna Vinschen wrote: > >On Feb 22 11:44, Jon Turney wrote: > >>Thanks for this. A few comments inline. > >>[...] > >>On 20/02/2016 08:16, Mark Geisert wrote: > >>>+ // rec

Re: [PATCH] gprof profiling of multi-threaded Cygwin programs, ver 2

2016-02-23 Thread Corinna Vinschen
On Feb 22 22:58, Mark Geisert wrote: > On Mon, 22 Feb 2016, Corinna Vinschen wrote: > >One is, for completeness it would be nice if you could add a > >description to the git comment along the lines of your original > >comment so we have a description in the log. > > S

Re: [PATCH] gprof profiling of multi-threaded Cygwin programs, ver 2

2016-02-23 Thread Corinna Vinschen
er need to make this generic we can still do it. > >>+ if ((prefix = getenv("GMON_OUT_PREFIX")) != NULL) { > > > >setup-env.xml might be an appropriate place to mention this environment > >variable. > > I am now writing a gprof.xml that will be tied into th

Re: [PATCH] gprof profiling of multi-threaded Cygwin programs, ver 2

2016-02-25 Thread Corinna Vinschen
On Feb 25 00:47, Mark Geisert wrote: > On Tue, 23 Feb 2016, Corinna Vinschen wrote: > >On Feb 22 23:36, Mark Geisert wrote: > >>On Mon, 22 Feb 2016, Jon Turney wrote: > >>>There doesn't seem to be anything specific to profiling about this, so it > >>

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-02-29 Thread Corinna Vinschen
uild systems. When cross building Cygwin on, e.g., Linux, "C.UTF-8" is an unrecognized locale. Ideally the above would test for the current build system being Cygwin and use "C.UTF-8" on Cygwin, "C" otherwise. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-02-29 Thread Corinna Vinschen
On Feb 29 13:19, m...@patrick-bendorf.de wrote: > Hi Corinna, > > Am 2016-02-29 11:33, schrieb Corinna Vinschen: > >Hi Patrick, > > > >On Feb 29 08:12, Patrick Bendorf wrote: > >>/winsup/ > >>* ccwrap: fix build with non-english locale set > &g

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-02-29 Thread Corinna Vinschen
ot;$ENV{'LANG'} = 'C';" right? As that has to work > everywhere? Uh, I missed that. Yes, of course that should work, too. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-02-29 Thread Corinna Vinschen
27;LANG'} = 'C'; > -} > +$ENV{'LANG'} = 'C'; > my @compiler = split ' ', $ENV{$ccorcxx}; > if ("@ARGV" !~ / -nostdinc/o) { > my $fd; > -- > 2.7.0 Patch applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-03-04 Thread Corinna Vinschen
er the open('-|') ? are you going to look into this by any chance? Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: Cygwin select() issues and improvements

2016-03-04 Thread Corinna Vinschen
John, Ping? I'd be interested to get your patches into Cygwin. select really needs some kicking :) Thanks, Corinna On Feb 19 11:46, Corinna Vinschen wrote: > On Feb 18 20:20, john hood wrote: > > On 2/15/16 7:57 AM, Corinna Vinschen wrote: > > > On Feb 14

Re: [PATCH] Multiple timer issues

2016-03-04 Thread Corinna Vinschen
Artúr, Ping? Any news on your CA? Did you get my reply to your mail to ges-info? Thanks, Corinna On Feb 18 12:28, Corinna Vinschen wrote: > Hi Artúr, > > On Feb 17 23:30, Irányossy Knoblauch Artúr wrote: > > Dear Cygwin Maintainers, > > > > First of all, thank

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-03-04 Thread Corinna Vinschen
On Mar 4 10:22, Patrick Bendorf wrote: > hi corinna, > > i might find some time this weekend. this last few days were just > too much to look into the issue. Cool, thanks! Corinna > patrick > > Am 04.03.2016 um 09:56 schrieb Corinna Vinschen: > >Patrick, > &g

Re: [PATCH] Mention 64-bit Cygwin as another remedy for fork() failures.

2016-03-04 Thread Corinna Vinschen
On Mar 4 19:56, Alexey Sokolov wrote: > Hello, patch to FAQ is attached. Applied. Thanks you, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] faq: Sort BLODA list and update advice on fixing fork failures

2016-03-08 Thread Corinna Vinschen
be wrong here, do you have a different experience? If so, feel free to check in your patch as is. Thanks. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] Support profiling of multi-threaded apps.

2016-03-09 Thread Corinna Vinschen
bail if anything amiss. */ /* Record profiling samples for other pthreads, if any. */ With these changes I'll apply the patch. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] Support profiling of multi-threaded apps.

2016-03-10 Thread Corinna Vinschen
On Mar 9 16:54, Mark Geisert wrote: > On Wed, 9 Mar 2016, Corinna Vinschen wrote: > >Hi Mark, > > > >On Mar 9 00:39, Mark Geisert wrote: > >>This is Version 3 incorporating review comments of Version 2. This is just > >>the code patch; a separate doc patch

Re: [PATCH] Support profiling of multi-threaded apps.

2016-03-10 Thread Corinna Vinschen
s that an oversight or did you decide to keep it a long? Either way, no reason to resend another patch version. If you want an int32_t here, I fix that locally before pushing the patch. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin t

Re: [PATCH] Support profiling of multi-threaded apps.

2016-03-10 Thread Corinna Vinschen
On Mar 10 10:39, Corinna Vinschen wrote: > On Mar 10 00:35, Mark Geisert wrote: > > This is Version 4 incorporating review comments of Version 3. This is just > > the code patch; a separate doc patch is forthcoming. > > Uhm... > > > + long divisor = 1000

Re: [PATCH] Support profiling of multi-threaded apps.

2016-03-10 Thread Corinna Vinschen
On Mar 10 11:11, Mark Geisert wrote: > On Thu, 10 Mar 2016, Corinna Vinschen wrote: > >On Mar 10 10:39, Corinna Vinschen wrote: > >>On Mar 10 00:35, Mark Geisert wrote: > >>>This is Version 4 incorporating review comments of Version 3. This is just > >>&

Re: [PATCH] Documentation covering profiling Cygwin programs.

2016-03-11 Thread Corinna Vinschen
any comments y'all may have on formatting and/or content. > Thanks much, Only one comment: This looks really neat. Patch applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com R

Re: [PATCH] spinlock spin with pause instruction

2016-03-11 Thread Corinna Vinschen
CPU make such busy loops be less busy. Here is a patch to do this. Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] Re: Cygwin select() issues and improvements

2016-03-14 Thread Corinna Vinschen
Hi John, On Mar 13 17:37, john hood wrote: > On 3/4/16 3:58 AM, Corinna Vinschen wrote: > > John, > > > > > > Ping? I'd be interested to get your patches into Cygwin. select > > really needs some kicking :) > > Sorry to be so slow responding. H

Re: [PATCH] Cygwin: define byteswap.h inlines as macros

2016-03-15 Thread Corinna Vinschen
gt;> 32)); > } > > +#define bswap_16(x) __bswap_16(x) > +#define bswap_32(x) __bswap_32(x) > +#define bswap_64(x) __bswap_64(x) > + > #ifdef __cplusplus > } > #endif > -- > 2.7.0 ACK. While we're at it, what about converting the type

Re: [PATCH] Cygwin: define byteswap.h inlines as macros

2016-03-15 Thread Corinna Vinschen
On Mar 15 04:14, Yaakov Selkowitz wrote: > On 2016-03-15 04:03, Corinna Vinschen wrote: > >On Mar 14 22:13, Yaakov Selkowitz wrote: > >>The bswap_* "functions" are macros in glibc, so they may be tested for > >>by the preprocessor (e.g. #ifdef bswap_16). &

Re: [PATCH] Cygwin: define byteswap.h inlines as macros

2016-03-15 Thread Corinna Vinschen
On Mar 15 04:41, Yaakov Selkowitz wrote: > On 2016-03-15 04:22, Corinna Vinschen wrote: > >On Mar 15 04:14, Yaakov Selkowitz wrote: > >>On 2016-03-15 04:03, Corinna Vinschen wrote: > >>>On Mar 14 22:13, Yaakov Selkowitz wrote: > >>>>The bswap_* &q

Re: [PATCH] Cygwin: define byteswap.h inlines as macros

2016-03-15 Thread Corinna Vinschen
ine bswap_16(x) __bswap_16(x) > > +#define bswap_32(x) __bswap_32(x) > > +#define bswap_64(x) __bswap_64(x) > > + > > #ifdef __cplusplus > > } > > #endif > > -- > > 2.7.0 > > > > Would it not be better to leave the original functions as th

Re: Console requested reports – Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.5.0-0.6

2016-03-15 Thread Corinna Vinschen
Hi Thomas, Thanks for the patch. I have a few comments, though. On Mar 15 14:16, Thomas Wolff wrote: > On 13.03.2016, Corinna Vinschen wrote: > >- Make buffered console characters visible to select(). > > Addresses: https://cygwin.com/ml/cygwin/2014-12/msg00118.html >

Re: [PATCH] Attempt to fix Coverity issues in ssp

2016-03-15 Thread Corinna Vinschen
flow and malloc failure. Thanks, please apply. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: Console requested reports – Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.5.0-0.6

2016-03-16 Thread Corinna Vinschen
onsole buffer (shared between CONOUT/CONIN) > instead of fhandler buffer (separated). > * select.cc (peek_console): Check console read-ahead buffer. Patch applied. Do you have a short text for the release message? Thanks, Corinna -- Corinna Vinschen Please, send

Re: Console requested reports – Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.5.0-0.6

2016-03-19 Thread Corinna Vinschen
On Mar 16 23:08, Thomas Wolff wrote: > Am 16.03.2016 um 10:28 schrieb Corinna Vinschen: > >On Mar 15 22:40, Thomas Wolff wrote: > >>Hi Corinna, > >>here is my updated patch. > >>>Changelog (old format): > >>>Just drop this line from the comment

Re: [PATCH 01/11] Remove unused and unsafe call to __builtin_frame_address

2016-03-20 Thread Corinna Vinschen
ib.html There's an assign.txt document you (and potentiall your employer) can sign and send as PDF. It's usually rather painless. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT co

Re: [PATCH 01/11] Remove unused and unsafe call to __builtin_frame_address

2016-03-20 Thread Corinna Vinschen
initial sp was. The value is needed > - when copying the parent's stack to the child during a fork. */ > - u->initial_sp = (char *) __builtin_frame_address (1); > + /* Unused */ > + u->initial_sp = nullptr; We're not building in C++11 mode yet. I fixed that locally

Re: [PATCH 03/11] Add necessary braces to if statements

2016-03-20 Thread Corinna Vinschen
es to if statement. Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH 02/11] Remove dead code from fhandler_console.

2016-03-20 Thread Corinna Vinschen
if (b.dwSize.Y != b.dwSize.Y || b.dwSize.X != b.dwSize.X) >~~~^ > > winsup/cygwin/ChangeLog > * fhandle_console.cc (fillin): remove dead code Applied. Thanks, Corinna -- Corinna Vinschen P

Re: [PATCH 04/11] Remove misleading indentation

2016-03-20 Thread Corinna Vinschen
t's treated as incorrect is the special handling added in the #ifdef __CYGWIN__ block. Changing the indentation just to satisfy the special Cygwin case is not the way to go. Ohter than that, partially applied. Thanks, Corinna -- Corinna Vinschen Please, send mai

Re: [PATCH 05/11] A pointer to a pointer is nonnull.

2016-03-20 Thread Corinna Vinschen
emptr is always non-NULL? An application can call posix_memalign(NULL, 4096, 4096) just fine, can't it? If so, *memptr = res crashes. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red

Re: [PATCH 07/11] The address of an class always evaluates to true

2016-03-20 Thread Corinna Vinschen
check. Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH 08/11] Fix typoed comparison

2016-03-20 Thread Corinna Vinschen
On Mar 19 13:45, Peter Foley wrote: > winsup/cygwin/ChangeLog > * thread.cc (semaphore::open): Fix mistaken conditional. Applied. THanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com R

Re: [PATCH 10/11] Fix strict aliasing

2016-03-20 Thread Corinna Vinschen
On Mar 19 13:45, Peter Foley wrote: > Fix a strict aliasing error detected by gcc 6.0+ > > winsup/cygwin/ChangeLog > * pinfo.cc (winpids::enum_process): Fix strict aliasing. Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwi

Re: [PATCH 09/11] Add c++14 sized deallocation operator

2016-03-20 Thread Corinna Vinschen
+29,11 @@ operator delete (void *p) > { >free (p); > } > +void > +operator delete (void *p, size_t) > +{ > + ::operator delete(p); > +} > > void * > operator new[] (std::size_t s) > -- > 2.7.4 This looks incomplete to me. Don't we have to

Re: [PATCH 11/11] respect datarootdir

2016-03-20 Thread Corinna Vinschen
On Mar 19 13:45, Peter Foley wrote: > Recent versions of autoconf define datadir/infodir in terms of > datarootdir. Add it. > > winsup/ChangeLog > * Makefile.in: define datarootdir Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding C

Re: Cygwin select() issues and improvements

2016-03-20 Thread Corinna Vinschen
Sidenote from the past: On Feb 15 13:57, Corinna Vinschen wrote: > On Feb 14 03:09, john hood wrote: > > Windows scheduling in general seems to be rather poor for Cygwin > > processes, and there are scheduling differences between processes run in > > Windows console (which ar

Re: [PATCH] Re: Cygwin select() issues and improvements

2016-03-20 Thread Corinna Vinschen
or this case, doesn't it? Alternatively, we could add a per-thread timer handle to the cygtls area. It could be created on first use and deleted when the thread exits. But that's just an idea for a future improvement, never mind for now. > From 3f3f7112f948d70c15046641cf3cc898a9ca4c71 Mon Sep 17 00:00:00 2001 > From: John Hood > Date: Fri, 18 Mar 2016 04:31:16 -0400 > Subject: [PATCH 5/5] * winsup/testsuite/configure: chmod a+x Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH 05/11] A pointer to a pointer is nonnull.

2016-03-21 Thread Corinna Vinschen
On Mar 21 10:19, Peter Foley wrote: > On Sun, Mar 20, 2016 at 7:15 AM, Corinna Vinschen > wrote: > > Eh, what?!? How on earth can gcc assert memptr is always non-NULL? > > An application can call posix_memalign(NULL, 4096, 4096) just fine, > > can't it? If so, *memp

Re: [PATCH 09/11] Add c++14 sized deallocation operator

2016-03-21 Thread Corinna Vinschen
On Mar 21 12:35, Peter Foley wrote: > On Sun, Mar 20, 2016 at 7:28 AM, Corinna Vinschen > wrote: > > This looks incomplete to me. Don't we have to export the symbol? > > I don't believe so. > As I understand it, if you're overriding the standard c++ delete &

Re: [PATCH 09/11] Add c++14 sized deallocation operator

2016-03-21 Thread Corinna Vinschen
On Mar 21 13:46, Peter Foley wrote: > On Mon, Mar 21, 2016 at 1:13 PM, Corinna Vinschen > wrote: > > But we export these functions as fallback functions to the applications. > > See libstdcxx_wrapper.cc and the end of cxx.cc. While the comment in > > cxx.cc claims that

Re: [PATCH v2 3/5] Remove misleading indentation

2016-03-21 Thread Corinna Vinschen
On Mar 21 13:15, Peter Foley wrote: > GCC 6.0+ warns on misleading indentation, so fix it. > > winsup/cygserver/ChangeLog > * sysv_msg.cc (msgsnd): Fix misleading indentation. > * sysv_msg.cc (msgrcv): Ditto. > * sysv_sem.cc (semop): Ditto. Patch applied. Thanks, Corinna --

Re: [PATCH 2/5] Link against libdnsapi to avoid undefined reference

2016-03-21 Thread Corinna Vinschen
added to autoload.cc instead, what exactly is that patch fixing? DnsFree isn't used anywhere in Cygwin. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: Update toplevel files from gcc

2016-03-21 Thread Corinna Vinschen
cc? Yes, but that's time-consuming since there's no automatism. Give me a few days. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH v2 1/5] Add nonnull annotation to posix_memalign.

2016-03-21 Thread Corinna Vinschen
libc/include/stdlib.h: Annotate arg to posix_memalign as > non-null. > > winsup/cygwin/ChangeLog > malloc_wrapper.cc (posix_memalign): Remove always true nonnull check. Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer

Re: [PATCH 4/5] Don't build utils/lsaauth when cross compiling.

2016-03-21 Thread Corinna Vinschen
at case do you not need them, and shouldn't that bordercase(?) be handled by some configure option? Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH 5/5] Add with-only-headers

2016-03-21 Thread Corinna Vinschen
ir requires libstdc++ and that would be fixed by not builing utils as in your other patch, wouldn't it? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH 05/11] A pointer to a pointer is nonnull.

2016-03-21 Thread Corinna Vinschen
On Mar 21 17:37, Peter Rosin wrote: > On 2016-03-20 12:15, Corinna Vinschen wrote: > > On Mar 19 13:45, Peter Foley wrote: > >> GCC 6.0+ can assert that this argument is nonnull. > >> Remove the unnecessary check to fix a warning. > >> > >> w

Re: [PATCH 2/5] Link against libdnsapi to avoid undefined reference

2016-03-21 Thread Corinna Vinschen
On Mar 21 15:45, Peter Foley wrote: > On Mon, Mar 21, 2016 at 3:24 PM, Corinna Vinschen > wrote: > > On Mar 21 13:15, Peter Foley wrote: > >> /home/peter/cross/src/cygwin/winsup/cygwin/libc/minires-os-if.c:289: > >> undefined reference to `DnsFree'

Re: [PATCH 09/11] Add c++14 sized deallocation operator

2016-03-21 Thread Corinna Vinschen
On Mar 21 15:34, Peter Foley wrote: > On Mon, Mar 21, 2016 at 2:09 PM, Corinna Vinschen > wrote: > > I realized that your orignal patch isn't invalidated by this so I tried > > to apply it and we could then add the other stuff later. However, it > > doesn't c

Re: [PATCH 4/5] Don't build utils/lsaauth when cross compiling.

2016-03-21 Thread Corinna Vinschen
On Mar 21 15:52, Peter Foley wrote: > On Mon, Mar 21, 2016 at 3:30 PM, Corinna Vinschen > wrote: > > I'm not sure this is the right thing to do. I'm cross compiling > > Cygwin all the time, and I certainly need the mingw compiler to > > build the utils and lsa

Re: [PATCH 5/5] Add with-only-headers

2016-03-21 Thread Corinna Vinschen
On Mar 21 15:59, Peter Foley wrote: > On Mon, Mar 21, 2016 at 3:47 PM, Corinna Vinschen > wrote: > > On Mar 21 13:15, Peter Foley wrote: > >> When cross-compiling a toolchan targeting cygwin, building cygwin1.dll > >> requires libstdc++v3 to be built. > > >

Re: [PATCH 2/5] Link against libdnsapi to avoid undefined reference

2016-03-21 Thread Corinna Vinschen
On Mar 21 16:19, Peter Foley wrote: > On Mon, Mar 21, 2016 at 3:52 PM, Corinna Vinschen > wrote: > > While you're at it, ideally we make ourselves independent of the MingW > > header version and use DnsFree directly, replacing DnsRecordListFree > > in autoload.cc

Re: Update toplevel files from gcc

2016-03-23 Thread Corinna Vinschen
On Mar 21 16:05, Peter Foley wrote: > On Mon, Mar 21, 2016 at 3:25 PM, Corinna Vinschen > wrote: > > Yes, but that's time-consuming since there's no automatism. Give me > > a few days. > > Sure, I can just carry my local patch until you get a chance to work

Re: [PATCH v2] Use DnsFree instead of deprecated DnsRecordListFree

2016-03-23 Thread Corinna Vinschen
libc/minires-os-if.c:289: > undefined reference to `DnsFree' > > winsup/cygwin/ChangeLog > autoload.cc: Load DnsFree rather then DnsRecordListFree > libc/minires-os-if.cc (cygwin_query): Use DnsFree rather then > DnsRecordListFree Applied. Thanks, Corinna -- Corinna

Re: [PATCH 5/5] Add with-only-headers

2016-03-23 Thread Corinna Vinschen
On Mar 21 17:30, Peter Foley wrote: > On Mon, Mar 21, 2016 at 5:03 PM, Peter Foley wrote: > > On Mon, Mar 21, 2016 at 4:32 PM, Corinna Vinschen > > wrote: > >> Still hmm at this point. AFAICS we only need the handful of definitions > >> for new and delete o

Re: [PATCH v2 1/5] Add nonnull annotation to posix_memalign.

2016-03-23 Thread Corinna Vinschen
> >-int _EXFUN(posix_memalign,(void **, size_t, size_t)); > >+int _EXFUN(__nonnull (1) posix_memalign,(void **, size_t, size_t)); > > #endif > > #endif > > Note the ifdef __rtems__ there; we have our own posix_memalign declaration > in winsup/cygw

Re: [PATCH 09/11] Add c++14 sized deallocation operator

2016-03-23 Thread Corinna Vinschen
On Mar 21 16:03, Peter Foley wrote: > On Mon, Mar 21, 2016 at 3:55 PM, Corinna Vinschen > wrote: > > But using -std= when building Cygwin wouldn't change the fact that we > > might need this delete anyway for applications built with -std=c++14 > > or do I miss

Re: [PATCH] cygwin: export __getpagesize

2016-03-29 Thread Corinna Vinschen
served namespace: > > http://refspecs.linuxfoundation.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/baselib---getpagesize.html > > Signed-off-by: Yaakov Selkowitz Looks good, please apply. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer

Re: [PATCH] cygwin: export __getpagesize

2016-03-29 Thread Corinna Vinschen
On Mar 29 10:11, Corinna Vinschen wrote: > On Mar 28 12:48, Yaakov Selkowitz wrote: > > The inclusion of by , besides causing namespace > > pollution, also makes it very difficult to get the WINVER-dependent parts > > of the former. This affects code (such as x11vnc -

Re: [PATCH] Re: Cygwin select() issues and improvements

2016-03-29 Thread Corinna Vinschen
John, ping? On Mar 20 16:00, Corinna Vinschen wrote: > On Mar 19 18:43, john hood wrote: > > From c805552cdc9e673ef2330388ddb8b7a0da741766 Mon Sep 17 00:00:00 2001 > > From: John Hood > > Date: Thu, 28 Jan 2016 17:08:39 -0500 > > Subject: [PATCH 1/5] Use high-reso

Re: [PATCH 06/11] Remove always true nonnull check on "this" pointer.

2016-03-30 Thread Corinna Vinschen
| PID_REAPED | > PID_EXECED)); Assuming a pinfo constructor called like this: pinfo p (non_existent_pid); then p->_procinfo is NULL. Calling p->exists then calls _pinfo::exists with a NULL this pointer. Analog for the other _pinfo methods. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH v2 1/3] Add option to not build mingw programs when cross compiling.

2016-03-30 Thread Corinna Vinschen
progs" != xyes; then > +AC_CONFIG_SUBDIRS([utils lsaauth]) > +fi Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH 3/3] Use just-built gcc for windres

2016-03-30 Thread Corinna Vinschen
6_64/vanilla/x86_64-pc-cygwin/newlib/ ? Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH] fix typo in netinit/ip.h

2016-03-30 Thread Corinna Vinschen
On Mar 30 09:15, Peter Foley wrote: > The type for the ip_tos member was typoed, fix it. > > winsup/cygwin/ChangeLog: > include/netinet/ip.h: fix type of ip_tos Thanks for catching. Applied. Corinna -- Corinna Vinschen Please, send mails regarding Cygw

Re: [PATCH 3/3] Use just-built gcc for windres

2016-03-30 Thread Corinna Vinschen
es not define the proper > preprocessor macros. > > winsup/cygwin/ChangeLog > mkvers.sh: Manually specify preprocessor based on $CC Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cyg

<    1   2   3   4   5   6   7   8   9   10   >