than for the reparse point itself. So we fetch the
> - filesystem information again, but with a NULL handle.
> - This does what we want because fs_info::update opens the
> - handle without FILE_OPEN_REPARSE_POINT. */
> - if (res == -1
On Jun 13 15:01, Yaakov Selkowitz wrote:
> This should match newlib's .
>
> Signed-off-by: Yaakov Selkowitz
> ---
> winsup/cygwin/include/cygwin/signal.h | 26 +-
> 1 file changed, 25 insertions(+), 1 deletion(-)
ACK
Thanks,
Corinn
e name.
Pushed. Can you please send patches in `git format-patch' format? Those
are nicer to apply.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
rsion.h | 3 ++-
> winsup/cygwin/signal.cc| 12
> winsup/doc/posix.xml | 10 --
> 5 files changed, 36 insertions(+), 4 deletions(-)
ACK, looks good. Please add this to the cygwin release notes file, too
(in a 2nd commit).
Thanks,
Cor
nteed to be set
> correctly in the loop, so better to just remove it and call
> WSAGetLastError() explicitly.
> ---
> winsup/cygwin/fhandler_socket.cc | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
Pushed.
Thanks,
Corinna
--
Corinna Vinschen
seinsensitive (),
> get_handle (), NULL);
> - de->d_type = readdir_check_reparse_point (&oattr);
> + /* FUTURE: Ideally would know at this point if reparse point
> + is stored on a remote volume. Without this, may return
On Jun 19 11:47, Joe Lowe wrote:
>
> On 2017-06-19 04:45, Corinna Vinschen wrote:> Hi Joe,
> >
> > As discussed in the previous iteration of this patch, this change
> > results in nuking DT_UNKNOWN for reparse points we don't handle. Still,
> > IMHO, if
On Jun 21 10:54, Joe Lowe wrote:
>
>
> On 2017-06-20 01:17, Corinna Vinschen wrote:
> > Actually, DT_UNKNOWN indicates nothing. The sole purpose of this
> > value is to tell the application that the information is not readily
> > available without having to perfo
On Jun 21 19:36, Jon Turney wrote:
> Signed-off-by: Jon Turney
> ---
> winsup/doc/faq-setup.xml | 62
> +---
> 1 file changed, 38 insertions(+), 24 deletions(-)
This one, too. Please apply.
Thanks,
Corinna
--
C
Alternatively, you can manually enter proxy
> +settings into the Use HTTP/FTP Proxy section.
>
>
>
> --
> 2.12.3
ACK
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
nclude/string.h | 18 +-
> winsup/cygwin/include/sys/wait.h | 2 +-
> 2 files changed, 10 insertions(+), 10 deletions(-)
Pushed.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
signature.asc
Description: PGP signature
*/
>};
> } siginfo_t;
> +
> #pragma pack(pop)
>
> #endif /* __POSIX_VISIBLE >= 199309 */
> --
> 2.12.3
ACK, please push.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
ght
mailing list so all affected parties can chime in. Hint: strtoimax is
not available on all platforms yet (patches still in limbo)...
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
/posix.xml
> @@ -1139,6 +1139,7 @@ also IEEE Std 1003.1-2008 (POSIX.1-2008).
> endusershell
> err
> errx
> +explicit_bzero
> feof_unlocked
> ferror_unlocked
> fflush_unlocked
> --
> 2.13.2
Yep, please push (and update releas
On Aug 2 01:21, Yaakov Selkowitz wrote:
> This is copied from musl (MIT license). This is newer and more thorough
> than that of FreeBSD currently shipped only on Cygwin.
Please push.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
y should have sent this to the Newlib
> list.
thanks for the patch, but you should really send it to the newlib list,
especially given that not only Cygwin is affected.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer
move-to-bin strategy is broken and maybe even
> unfounded. I don't know why cygwin is trying to move an empty
> directory to a recycle.bin folder. The inherent race condition seems
> avoidable to me. Is there a discussion regarding that behaviour?
$ mkdir dir
$ cd dir
$ rmdir .
ething like
pfri->ReplaceIfExists = !(flags & RENAME_NOREPLACE);
it should give us the atomic behaviour of renameat2 on Linux.
Another upside is, the status code returned is STATUS_OBJECT_NAME_COLLISION,
which translates to Win32 error ERROR_ALREADY_EXISTS, which in turn is
already converted to EEXIST by Cygwin, so there's nothing more to do :)
What do you think?
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
Hi Ken,
On Aug 18 18:24, Ken Brown wrote:
> Hi Corinna,
>
> On 8/18/2017 11:15 AM, Corinna Vinschen wrote:
> > On Aug 18 09:21, Ken Brown wrote:
> > But there's light. NtSetInformationFile(FileRenameInformation) already
> > supports RENAME_NOREPLACE :)
> >
On Aug 19 10:29, Ken Brown wrote:
> Hi Corinna,
>
> On 8/19/2017 5:57 AM, Corinna Vinschen wrote:
> > Hi Ken,
> >
> > On Aug 18 18:24, Ken Brown wrote:
> > The patch is ok as is, just let me know what you think of the above
> > minor tweak (and send the r
On Aug 19 18:28, Corinna Vinschen wrote:
> On Aug 19 10:29, Ken Brown wrote:
> > Hi Corinna,
> >
> > On 8/19/2017 5:57 AM, Corinna Vinschen wrote:
> > > Hi Ken,
> > >
> > > On Aug 18 18:24, Ken Brown wrote:
> > > The patch is ok as is,
On Aug 19 13:13, Ken Brown wrote:
> On 8/19/2017 12:37 PM, Corinna Vinschen wrote:
> > Oh, one more thing. This is a question to Yaakov, too.
> >
> > diff --git a/newlib/libc/include/stdio.h b/newlib/libc/include/stdio.h
> > index 5d8cb1092..331a1cf07 100644
> >
On Aug 19 13:24, Ken Brown wrote:
> On 8/19/2017 12:28 PM, Corinna Vinschen wrote:
> > Doc changes coming? :)
>
> Attached.
Pushed. I also generated new developer snapshots.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cy
l this temp variable
"save_errno" :)
Alternatively, since you're in C++ code, you can use the save_errno
class, like this:
{
save_errno save;
[do your thing]
}
The destructor of save_errno will restore errno.
Since the code as such is fine, it's your cho
e
> the
> test to:
>
> if (tmp && width && (uint) (tmp - (char *) bp) > width)
>
> but this does not properly support [+0] flags or width in the format as
> specified by glibc (latest POSIX punts on %F) for compatibility with
> strftime(),
> af
On Aug 24 11:32, Corinna Vinschen wrote:
> On Aug 23 13:25, Brian Inglis wrote:
> > Cygwin strptime(3) (also strptime(1)) fails with default width, without an
> > explicit width, because of the test in the following code:
> >
> > case
On Aug 24 14:00, Brian Inglis wrote:
> On 2017-08-24 03:25, Corinna Vinschen wrote:
> > On Aug 23 12:51, Brian Inglis wrote:
> >> Attached patch to support %s in Cygwin winsup libc strptime.cc
> >> __strptime().
> >> This also enables support for %s in dateuti
On Aug 24 11:11, Brian Inglis wrote:
> On 2017-08-24 03:40, Corinna Vinschen wrote:
> > On Aug 24 11:32, Corinna Vinschen wrote:
> >> On Aug 23 13:25, Brian Inglis wrote:
> >>> Cygwin strptime(3) (also strptime(1)) fails with default width, without an
> >>&
On Aug 29 11:56, Brian Inglis wrote:
> On 2017-08-29 01:35, Corinna Vinschen wrote:
> > On Aug 25 11:47, Corinna Vinschen wrote:
> >> On Aug 24 11:11, Brian Inglis wrote:
> >>> On 2017-08-24 03:40, Corinna Vinschen wrote:
> >>>> On Aug 24 11:32, Co
On Aug 29 18:09, Brian Inglis wrote:
> On 2017-08-29 13:14, Corinna Vinschen wrote:
> > On Aug 29 11:56, Brian Inglis wrote:
> >> got diverted during strptime testing due to time functions gmtime,
> >> localtime, mktime, strftime not properly handling struct
> >
tation Notes")
> dremf
> dup3
> --
> 2.14.1
Sure, go ahead. You can apply stuff like that without waiting for
my consent, Yaakov, no worries here.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer
tly from Cygwin by using
> +chown. Please note that you shouldn't use the
> +recursive form of chown on directories that have other file systems
> +mounted under them (specifically you must avoid
> +/proc) since you'd change ownership of the files under
> those
> +mount
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
; 1 file changed, 24 insertions(+), 2 deletions(-)
Series ACK.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
E_FUNCTION f;
>ULONG64 imagebase;
> - UNWIND_HISTORY_TABLE hist;
> + UNWIND_HISTORY_TABLE hist = {0};
>DWORD64 establisher;
>PVOID hdl;
>
> --
> 2.14.2
>
Pushed.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
sys_wcstombs (buf, 4, &wc, 1);
> + char buf[MB_LEN_MAX+1] = "", *c;
> + sys_wcstombs (buf, MB_LEN_MAX+1, &wc, 1);
> for (c = buf; *c; ++c)
> *dst++ = *c;
> }
> -
no %d",
grouped.child_pid,
grouped.errmsg ? "- " : "",
grouped.errmsg ?: "",
grouped.this_errno);
What do you think?
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
On Oct 10 14:26, Michael Haubenwallner wrote:
> On 10/10/2017 01:48 PM, Corinna Vinschen wrote:
> > Hi Michael,
> >
> > On Oct 9 18:58, Michael Haubenwallner wrote:
> >> When fork fails, we can use "%s" now with system_sprintf for the errmsg
> >>
On Oct 10 14:44, Corinna Vinschen wrote:
> On Oct 10 14:26, Michael Haubenwallner wrote:
> > But wait, what's the difference between syscall_printf and system_printf?
>
> Prefixing with timestamps and stuff.
No, wait. I mixed that up with small_printf. syscall_printf is
;m not sure how much we care, but maybe we shoulkd fix the test to
ignore the colon only if it's the second character in the incoming
string?
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
On Oct 25 14:11, Corinna Vinschen wrote:
> Hi Ken,
>
> On Oct 25 07:23, Ken Brown wrote:
> > Up to now the function winsup/utils/dump_setup.cc:base skips past
> > colons when parsing file names. As a result, a line like
> >
> > foo foo-1:2.3-4.tar.bz2 1
&g
On Oct 25 09:38, Ken Brown wrote:
> On 10/25/2017 8:19 AM, Corinna Vinschen wrote:
> > On Oct 25 14:11, Corinna Vinschen wrote:
> > > Hi Ken,
> > >
> > > On Oct 25 07:23, Ken Brown wrote:
> > > > Up to now the function winsup/utils/dump_setup.cc:
On Oct 25 10:56, Ken Brown wrote:
> On 10/25/2017 10:19 AM, Corinna Vinschen wrote:
> > On Oct 25 09:38, Ken Brown wrote:
> > > On 10/25/2017 8:19 AM, Corinna Vinschen wrote:
> > > > On Oct 25 14:11, Corinna Vinschen wrote:
> > > > > Hi Ken,
> >
index caa3a77..d0d735b 100644
> --- a/winsup/cygwin/syscalls.cc
> +++ b/winsup/cygwin/syscalls.cc
> @@ -2937,7 +2937,7 @@ posix_fadvise (int fd, off_t offset, off_t len, int
> advice)
>if (cfd >= 0)
> res = cfd->fadvise (offset, len, advice);
>else
> -
h go away like you did in posix_fallocate?
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
On Nov 2 15:58, Corinna Vinschen wrote:
> Hi Eric,
s/Eric/Erik/
Sorry,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
On Nov 2 16:45, Erik M. Bray wrote:
> Also updates the fhandler_*::fadvise implementations to adhere to the same
> semantics.
Both patches pushed.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT
on_atomic; status = NtReadFile (prw_handle, NULL, NULL,
> NULL, &io, buf, count,
your mailer screwed up the patch and so it can't apply. Can you please
send it as an attachment?
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
ith a nice log message and call
git format-patch -1
Then send the generated patch file called 0001-something.patch with
git send-email --to="cygwin-patches@cygwin.com" 0001-*
That should work.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regardi
pc.dev == FH_UDP || pc.dev == FH_DGRAM)
> wsock_events->events = FD_WRITE;
> --
> 2.8.3
Pushed. I just changed
#define NUM_SOCKS ((unsigned int) 2048)
to
#define NUM_SOCKS 2048U
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
Erik,
On Nov 7 16:11, Corinna Vinschen wrote:
> On Nov 7 14:44, Erik M. Bray wrote:
> > * Fix the maximum number of sockets allowed in the session to 2048,
> > instead of making it relative to sizeof(wsa_event).
> >
> > The original choice of 2048 was in order
ease have a look at
https://sourceware.org/git/?p=newlib-cygwin.git;a=commitdiff;h=46702f92ea49
I retained your authorship, of course.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
On Nov 8 13:34, Corinna Vinschen wrote:
> On Nov 7 17:33, Xiaofeng Liu via cygwin-patches wrote:
> > --- winsup/cygwin/fhandler_disk_file.cc | 1 + 1 files changed, 1
> > insertions(+), 0 deletions(-)
> > diff --git a/winsup/cygwin/fhandler_disk_file.cc
27;t know what you're using there
but your mails are next to unreadable, missing line breaks, missing
spaces. Check the archives to see what I mean:
https://cygwin.com/ml/cygwin-patches/2017-q4/
Also, please don't top-post.
> On Wednesday, November 8, 2017, 4:41:22 AM PST, Corinna Vins
think is a company (cygwin.com) they have never heard of,
> who they expect from their application message to take care of their problem
> with no other effort on their part, and who they can blame if nothing happens.
>
> Assuming they find the FAQ entry, emphatic language may pers
Cygwin release: whether it was purchased from
> + a vendor or a project downloaded from the Internet, any related web
> + pages, or other details you may have readily available.
Do we really want all this information? It should be sufficient to know
the name of the project, so it&#x
On Nov 14 13:52, Brian Inglis wrote:
> On 2017-11-14 02:29, Corinna Vinschen wrote:
> > On Nov 13 11:51, Brian Inglis wrote:
> >> On 2017-11-13 10:12, Brian Inglis wrote:
> > Please send this as `git format-patch' with commit message and all.
>
> One more dif
On Nov 14 23:01, Brian Inglis wrote:
> >From 61fe6f174a840cffdac4ae8772e1a10a68e80beb Mon Sep 17 00:00:00 2001
> From: Brian Inglis
> Date: Tue, 14 Nov 2017 22:57:02 -0700
> Subject: [PATCH] add FAQ How do I fix find_fast_cwd warnings
Pushed.
Thanks,
Corinna
--
C
Not all non-0
status codes fail the !NT_SUCCESS (status) test.
- Do you have a simple, self-contained testcase?
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
On Nov 27 22:10, Yaakov Selkowitz wrote:
> http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/limits.h.html
> https://sourceware.org/ml/newlib/2017/msg01133.html
>
> Signed-off-by: Yaakov Selkowitz
> ---
ACK, please push.
Thanks,
Corinna
--
Corinna Vinschen
On Nov 28 02:28, Mark Geisert wrote:
> Corinna Vinschen wrote:
> > On Nov 28 00:03, Mark Geisert wrote:
> > > Mark Geisert wrote:
> > > > ---
> > > > winsup/cygwin/fhandler_disk_file.cc | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 de
OSIX_TIMEOUTS}}, /* 82, _SC_TIMEOUTS */
>{cons, {c:-1L}}, /* 83, _SC_TRACE */
>{cons, {c:-1L}}, /* 84, _SC_TRACE_EVENT_FILTER */
>{nsup, {c:0}}, /* 85, _SC_TRACE_EVENT_NAME_MAX */
> --
> 2.15.0
ACK
Thanks,
Co
On Nov 29 02:25, Mark Geisert wrote:
> Corinna Vinschen wrote:
> > On Nov 28 02:28, Mark Geisert wrote:
> > > Corinna Vinschen wrote:
> > > > On Nov 28 00:03, Mark Geisert wrote:
> > > > > Oops, I neglected to include an explanatory comment. Issuing
t; It's like "How about that?" or "Can you believe it?". Perhaps y'all know
> this idiom already but it was only while contemplating a cerveza that I
> realized it might have come across badly.
Nope, no worries.
Corinna
--
Corinna Vinschen
On Nov 29 13:04, Corinna Vinschen wrote:
> - If you do async IO, you have to handle STATUS_PENDING gracefully:
>
> - The IO_STATUS_BLOCK given to NtWriteFile *must* exist for the
> entire time the operation takes after NtWriteFile returned
> STATUS_PENDING. An IO_STATUS
On Nov 29 13:36, Corinna Vinschen wrote:
> On Nov 29 13:04, Corinna Vinschen wrote:
> > - If you do async IO, you have to handle STATUS_PENDING gracefully:
> >
> > - The IO_STATUS_BLOCK given to NtWriteFile *must* exist for the
> > entire time the operation takes
> --- a/winsup/cygwin/include/sys/poll.h
> +++ b/winsup/cygwin/include/sys/poll.h
> @@ -47,4 +47,8 @@ extern int ppoll __P ((struct pollfd *fds, nfds_t nfds,
>
> __END_DECLS
>
> +#if __SSP_FORTIFY_LEVEL > 0
> +#include
> +#endif
> +
> #endif /* _
74300f 100644
> --- a/winsup/doc/posix.xml
> +++ b/winsup/doc/posix.xml
> @@ -1396,6 +1396,7 @@ also IEEE Std 1003.1-2008 (POSIX.1-2008).
> wcstoll_l
> wcstoul_l
> wcstoull_l
> +wmempcpy
>
>
>
> --
> 2.15.0
Basically ok, but shouldn'
On Nov 30 10:27, Corinna Vinschen wrote:
> On Nov 29 19:48, Yaakov Selkowitz wrote:
> > Signed-off-by: Yaakov Selkowitz
> > ---
> > Obviously this depends on the newlib implementation patch.
> >
> > winsup/cygwin/common.din | 1 +
> > win
On Nov 30 01:50, Mark Geisert wrote:
> On Wed, 29 Nov 2017, Corinna Vinschen wrote:
> > On Nov 29 13:36, Corinna Vinschen wrote:
> > > On Nov 29 13:04, Corinna Vinschen wrote:
> > > > - If you do async IO, you have to handle STATUS_PENDING gracefully:
> > > &
On Dec 1 00:44, Mark Geisert wrote:
> On Thu, 30 Nov 2017, Corinna Vinschen wrote:
> > On Nov 30 01:50, Mark Geisert wrote:
> > > Yes, I believe that's correct. But in my aio implementation for Cygwin,
> > > I'm
> > > not using overlapped I/O
On Dec 1 10:30, Corinna Vinschen wrote:
> On Dec 1 00:44, Mark Geisert wrote:
> > [...]
> > I'd better take this info back to "the lab" and do some more digging. Thanks
> > very much for these details and your earlier replies. When I saw
> > FIL
On Dec 1 13:46, Mark Geisert wrote:
> On Fri, 1 Dec 2017, Corinna Vinschen wrote:
> > On Dec 1 10:30, Corinna Vinschen wrote:
> > > In terms of pread/pwrite, the new handle shares the same settings with
> > > the original handle. However, if you use cygwin_attach_ha
On Dec 7 12:16, Jon Turney wrote:
> Signed-off-by: Jon Turney
> ---
> winsup/doc/faq-programming.xml | 37 -
> 1 file changed, 36 insertions(+), 1 deletion(-)
Sounds good. ACK.
Thanks,
Corinna
--
Corinna Vinschen Please
sion is accepted).
>
> You could cherry pick my patch against res.rc as a start to tweak your layouts
> and tests.
Doesn't this thread belong to cygwin-apps?
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
the handling of WAIT_TIMEOUT. In this case,
the default case currently tries to set errno, but no error actually
occured in cygwait, just a timeout. However, WAIT_TIMEOUT should
explicitely set errno to EAGAIN.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regar
On 15 December 2017 02:09:42 GMT+01:00, Mark Geisert wrote:
>On Thu, 14 Dec 2017, Corinna Vinschen wrote:
>> Hi Mark,
>>
>> Thanks for sigtimedwait! Two questions:
>>
>> On Dec 13 22:54, Mark Geisert wrote:
>>> diff --git a/winsup/cygwin/signal.cc b/w
nse agreement from you per the "Before you get started"
section on https://cygwin.com/contrib.html
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
On Dec 18 01:34, Mark Geisert wrote:
> On Mon, 18 Dec 2017, Corinna Vinschen wrote:
> > Hi Mark,
> [...]
> > as I wrote on Friday, the patch looks good to me. I just need a
> > contributors license agreement from you per the "Before you get started"
> > se
On Dec 18 11:07, Yaakov Selkowitz wrote:
> On 2017-12-18 04:48, Corinna Vinschen wrote:
> > On Dec 18 01:34, Mark Geisert wrote:
> >> On Mon, 18 Dec 2017, Corinna Vinschen wrote:
> >>> Hi Mark,
> >> [...]
> >>> as I wrote on Friday, the patch
ne function.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
will be a kludge. There are
scenarios in which more than one handle is attached to a descriptor
(e.g., ptys) and the function will return only one.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
ften overdo the quotes: originally
> had both uses quoted, then seeing the diff, took them off again, pre-commit.
> Those are base Cygwin paths - don't *need* quotes - unless you feel shell var
> uses should be quoted just in case, or just in tests?
Eric is right. You can't really
On Dec 21 00:29, Mark Geisert wrote:
> On Wed, 20 Dec 2017, Corinna Vinschen wrote:
> > Hi Mark,
> >
> > A lot to discuss here.
>
> Yes, but first let me say I'd call these "speculative" patches, things I
> found necessary during aio library develop
me() be the only part
> of cygthread which knows about pthreads...
>
> Other uses of cygthread::name() need inspecting to see if they need to
> change or not. Given [1], I think CW_GETTHREADNAME should stay as it is.
>
> [1] https://cygwin.com/ml/cygwin/2009-05/msg00263.html
Full
On Dec 22 11:35, Brian Inglis wrote:
> ---
> winsup/doc/etc.postinstall.cygwin-doc.sh | 10 +-
> winsup/doc/etc.preremove.cygwin-doc.sh | 5 +++--
> 2 files changed, 8 insertions(+), 7 deletions(-)
Pushed.
Thanks,
Corinna
--
Corinna Vinschen Please
+#define _CS_LFS_LDFLAGS 22
> +#define _CS_LFS_LIBS 23
> +#define _CS_LFS_LINTFLAGS 24
Basically ok, but while at it, wouldn't it make sense to add the LFS64
macros too?
Thanks,
Corinna
--
Corinna Vinschen
etails. */
>
> #include
> #include
> -#include
You don't explain the incentive behind removing sys/time.h. Sure this
doesn't break anything?
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
Description: PGP signature
On Jan 16 09:03, Yaakov Selkowitz wrote:
> On 2018-01-16 03:27, Corinna Vinschen wrote:
> > On Jan 15 21:19, Yaakov Selkowitz wrote:
> >> These are used, for instance, when cross-compiling the Linux kernel.
> >>
> >> Signed-off-by: Yaakov Selkowitz
> >&g
> winsup/cygwin/include/asm/types.h | 2 ++
> 3 files changed, 34 insertions(+)
> create mode 100644 winsup/cygwin/include/asm/bitsperlong.h
> create mode 100644 winsup/cygwin/include/asm/posix_types.h
ACK
Thanks,
Corinna
--
Corinna Vinschen Please,
On Jan 19 01:28, Yaakov Selkowitz wrote:
> On 2018-01-16 03:30, Corinna Vinschen wrote:
> > You don't explain the incentive behind removing sys/time.h.
>
> POSIX does not mention the inclusion of in
> or , nor is there anything in the latter two that would
> requi
to link with -lcatgets.
Do you want this in 2.10? Otherwise I'd wait with adding new features
until after the release.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
signature.asc
lines add whitespace errors.
Applying: cygwin: update docs for 2.10.0
.git/rebase-apply/patch:21: trailing whitespace.
- Built-in implementation of _FORTIFY_SOURCE guards for functions in
.git/rebase-apply/patch:74: trailing whitespace.
Built-in implementation of _FORTIFY_SOURCE guards f
);
> int pthread_rwlock_trywrlock (pthread_rwlock_t *rwlock);
> int pthread_rwlock_unlock (pthread_rwlock_t *rwlock);
> int pthread_rwlockattr_init (pthread_rwlockattr_t *rwlockattr);
> --
> 2.15.1
Ouch, thanks for catching. ACK.
Thanks,
Corinna
--
Corinna Vinschen
On Jan 22 09:50, Corinna Vinschen wrote:
> On Jan 21 23:51, Yaakov Selkowitz wrote:
> > These were added in commit 8128f5482f2b1889e2336488e9d45a33c9972d11 but
> > without their public declarations.
> >
> > Signed-off-by: Yaakov Selkowitz
> > ---
> &g
> diff --git a/winsup/cygwin/thread.h b/winsup/cygwin/thread.h
> index 12a9ef26d..60277c601 100644
> --- a/winsup/cygwin/thread.h
> +++ b/winsup/cygwin/thread.h
> @@ -17,6 +17,9 @@ details. */
> /* resource.cc */
> extern size_t get_rlimit_stack (void);
>
> +/* thread.cc
On Jan 24 00:34, Mark Geisert wrote:
> This new function returns the name of the calling thread; works for both
> cygthreads and pthreads. All calls to cygthread::name(/*void*/) replaced
> by calls to mythreadname(/*void*/).
Pushed.
Thanks,
Corinna
--
Corinna
On Feb 2 16:10, Yaakov Selkowitz wrote:
> On 2018-01-19 13:26, Yaakov Selkowitz wrote:
> > On 2018-01-19 13:04, Corinna Vinschen wrote:
> >> Are you going to provide a catgets deprecation package?
> >
> > Yes.
> Done.
Thanks!
Corinna
--
Corinna Vinschen
e patch is malformed. It claims to contain 7 lines (6 lines context,
one line changed), but actually it has only 4 lines context. Please
check your git settings.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer
On Feb 21 14:20, Brian Inglis wrote:
> On 2018-02-21 14:05, Corinna Vinschen wrote:
> > Hi David,
> >
> > On Feb 21 18:09, David Macek wrote:
> >> ---
> >> winsup/doc/ntsec.xml | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
601 - 700 of 2885 matches
Mail list logo
