Re: [PATCH v4 0/5] find_fast_cwd_pointer rewrite

2025-04-02 Thread Jeremy Drake via Cygwin-patches
On Wed, 2 Apr 2025, Corinna Vinschen wrote: > On Apr 1 22:25, Jeremy Drake via Cygwin-patches wrote: > > I changed the code to use the struct directly, and amazingly the dll was > > the exact same size after stripping. I then tried building the udis86/*.c > > with -ffunction-sections -fdata-sect

Re: [PATCH v4 0/5] find_fast_cwd_pointer rewrite

2025-04-02 Thread Corinna Vinschen
On Apr 1 10:25, Jeremy Drake via Cygwin-patches wrote: > On Tue, 1 Apr 2025, Corinna Vinschen wrote: > > > Oh, Jeremy, here's a question. We only add udis86 to the main branch. > > What about the 3.6 branch, does it still need a patch to accommodate > > the fast_cwd magic for a newer, upcoming W

[PATCH] Cygwin: Fix compatibility with GCC 15

2025-04-02 Thread Thirumalai Nagalingam
Hello, Please find my patch attached for review. Summary of Changes: - GCC 15 defaults to `-std=gnu23`, causing build failures in `test suite` due to outdated C function declarations. - This patch updates sbrk01.c and symlink01.c for GCC 15 compatibility. - These changes were not included in m

Re: [PATCH v4 0/5] find_fast_cwd_pointer rewrite

2025-04-02 Thread Corinna Vinschen
On Apr 1 22:25, Jeremy Drake via Cygwin-patches wrote: > On Tue, 1 Apr 2025, Jeremy Drake via Cygwin-patches wrote: > > > On Tue, 1 Apr 2025, Corinna Vinschen wrote: > > > > > And btw., I checked the file size again, and it turns out that after > > > stripping the debug symbols the DLL takes ~30

[PATCH] Cygwin: handle GetProcAddress returning NULL in GetArm64ProcAddress.

2025-04-02 Thread Jeremy Drake via Cygwin-patches
This was an oversight, the caller of GetArm64ProcAddress does check for a NULL return, but it would have crashed in the memcmp before getting there. Fixes: 2c5f25035d9f ("Cygwin: add find_fast_cwd_pointer_aarch64.") Signed-off-by: Jeremy Drake --- winsup/cygwin/aarch64/fastcwd.cc | 4 ++-- 1 fil

Re: [PATCH] Cygwin: handle GetProcAddress returning NULL in GetArm64ProcAddress.

2025-04-02 Thread Corinna Vinschen
On Apr 2 13:01, Jeremy Drake via Cygwin-patches wrote: > This was an oversight, the caller of GetArm64ProcAddress does check for > a NULL return, but it would have crashed in the memcmp before getting > there. > > Fixes: 2c5f25035d9f ("Cygwin: add find_fast_cwd_pointer_aarch64.") > Signed-off-by: