Re: [PATCH v4 0/5] find_fast_cwd_pointer rewrite

2025-03-31 Thread Corinna Vinschen
Hi Mark, On Mar 31 23:41, Mark Wielaard via Overseers wrote: > Hi Corinna, Hi Jeremy, > > On Mon, Mar 31, 2025 at 11:06:24PM +0200, Corinna Vinschen via Overseers > wrote: > > On Mar 31 13:58, Jeremy Drake via Cygwin-patches wrote: > > > On Mon, 31 Mar 2025, Corinna Vinschen wrote: > > > > Thank

Re: [PATCH v4 0/5] find_fast_cwd_pointer rewrite

2025-03-31 Thread Corinna Vinschen
Hi Jeremy, On Mar 31 10:19, Corinna Vinschen wrote: > Jeremy, I don't think you have push perms to the Cygwin repo. > > If you want to push your own patches and are willing to review patches > on this list occassionally (especially when I'm on one of my longish > vacations), see the handy dandy l

Re: [PATCH v4 0/5] find_fast_cwd_pointer rewrite

2025-03-31 Thread Jeremy Drake via Cygwin-patches
On Mon, 31 Mar 2025, Corinna Vinschen wrote: > Hi Jeremy, > > Thank you, I approved your request on sware. You now have > write-after-approval permissions, so please continue to send patches to > cygwin-patches first and wait for approval from Takashi, Jon or me. I tried to push this patchset bu

Re: [PATCH v4 0/5] find_fast_cwd_pointer rewrite

2025-03-31 Thread Corinna Vinschen
On Mar 31 13:58, Jeremy Drake via Cygwin-patches wrote: > On Mon, 31 Mar 2025, Corinna Vinschen wrote: > > > Hi Jeremy, > > > > Thank you, I approved your request on sware. You now have > > write-after-approval permissions, so please continue to send patches to > > cygwin-patches first and wait f

Re: [PATCH v4 0/5] find_fast_cwd_pointer rewrite

2025-03-31 Thread Jeremy Drake via Cygwin-patches
On Mon, 31 Mar 2025, Corinna Vinschen wrote: > On Mar 31 13:58, Jeremy Drake via Cygwin-patches wrote: > > On Mon, 31 Mar 2025, Corinna Vinschen wrote: > > > > > Hi Jeremy, > > > > > > Thank you, I approved your request on sware. You now have > > > write-after-approval permissions, so please cont

[PATCH] Cygwin: pipe: Add workaround for native ninja

2025-03-31 Thread Takashi Yano
Native (non-cygwin) ninja creates pipe with size == 0, and starts cygwin process with that pipe. This causes infinite loop in the fhandler_fifo_pipe::raw_write(). Ideally, the pipe implementation in cygwin could work even with pipe size == 0, however, it seems impossible due to: (1) select() does

Re: [PATCH] Cygwin: dlfcn: fix ENOENT in dlclose

2025-03-31 Thread Corinna Vinschen
On Mar 31 13:06, Corinna Vinschen wrote: > On Mar 31 17:18, Yuyi Wang wrote: > > > I tested this scenario, and this problem only occurs with > > > dlopening cygwin1.dll. > > > > Not only cygwin1.dll, but also native dlls, e.g., kernel32.dll or > > user32.dll. > > I haven't tested the next release

[PATCH] Cygwin: pty: Return EMFILE when too meny ptmx are opened

2025-03-31 Thread Takashi Yano
Previously, opening /dev/ptmx fails without setting errno when it is opened too many times. With this patch, return EMFILE in that situation. Addresses: https://cygwin.com/pipermail/cygwin/2025-March/257786.html Fixes: 09738c30627c ("Cygwin: pty: setup new pty on opening the master, not in constr

Re: [PATCH] Cygwin: pipe: Add workaround for native ninja

2025-03-31 Thread Corinna Vinschen
Hi Takashi, On Mar 31 22:27, Takashi Yano wrote: > Native (non-cygwin) ninja creates pipe with size == 0, and starts > cygwin process with that pipe. This causes infinite loop in the > fhandler_fifo_pipe::raw_write(). Ideally, the pipe implementation > in cygwin could work even with pipe size == 0

Re: [PATCH v4 0/5] find_fast_cwd_pointer rewrite

2025-03-31 Thread Corinna Vinschen
On Mar 30 19:45, Jeremy Drake via Cygwin-patches wrote: > On Sat, 29 Mar 2025, Jeremy Drake via Cygwin-patches wrote: > > > ++#if defined (__i386__) > > + static const BYTE thunk[] = "\x8b\xff\x55\x8b\xec\x5d\x90\xe9"; > > -+#elif defined(__x86_64__) > > ++ static const BYTE thu

Re: [PATCH] Cygwin: dlfcn: fix ENOENT in dlclose

2025-03-31 Thread Yuyi Wang
> I tested this scenario, and this problem only occurs with > dlopening cygwin1.dll. Not only cygwin1.dll, but also native dlls, e.g., kernel32.dll or user32.dll. I haven't tested the next release, but do you think it's the same reason for win32 dlls?

Re: [PATCH] Cygwin: dlfcn: fix ENOENT in dlclose

2025-03-31 Thread Corinna Vinschen
On Mar 31 15:46, Corinna Vinschen wrote: > On Mar 31 13:06, Corinna Vinschen wrote: > > On Mar 31 17:18, Yuyi Wang wrote: > > > > I tested this scenario, and this problem only occurs with > > > > dlopening cygwin1.dll. > > > > > > Not only cygwin1.dll, but also native dlls, e.g., kernel32.dll or

Re: [PATCH] Cygwin: dlfcn: fix ENOENT in dlclose

2025-03-31 Thread Corinna Vinschen
On Mar 31 17:18, Yuyi Wang wrote: > > I tested this scenario, and this problem only occurs with > > dlopening cygwin1.dll. > > Not only cygwin1.dll, but also native dlls, e.g., kernel32.dll or user32.dll. > I haven't tested the next release, but do you think it's the same reason for > win32 dlls?