[PATCH 1/2] CI: Remove inheritable permissions from working directory

2025-03-21 Thread Jon Turney
Remove inheritable permissions from the working directory, since they break assumptions that the testsuite makes about the filemode a given umask will result in. --- .github/workflows/cygwin.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/cygwin.yml b/.github/workflows

[PATCH 2/2] Revert "Cygwin: CI: XFAIL umask03"

2025-03-21 Thread Jon Turney
This reverts commit cbe7543cdfdb7f3d270214877d4a4c3e78710bd3. --- winsup/testsuite/Makefile.am | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/winsup/testsuite/Makefile.am b/winsup/testsuite/Makefile.am index 228955668..8f2967a6d 100644 --- a/winsup/testsuite/Makefile.am +

Re: Use udis86 to walk x64 machine code in find_fast_cwd_pointer

2025-03-21 Thread Corinna Vinschen
On Mar 20 13:01, Jeremy Drake via Cygwin-patches wrote: > On Thu, 20 Mar 2025, Corinna Vinschen wrote: > > > On Mar 20 15:03, Corinna Vinschen wrote: > > > On Mar 18 22:11, Jeremy Drake via Cygwin-patches wrote: > > > > On Tue, 18 Mar 2025, Corinna Vinschen wrote: > > > > > > > > > Subdir of winsu

[PATCH 0/2] Fix CI testsuite run with 3.6

2025-03-21 Thread Jon Turney
I think there's been some changes in the way we compute the ACL for files we create, which is causing a couple of tests to fail in CI. Get rid of inheritable permissions, so filemodes follow the simple behaviour (just controlled by umask) that tests expect. (It seems like there must be something

[PATCH 0/4] find_fast_cwd_pointer rewrite

2025-03-21 Thread Jeremy Drake via Cygwin-patches
The second patch of this series might be a little difficult to deal with, but I included a diff of the changes from the upstream udis86-1.7.2 tarball (retrieved from https://downloads.sourceforge.net/udis86/udis86-1.7.2.tar.gz), and I'm copying it again here. diff -ur udis86-1.7.2/libudis86/decode

[PATCH 1/4] Cygwin: factor out find_fast_cwd_pointer to arch-specific file

2025-03-21 Thread Jeremy Drake via Cygwin-patches
From: Jeremy Drake This is in preparation for rewriting it using udis86, and adding an implementation for aarch64 hosts. Signed-off-by: Jeremy Drake --- winsup/cygwin/Makefile.am | 1 + winsup/cygwin/path.cc | 122 +-- winsup/cygwin/x86_64/fa

[PATCH 3/4] Cygwin: use udis86 to find fast cwd pointer on x64

2025-03-21 Thread Jeremy Drake via Cygwin-patches
From: Jeremy Drake This makes find_fast_cwd_pointer more resiliant in the face of changes to the generated code in ntdll. Signed-off-by: Jeremy Drake --- winsup/cygwin/x86_64/fastcwd_x86_64.cc | 191 ++--- 1 file changed, 111 insertions(+), 80 deletions(-) diff --git a/win

[PATCH 4/4] Cygwin: add find_fast_cwd_pointer_aarch64.

2025-03-21 Thread Jeremy Drake via Cygwin-patches
From: Jeremy Drake This works for aarch64 hosts when the target is aarch64, x86_64, or i686, with only a small #if block in one function that needs to care. Signed-off-by: Jeremy Drake --- winsup/cygwin/Makefile.am| 1 + winsup/cygwin/fastcwd_aarch64.cc | 185