Re: [PATCH] Cygwin: sched_setaffinity: fix EACCES if pid of other process is used

2025-03-10 Thread Christian Franke
Corinna Vinschen wrote: On Mar 8 14:24, Christian Franke wrote: This fixes: $ taskset -p 0x1 1234 pid 1234's current affinity mask: fff taskset: failed to set pid 1234's affinity: Permission denied Perhaps older Windows versions were more relaxed if PROCESS_SET_INFORMATION is granted. --

[PATCH] fix native symlink spawn passing wrong arg0

2025-03-10 Thread Chris Denton
This upstreams the msys2 patch: https://github.com/msys2/MSYS2-packages/blob/6a02000fd93c6b2001220507e5369a726b6381c4/msys2-runtime/0021-Fix-native-symbolic-link-spawn-passing-wrong-arg0.patch Original msys2 issue: https://github.com/msys2/MSYS2-packages/issues/1327 --- winsup/cygwin/spawn.cc | 2

Re: [PATCH] fix native symlink spawn passing wrong arg0

2025-03-10 Thread Corinna Vinschen
Hi Chris, On Mar 10 15:46, Chris Denton wrote: > This upstreams the msys2 patch: > https://github.com/msys2/MSYS2-packages/blob/6a02000fd93c6b2001220507e5369a726b6381c4/msys2-runtime/0021-Fix-native-symbolic-link-spawn-passing-wrong-arg0.patch > > Original msys2 issue: > https://github.com/msys2/

Re: [PATCH] Cygwin: sched_setaffinity: fix EACCES if pid of other process is used

2025-03-10 Thread Corinna Vinschen
On Mar 8 14:24, Christian Franke wrote: > This fixes: > > $ taskset -p 0x1 1234 > pid 1234's current affinity mask: fff > taskset: failed to set pid 1234's affinity: Permission denied > > Perhaps older Windows versions were more relaxed if PROCESS_SET_INFORMATION > is granted. > > -- > Reg

Re: [PATCH] Cygwin: signa: Redesign signal queue handling

2025-03-10 Thread Corinna Vinschen
On Mar 9 13:28, Christian Franke wrote: > Takashi Yano wrote: > > ... > > With this patch prevents all signals from that issues by redesigning > > the signal queue, Only the exception is the case that the process is > > in the PID_STOPPED state. In this case, SIGCONT/SIGKILL should be > > processe

Re: [PATCH] fix native symlink spawn passing wrong arg0

2025-03-10 Thread Chris Denton
Currently when starting a process from bash via a native symlink, argv[0] is set to the realpath of the executable and not to the link name. This patch fixes it so the path of the symlink is seen instead. The cause is a path conversion in perhaps_suffix which follows native symlinks. Hence the fix

Re: [PATCH] fix native symlink spawn passing wrong arg0

2025-03-10 Thread Jeremy Drake via Cygwin-patches
For reference, the oldest version of the patch I could find in msys2-runtime was https://github.com/msys2/msys2-runtime/commit/bede85ba6d90b9383f3c83a6e99152284ca90f6a.patch Just the subject for commit message, no sign-off, no nothing.

Re: [PATCH] Cygwin: sched_setaffinity: fix EACCES if pid of other process is used

2025-03-10 Thread Christian Franke
Corinna Vinschen wrote: On Mar 10 13:47, Christian Franke wrote: Corinna Vinschen wrote: On Mar 8 14:24, Christian Franke wrote: ... LGTM. Btw., do you have push permissions? From what I can tell, you already have an account on sourceware and it looks like you have push perms. Is your .s

Re: [PATCH] Cygwin: sched_setaffinity: fix EACCES if pid of other process is used

2025-03-10 Thread Corinna Vinschen
On Mar 10 13:47, Christian Franke wrote: > Corinna Vinschen wrote: > > On Mar 8 14:24, Christian Franke wrote: > > > This fixes: > > > > > > $ taskset -p 0x1 1234 > > > pid 1234's current affinity mask: fff > > > taskset: failed to set pid 1234's affinity: Permission denied > > > > > > Perha

Re: [PATCH] Cygwin: signal: sigaction should ignore SIGKILL & SIGSTOP sliently

2025-03-10 Thread Takashi Yano
Hi Yuyi, On Sat, 8 Mar 2025 16:43:05 +0800 Yuyi Wang wrote: > > The current behavior returns EINVAL on these 2 signals, which is > different from the requirement of POSIX. In addition, it makes > posix_spawn fail to set POSIX_SPAWN_SETSIGDEF. In > newlib/libc/posix/posix_spawn.c:200, it tries to