Re: [PATCH v2] Cygwin: signal: Avoid frequent TLS lock/unlock for SIGCONT processing

2025-01-22 Thread Corinna Vinschen
On Jan 22 07:58, Takashi Yano wrote: > On Tue, 21 Jan 2025 13:20:46 -0800 (PST) > Jeremy Drake wrote: > > dscho hooked me up with a workflow to run Git for Windows' test suite on > > an msys2-runtime pull request's CI artifacts. With this patch and the > > three you pushed (reverting the v2 patch w

Re: [PATCH v3] Cygwin: Minor updates to load average calculations

2025-01-22 Thread Corinna Vinschen
Jon? Are yuo going to review this one? Thanks, Corinna On Jan 20 00:18, Mark Geisert wrote: > Commentary wording now refers to tasks (i.e., threads) rather than > processes. This makes it somewhat easier to justify adding two kinds of > counters together. After researching what "load average"

Re: [PATCH v7 3/5] Cygwin: winsup/doc/posix.xml: SUS V5 POSIX 2024 not implemented new additions

2025-01-22 Thread Corinna Vinschen
On Jan 17 10:01, Brian Inglis wrote: > Add unavailable POSIX additions to Not Implemented section. > > Signed-off-by: Brian Inglis > --- > winsup/doc/posix.xml | 26 -- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/winsup/doc/posix.xml b/winsup/doc/

Re: [PATCH v7 4/5] Cygwin: winsup/doc/posix.xml: SUS V5 POSIX 2024 move or remove dropped entries

2025-01-22 Thread Corinna Vinschen
On Jan 17 10:01, Brian Inglis wrote: > Move entries no longer in POSIX from the SUS/POSIX section to > Deprecated Interfaces section and mark with (SUSv4). > Remove entries no longer in POSIX from the NOT Implemented section. This looks good, but I just realized that a bunch of functions are missi

Re: [PATCH v7 1/5] Cygwin: winsup/doc/posix.xml: SUS V5 POSIX 2024 TOG Issue 8 ISO 9945 move new

2025-01-22 Thread Corinna Vinschen
Hi Brian, your patch doesn't apply. Apparently you didn't rebase the patch to the latest state in the main branch, because your patch contains the changes from commit 0813644661e3, which I wrote I'll fix separately in https://sourceware.org/pipermail/cygwin-patches/2025q1/013265.html Thanks, Co

Re: [PATCH v3] Cygwin: Minor updates to load average calculations

2025-01-22 Thread Jon Turney
On 22/01/2025 10:13, Corinna Vinschen wrote: Jon? Are yuo going to review this one? This looks fine to me. No notes. Please apply. Thanks Mark! (and a particular thank you for fixing the process vs. thread vagueness I'd made in the comments)

Re: [PATCH v7 3/5] Cygwin: winsup/doc/posix.xml: SUS V5 POSIX 2024 not implemented new additions

2025-01-22 Thread Corinna Vinschen
On Jan 22 12:04, Corinna Vinschen wrote: > On Jan 17 10:01, Brian Inglis wrote: > > Add unavailable POSIX additions to Not Implemented section. > > > > Signed-off-by: Brian Inglis > > --- > > winsup/doc/posix.xml | 26 -- > > 1 file changed, 24 insertions(+), 2 deletions(

Re: [PATCH] Cygwin: mmap: use 64K pages for bookkeeping

2025-01-22 Thread Corinna Vinschen
On Jan 20 10:36, Ken Brown wrote: > On 1/20/2025 6:49 AM, Corinna Vinschen wrote: > > Nice idea, but this may not do what is expected if the mapping is an > > anonymous mapping, leaving the protection or mapping of trailing pages > > in a wrong state, isn't it? > > > > Can we easily make sure the

Re: [PATCH v7 1/5] Cygwin: winsup/doc/posix.xml: SUS V5 POSIX 2024 TOG Issue 8 ISO 9945 move new

2025-01-22 Thread Brian Inglis
Hi Corinna, No - never occurred to me other changes would be made here - I have enough problems tracking rebasing from *MY OWN* upstream! On 2025-01-22 03:51, Corinna Vinschen wrote: Hi Brian, your patch doesn't apply. Apparently you didn't rebase the patch to the latest state in the main b

Re: [PATCH v7 3/5] Cygwin: winsup/doc/posix.xml: SUS V5 POSIX 2024 not implemented new additions

2025-01-22 Thread Jon Turney
On 22/01/2025 17:36, Brian Inglis wrote: [...] "Please note some changes are displaced due to rebase conflicts." which only appear after commit --amend/rebase --continue! As I said before, I am now noticing the limitations of interactive rebasing and cherry-picking, sometimes skipping patches

Re: [PATCH v7 3/5] Cygwin: winsup/doc/posix.xml: SUS V5 POSIX 2024 not implemented new additions

2025-01-22 Thread Brian Inglis
On 2025-01-22 04:08, Corinna Vinschen wrote: On Jan 22 12:04, Corinna Vinschen wrote: On Jan 17 10:01, Brian Inglis wrote: Add unavailable POSIX additions to Not Implemented section. Signed-off-by: Brian Inglis --- winsup/doc/posix.xml | 26 -- 1 file changed, 24 in

[PATCH 1/1] replace undocumented Nt* calls with documented win32 apis

2025-01-22 Thread Sebastian Hernandez via Cygwin-patches
Hi all, Attaching the patch from the separate discussion in cygwin-developers - Re: [Proposed changes/Incoming patch] Undocumented call to ntdll.dll!NtAssignProcessToJobObject in msys2.0.dll / cygwin - included in mingit/Git for Windows. The following patch includes the replacement of the foll

Re: [PATCH v7 4/5] Cygwin: winsup/doc/posix.xml: SUS V5 POSIX 2024 move or remove dropped entries

2025-01-22 Thread Jon Turney
On 22/01/2025 11:23, Corinna Vinschen wrote: On Jan 17 10:01, Brian Inglis wrote: Move entries no longer in POSIX from the SUS/POSIX section to Deprecated Interfaces section and mark with (SUSv4). Remove entries no longer in POSIX from the NOT Implemented section. This looks good, but I just r