[PATCH v2] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-06 Thread Takashi Yano
If a cygwin app is executed from a non-cygwin app and the cygwin app exits, the read pipe remains in the non-blocking mode because of the commit fc691d0246b9. Due to this behaviour, the non-cygwin app cannot read the pipe correctly after that. Similarly, if a non-cygwin app is executed from a cygwi

Re: [PATCH] Cygwin: pipe: Switch pipe mode to blocking mode by defaut

2024-09-06 Thread Takashi Yano
On Thu, 5 Sep 2024 17:16:23 +0200 Corinna Vinschen wrote: > thanks for this patch. Two points: Thanks for reviewing so quickly! > On Sep 5 22:18, Takashi Yano wrote: > > @@ -446,12 +441,20 @@ fhandler_pipe_fifo::raw_write (const void *ptr, > > size_t len) > >return -1; > > } > >

Re: [PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-06 Thread Takashi Yano
On Thu, 5 Sep 2024 17:38:11 +0200 Corinna Vinschen wrote: > I think you should push your original patch to the 3.5 branch for now, > and we test the big change in the main branch first. Sounds reasonable. I'll submit a v2 patch for 3.5 branch: [PATCH v2] Cygwin: pipe: Restore blocking mode of read

[PATCH v2] Cygwin: pipe: Switch pipe mode to blocking mode by defaut

2024-09-06 Thread Takashi Yano
Previously, cygwin read pipe used non-blocking mode althogh non- cygwin app uses blocking-mode by default. Despite this requirement, if a cygwin app is executed from a non-cygwwin app and the cygwin app exits, read pipe remains on non-blocking mode because of the commit fc691d0246b9. Due to this be

Re: [PATCH v2] Cygwin: pipe: Switch pipe mode to blocking mode by defaut

2024-09-06 Thread Takashi Yano
On Fri, 6 Sep 2024 18:01:08 +0900 Takashi Yano wrote: > @@ -655,19 +655,17 @@ pipe_data_available (int fd, fhandler_base *fh, HANDLE > h, int flags) >handling this fact. */ >if (fh->get_device () == FH_PIPEW && fpli.WriteQuotaAvailable == 0) > { > - HANDLE query_hdl =

Re: [PATCH v2] Cygwin: pipe: Switch pipe mode to blocking mode by defaut

2024-09-06 Thread Takashi Yano
On Fri, 6 Sep 2024 18:01:08 +0900 Takashi Yano wrote: > diff --git a/winsup/cygwin/select.cc b/winsup/cygwin/select.cc > index bc02c3f9d..9ddb9898c 100644 > --- a/winsup/cygwin/select.cc > +++ b/winsup/cygwin/select.cc > @@ -642,7 +642,7 @@ pipe_data_available (int fd, fhandler_base *fh, HANDLE h,

[PATCH v3] Cygwin: pipe: Switch pipe mode to blocking mode by defaut

2024-09-06 Thread Takashi Yano
Previously, cygwin read pipe used non-blocking mode althogh non- cygwin app uses blocking-mode by default. Despite this requirement, if a cygwin app is executed from a non-cygwwin app and the cygwin app exits, read pipe remains on non-blocking mode because of the commit fc691d0246b9. Due to this be

Re: [PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-06 Thread Takashi Yano
On Fri, 6 Sep 2024 18:01:27 +0900 Takashi Yano wrote: > On Thu, 5 Sep 2024 17:38:11 +0200 > Corinna Vinschen wrote: > > I think you should push your original patch to the 3.5 branch for now, > > and we test the big change in the main branch first. > > Sounds reasonable. I'll submit a v2 patch for

[PATCH v3.1] Cygwin: pipe: Switch pipe mode to blocking mode by defaut

2024-09-06 Thread Takashi Yano
Previously, cygwin read pipe used non-blocking mode althogh non- cygwin app uses blocking-mode by default. Despite this requirement, if a cygwin app is executed from a non-cygwwin app and the cygwin app exits, read pipe remains on non-blocking mode because of the commit fc691d0246b9. Due to this be

[PATCH v3.2] Cygwin: pipe: Switch pipe mode to blocking mode by defaut

2024-09-06 Thread Takashi Yano
Previously, cygwin read pipe used non-blocking mode althogh non- cygwin app uses blocking-mode by default. Despite this requirement, if a cygwin app is executed from a non-cygwwin app and the cygwin app exits, read pipe remains on non-blocking mode because of the commit fc691d0246b9. Due to this be

[PATCH v4] Cygwin: pipe: Switch pipe mode to blocking mode by defaut

2024-09-06 Thread Takashi Yano
Previously, cygwin read pipe used non-blocking mode althogh non- cygwin app uses blocking-mode by default. Despite this requirement, if a cygwin app is executed from a non-cygwwin app and the cygwin app exits, read pipe remains on non-blocking mode because of the commit fc691d0246b9. Due to this be

[PATCH v4.1] Cygwin: pipe: Switch pipe mode to blocking mode by defaut

2024-09-06 Thread Takashi Yano
Previously, cygwin read pipe used non-blocking mode althogh non- cygwin app uses blocking-mode by default. Despite this requirement, if a cygwin app is executed from a non-cygwwin app and the cygwin app exits, read pipe remains on non-blocking mode because of the commit fc691d0246b9. Due to this be

[PATCH v4.2] Cygwin: pipe: Switch pipe mode to blocking mode by defaut

2024-09-06 Thread Takashi Yano
Previously, cygwin read pipe used non-blocking mode althogh non- cygwin app uses blocking-mode by default. Despite this requirement, if a cygwin app is executed from a non-cygwwin app and the cygwin app exits, read pipe remains on non-blocking mode because of the commit fc691d0246b9. Due to this be