Re: [PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-05 Thread Takashi Yano
Hi Corinna, Ken and Johannes On Mon, 2 Sep 2024 23:33:13 +0900 Takashi Yano wrote: > On Mon, 2 Sep 2024 22:50:45 +0900 > Takashi Yano wrote: > > On Mon, 2 Sep 2024 14:48:35 +0200 (CEST) > > Johannes Schindelin wrote: > > > I have tested it and the symptom is addressed. > > > > Thanks for testing.

[PATCH] Cygwin: pipe: Switch pipe mode to blocking mode by defaut

2024-09-05 Thread Takashi Yano
Previously, cygwin read pipe used non-blocking mode althogh non- cygwin app uses blocking-mode by default. Despite this requirement, if a cygwin app is executed from a non-cygwwin app and the cygwin app exits, read pipe remains on non-blocking mode because of the commit fc691d0246b9. Due to this be

Re: [PATCH] Cygwin: pipe: Switch pipe mode to blocking mode by defaut

2024-09-05 Thread Corinna Vinschen
Hi Takashi, thanks for this patch. Two points: On Sep 5 22:18, Takashi Yano wrote: > cannot read the pipe correctly after that. Similarly, if a non- > cygwin app is executed from a cygwin app and the non-cygwin app > exits, the read pipe mode remains on blocking mode although cygwin > read pipe

Re: [PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-05 Thread Corinna Vinschen
Hi Takashi, I think you should push your original patch to the 3.5 branch for now, and we test the big change in the main branch first. Thanks, Corinna On Sep 5 22:18, Takashi Yano wrote: > Hi Corinna, Ken and Johannes > > On Mon, 2 Sep 2024 23:33:13 +0900 > Takashi Yano wrote: > > On Mon, 2