Re: [PATCH] Cygwin: pipe: Give up to use query_hdl for non-cygwin apps.

2024-03-05 Thread Corinna Vinschen
On Mar 5 09:06, Takashi Yano wrote: > On Mon, 4 Mar 2024 18:38:07 +0100 > Corinna Vinschen wrote: > > On Mar 4 16:45, ASSI wrote: > > > Corinna Vinschen writes: > > > > Right you are. We always said that independent Cygwin installations > > > > are supposed to *stay* independent. > > > > > > > >

Re: [PATCH] Cygwin: pipe: Give up to use query_hdl for non-cygwin apps.

2024-03-05 Thread Takashi Yano
On Tue, 5 Mar 2024 11:14:46 +0100 Corinna Vinschen wrote: > On Mar 5 09:06, Takashi Yano wrote: > > On Mon, 4 Mar 2024 18:38:07 +0100 > > Corinna Vinschen wrote: > > > On Mar 4 16:45, ASSI wrote: > > > > Corinna Vinschen writes: > > > > > Right you are. We always said that independent Cygwin ins

[PATCH v3] Cygwin: pipe: Give up to use query_hdl for non-cygwin apps.

2024-03-05 Thread Takashi Yano
Non-cygwin app may call ReadFile() for empty pipe, which makes NtQueryObject() for ObjectNameInformation block in fhandler_pipe:: get_query_hdl_per_process. Therefore, do not to try to get query_hdl for non-cygwin apps. Addresses: https://github.com/msys2/msys2-runtime/issues/202 Fixes: b531d6b06

Re: [PATCH v3] Cygwin: pipe: Give up to use query_hdl for non-cygwin apps.

2024-03-05 Thread Corinna Vinschen
On Mar 5 23:48, Takashi Yano wrote: > Non-cygwin app may call ReadFile() for empty pipe, which makes > NtQueryObject() for ObjectNameInformation block in fhandler_pipe:: > get_query_hdl_per_process. Therefore, do not to try to get query_hdl > for non-cygwin apps. > > Addresses: https://github.com

Re: [PATCH] Cygwin: pipe: Give up to use query_hdl for non-cygwin apps.

2024-03-05 Thread Corinna Vinschen
On Mar 5 23:47, Takashi Yano wrote: > On Tue, 5 Mar 2024 11:14:46 +0100 > Corinna Vinschen wrote: > > This doesn't affect your patch, but while looking into this, what > > strikes me as weird is that fhandler_pipe::temporary_query_hdl() calls > > NtQueryObject() and assembles the pipe name via sws

Re: [PATCH] Cygwin: pipe: Give up to use query_hdl for non-cygwin apps.

2024-03-05 Thread Takashi Yano
On Tue, 5 Mar 2024 17:54:19 +0100 Corinna Vinschen wrote: > On Mar 5 23:47, Takashi Yano wrote: > > On Tue, 5 Mar 2024 11:14:46 +0100 > > Corinna Vinschen wrote: > > > This doesn't affect your patch, but while looking into this, what > > > strikes me as weird is that fhandler_pipe::temporary_query

Re: [PATCH] Cygwin: pipe: Give up to use query_hdl for non-cygwin apps.

2024-03-05 Thread Takashi Yano
On Wed, 6 Mar 2024 03:42:23 +0900 Takashi Yano wrote: > + name.MaximumLength = MAX_PATH * sizeof (WCHAR); This should be: name.MaximumLength = sizeof (pipename_buf); -- Takashi Yano