Re: [PATCH] Cygwin: pipe: Handle STATUS_PENDING even for nonblocking mode.

2021-11-16 Thread Takashi Yano
On Tue, 16 Nov 2021 12:18:47 +0900 Takashi Yano wrote: > - NtReadFile() and NtWriteFile() seems to return STATUS_PENDING > occasionally even in nonblocking mode. This patch adds handling > for STATUS_PENDING in nonblocking mode. > > Addresses: > https://cygwin.com/pipermail/cygwin/2021-Novem

[PATCH v2] Cygwin: pipe: Handle STATUS_PENDING even for nonblocking mode.

2021-11-16 Thread Takashi Yano
- NtReadFile() and NtWriteFile() seems to return STATUS_PENDING occasionally even in nonblocking mode. This patch adds handling for STATUS_PENDING in nonblocking mode. Addresses: https://cygwin.com/pipermail/cygwin/2021-November/249910.html --- winsup/cygwin/fhandler_pipe.cc | 25 ++

[PATCH] console: handle Unicode surrogate pairs

2021-11-16 Thread Johannes Schindelin
When running Cygwin's Bash in the Windows Terminal (see https://docs.microsoft.com/en-us/windows/terminal/ for details), Cygwin is receiving keyboard input in the form of UTF-16 characters. UTF-16 has that awkward challenge that it cannot map the full Unicode range, and to make up for it, there ar

Re: [PATCH] console: handle Unicode surrogate pairs

2021-11-16 Thread Takashi Yano
On Tue, 16 Nov 2021 11:26:10 +0100 (CET) Johannes Schindelin wrote: > When running Cygwin's Bash in the Windows Terminal (see > https://docs.microsoft.com/en-us/windows/terminal/ for details), Cygwin > is receiving keyboard input in the form of UTF-16 characters. > > UTF-16 has that awkward challe

Re: [PATCH] console: handle Unicode surrogate pairs

2021-11-16 Thread Corinna Vinschen
On Nov 16 22:19, Takashi Yano wrote: > On Tue, 16 Nov 2021 11:26:10 +0100 (CET) > Johannes Schindelin wrote: > > When running Cygwin's Bash in the Windows Terminal (see > > https://docs.microsoft.com/en-us/windows/terminal/ for details), Cygwin > > is receiving keyboard input in the form of UTF-16

[PATCH v3] Cygwin: pipe: Handle STATUS_PENDING even for nonblocking mode.

2021-11-16 Thread Takashi Yano
- NtReadFile() and NtWriteFile() seems to return STATUS_PENDING occasionally even in nonblocking mode. This patch adds handling for STATUS_PENDING in nonblocking mode. Addresses: https://cygwin.com/pipermail/cygwin/2021-November/249910.html --- winsup/cygwin/fhandler_pipe.cc | 81 ++

Re: [PATCH v3] Cygwin: pipe: Handle STATUS_PENDING even for nonblocking mode.

2021-11-16 Thread Ken Brown
On 11/16/2021 9:33 AM, Takashi Yano wrote: - NtReadFile() and NtWriteFile() seems to return STATUS_PENDING occasionally even in nonblocking mode. This patch adds handling for STATUS_PENDING in nonblocking mode. I haven't tested (I assume you have), but LGTM except for two typos below. +