[PATCH] Cygwin: console: Add missing guard regarding attach_mutex.

- The commit a545 did not fix the problem enough. This patch provides additional guard for the issue. --- winsup/cygwin/fhandler_console.cc | 27 +++ 1 file changed, 27 insertions(+) diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc

Re: [PATCH v2 0/4] Improve pseudo console support.

Hi Corinna, Thanks for testing. On Fri, 22 Jan 2021 13:20:57 +0100 Corinna Vinschen wrote: > Hi Takashi, > > On Jan 22 05:58, Takashi Yano via Cygwin-patches wrote: > > The new implementation of pseudo console support by commit bb428520 > > provides the important advantages, while there also has

[PATCH v3 0/4] Improve pseudo console support.

The new implementation of pseudo console support by commit bb428520 provides the important advantages, while there also has been several disadvantages compared to the previous implementation. These patches overturn some of them. The disadvantage: 1) The cygwin program which calls console API dir

[PATCH v3 1/4] Cygwin: pty: Inherit typeahead data between two input pipes.

- PTY has a problem that the key input, which is typed during windows native app is running, disappears when it returns to shell. This is beacuse pty has two input pipes, one is for cygwin apps and the other one is for native windows apps. The key input during windows native program is runn

[PATCH v3 2/4] Cygwin: pty: Keep code page between non-cygwin apps.

- After commit bb428520, there has been the disadvantage: 4) Code page cannot be changed by chcp.com. Acctually, chcp works itself and changes code page of its own pseudo console. However, since pseudo console is recreated for another process, it cannot inherit the code page. Th

[PATCH v3 3/4] Cygwin: pty: Make apps using console APIs be able to debug with gdb.

- After commit bb428520, there has been the disadvantage: 2) The apps which use console API cannot be debugged with gdb. This is because pseudo console is not activated since gdb uses CreateProcess() rather than exec(). Even with this limitation, attaching gdb to native app, in whi

[PATCH v3 4/4] Cygwin: pty: Allow multiple apps to enable pseudo console simultaneously.

- After commit bb428520, there has been the disadvantage: 7) Pseudo console cannot be activated if it is already activated for another process on same pty. This patch clears this disadvantage. --- winsup/cygwin/fhandler.h | 7 +- winsup/cygwin/fhandler_tty.cc | 342

Re: [PATCH v3 1/8] syscalls.cc: unlink_nt: Try FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE

Hi Ben, On Jan 22 16:47, Ben Wijen wrote: > I think we don't need an extra flag as we can utilize: access & > FILE_WRITE_ATTRIBUTES > What do you think? Good idea. Pushed. Corinna

[PATCH] Cygwin: chown: make sure ctime gets updated when necessary

Following POSIX, ensure that ctime is updated if chown succeeds, unless the new owner is specified as (uid_t)-1 and the new group is specified as (gid_t)-1. Previously, ctime was unchanged whenever the owner and group were both unchanged. Aside from POSIX compliance, this fix makes gnulib report

Re: [PATCH] Cygwin: console: Add missing guard regarding attach_mutex.

On Jan 25 18:18, Takashi Yano via Cygwin-patches wrote: > - The commit a545 did not fix the problem enough. This patch > provides additional guard for the issue. > --- > winsup/cygwin/fhandler_console.cc | 27 +++ > 1 file changed, 27 insertions(+) Pushed. Thanks,

Re: [PATCH] Cygwin: chown: make sure ctime gets updated when necessary

On Jan 25 12:24, Ken Brown via Cygwin-patches wrote: > Following POSIX, ensure that ctime is updated if chown succeeds, > unless the new owner is specified as (uid_t)-1 and the new group is > specified as (gid_t)-1. Previously, ctime was unchanged whenever the > owner and group were both unchanged

Re: [PATCH v3 2/8] syscalls.cc: Deduplicate remove

On Jan 22 16:47, Ben Wijen wrote: > The remove code is already in the _remove_r function. > So, just call the _remove_r function. > --- > winsup/cygwin/syscalls.cc | 17 - > 1 file changed, 4 insertions(+), 13 deletions(-) Pushed. Thanks, Corinna

Re: [PATCH] Cygwin: chown: make sure ctime gets updated when necessary

On 1/25/2021 1:57 PM, Corinna Vinschen via Cygwin-patches wrote: On Jan 25 12:24, Ken Brown via Cygwin-patches wrote: Following POSIX, ensure that ctime is updated if chown succeeds, unless the new owner is specified as (uid_t)-1 and the new group is specified as (gid_t)-1. Previously, ctime wa

[PATCH v4 0/4] Improve pseudo console support.

The new implementation of pseudo console support by commit bb428520 provides the important advantages, while there also has been several disadvantages compared to the previous implementation. These patches overturn some of them. The disadvantage: 1) The cygwin program which calls console API dir

[PATCH v4 1/4] Cygwin: pty: Inherit typeahead data between two input pipes.

- PTY has a problem that the key input, which is typed during windows native app is running, disappears when it returns to shell. This is beacuse pty has two input pipes, one is for cygwin apps and the other one is for native windows apps. The key input during windows native program is runn

[PATCH v4 2/4] Cygwin: pty: Keep code page between non-cygwin apps.

- After commit bb428520, there has been the disadvantage: 4) Code page cannot be changed by chcp.com. Acctually, chcp works itself and changes code page of its own pseudo console. However, since pseudo console is recreated for another process, it cannot inherit the code page. Th

[PATCH v4 3/4] Cygwin: pty: Make apps using console APIs be able to debug with gdb.

- After commit bb428520, there has been the disadvantage: 2) The apps which use console API cannot be debugged with gdb. This is because pseudo console is not activated since gdb uses CreateProcess() rather than exec(). Even with this limitation, attaching gdb to native app, in whi

[PATCH v4 4/4] Cygwin: pty: Allow multiple apps to enable pseudo console simultaneously.

- After commit bb428520, there has been the disadvantage: 7) Pseudo console cannot be activated if it is already activated for another process on same pty. This patch clears this disadvantage. --- winsup/cygwin/fhandler.h | 7 +- winsup/cygwin/fhandler_tty.cc | 346

[PATCH v5 0/4] Improve pseudo console support.

The new implementation of pseudo console support by commit bb428520 provides the important advantages, while there also has been several disadvantages compared to the previous implementation. These patches overturn some of them. The disadvantage: 1) The cygwin program which calls console API dir

[PATCH v5 1/4] Cygwin: pty: Inherit typeahead data between two input pipes.

- PTY has a problem that the key input, which is typed during windows native app is running, disappears when it returns to shell. This is beacuse pty has two input pipes, one is for cygwin apps and the other one is for native windows apps. The key input during windows native program is runn

[PATCH v5 2/4] Cygwin: pty: Keep code page between non-cygwin apps.

- After commit bb428520, there has been the disadvantage: 4) Code page cannot be changed by chcp.com. Acctually, chcp works itself and changes code page of its own pseudo console. However, since pseudo console is recreated for another process, it cannot inherit the code page. Th

[PATCH v5 3/4] Cygwin: pty: Make apps using console APIs be able to debug with gdb.

- After commit bb428520, there has been the disadvantage: 2) The apps which use console API cannot be debugged with gdb. This is because pseudo console is not activated since gdb uses CreateProcess() rather than exec(). Even with this limitation, attaching gdb to native app, in whi

[PATCH v5 4/4] Cygwin: pty: Allow multiple apps to enable pseudo console simultaneously.

- After commit bb428520, there has been the disadvantage: 7) Pseudo console cannot be activated if it is already activated for another process on same pty. This patch clears this disadvantage. --- winsup/cygwin/fhandler.h | 7 +- winsup/cygwin/fhandler_tty.cc | 346