[PATCH 01/11] Add testsuite directory to autogen.sh

2020-11-05 Thread Jon Turney
Also remove unneeded aclocal.m4 for an old aclocal version. --- winsup/autogen.sh | 2 +- winsup/testsuite/aclocal.m4 | 831 winsup/testsuite/autogen.sh | 4 + 3 files changed, 5 insertions(+), 832 deletions(-) delete mode 100644 winsup/testsuite

[PATCH 00/11] testsuite refurbishment

2020-11-05 Thread Jon Turney
Fix testsuite Makefile/configure, so I have some idea what it's supposed to be doing, prior to cleanup and Automake-ification. > $ make check [...] > # of expected passes253 > # of unexpected failures23 > # of unexpected successes 1 > # of expected failures 7 F

[PATCH 02/11] Always configure in testsuite subdirectory

2020-11-05 Thread Jon Turney
Doing this properly using AC_CONFIG_SUBDIRS is necessary to get the correct paths in flags given to the compiler specified in CC/CXX. --- winsup/Makefile.in | 16 +--- winsup/configure.ac | 2 +- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/winsup/Makefile.in b/win

[PATCH 09/11] Check exit code of a test, rather than stdout

2020-11-05 Thread Jon Turney
In winsup.exp, don't consider a command failed if it produced any output (e.g. if the compiler produced warnings). Instead check the exit code. --- winsup/testsuite/winsup.api/winsup.exp | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/winsup/testsuite/win

[PATCH 07/11] Detect and use MinGW compilers for testsuite wrappers

2020-11-05 Thread Jon Turney
Drop MINGW_FE, which I can't find any trace of, and instead detect and use MinGW compilers. This requires adding AC_CANONICAL_TARGET, to set $target_cpu. --- winsup/testsuite/Makefile.in| 8 +--- winsup/testsuite/configure.ac | 5 + winsup/testsuite/winsup.api/cygloa

[PATCH 04/11] Avoid 'Makefile.in seems to ignore the --datarootdir setting' warning

2020-11-05 Thread Jon Turney
Avoid a 'Makefile.in seems to ignore the --datarootdir setting' warning when configuring. --- winsup/testsuite/Makefile.in | 1 + 1 file changed, 1 insertion(+) diff --git a/winsup/testsuite/Makefile.in b/winsup/testsuite/Makefile.in index 0e7f6ff1e..50319cda4 100644 --- a/winsup/testsuite/Makefi

[PATCH 05/11] Move adding libltp to VPATH after Makefile.common

2020-11-05 Thread Jon Turney
Move adding libltp to the VPATH after Makefile.common, which sets VPATH. --- winsup/testsuite/Makefile.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/winsup/testsuite/Makefile.in b/winsup/testsuite/Makefile.in index 50319cda4..aaa5851b2 100644 --- a/winsup/testsuite/Mak

[PATCH 10/11] Set PATH for tests to pick up cygwin0.dll

2020-11-05 Thread Jon Turney
Set the PATH so that tests can pick up cygwin0.dll. Looks like this was dropped by accident in 2e488e95 ("Don't rely on in-build tools"), so restore it as it was prior to 9d89f634. --- winsup/testsuite/Makefile.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/winsup/testsuite/Makefile.in

[PATCH 11/11] Ensure temporary directory used by tests exists

2020-11-05 Thread Jon Turney
By default, libltp tests will create temporary files in a subdirectory of /tmp, which will (nowadays) be located relative to the test DLL (by assuming that it is in /bin). This will evaluate to the directory $target_builddir/winsup/tmp, which doesn't exist. The location used for these temporary f

[PATCH 08/11] Use absolute path to libltp includes

2020-11-05 Thread Jon Turney
Use an absolute path to libltp includes, to allow for the fact that we'll be compiling tests in a subdirectory. --- winsup/testsuite/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/winsup/testsuite/Makefile.in b/winsup/testsuite/Makefile.in index 53eb67308..a9388ef6

[PATCH 03/11] Add rule to testsuite Makefile to regenerate it when needed

2020-11-05 Thread Jon Turney
--- winsup/testsuite/Makefile.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/winsup/testsuite/Makefile.in b/winsup/testsuite/Makefile.in index 1b0d0de59..0e7f6ff1e 100644 --- a/winsup/testsuite/Makefile.in +++ b/winsup/testsuite/Makefile.in @@ -165,3 +165,6 @@ cygrun.o: cygrun.c cygr

[PATCH 06/11] Define target_builddir autoconf and Makefile variables

2020-11-05 Thread Jon Turney
This now required as cygwin_build is defined in terms of target_builddir. (Note that in other subdirectories, the autoconf variable target_builddir is AC_SUBST-ed as a side-effect of using a macro from winsup/acinclude.m4, which is perhaps less than ideal) --- winsup/testsuite/Makefile.in | 1 +