[PATCH] fhandler_proc.cc:format_proc_cpuinfo add rdpru flag

2020-01-23 Thread Brian Inglis
rdpru flag is cpuid xfn 8008 ebx bit 4 added in linux 5.5; see AMD64 Architecture Programmer’s Manual Volume 3: General-Purpose and System Instructions https://www.amd.com/system/files/TechDocs/24594.pdf#page=329 and elsewhere in that document --- winsup/cygwin/fhandler_proc.cc | 1 + 1 fil

[PATCH] Cygwin: pty: Remove close() call just before reopening slave.

2020-01-23 Thread Takashi Yano
- After commit da4ee7d60b9ff0bcdc081609a4467adb428d58e6, the issue reported in https://www.cygwin.com/ml/cygwin/2020-01/msg00209.html occurs. This patch fixes the issue. --- winsup/cygwin/fhandler_tty.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/

Re: [PATCH] Cygwin: pty: Remove close() call just before reopening slave.

2020-01-23 Thread Corinna Vinschen
On Jan 23 20:34, Takashi Yano wrote: > - After commit da4ee7d60b9ff0bcdc081609a4467adb428d58e6, the issue > reported in https://www.cygwin.com/ml/cygwin/2020-01/msg00209.html > occurs. This patch fixes the issue. > --- > winsup/cygwin/fhandler_tty.cc | 1 - > 1 file changed, 1 deletion(-) > >

Re: [PATCH] fhandler_proc.cc:format_proc_cpuinfo add rdpru flag

2020-01-23 Thread Corinna Vinschen
On Jan 23 02:06, Brian Inglis wrote: > rdpru flag is cpuid xfn 8008 ebx bit 4 added in linux 5.5; > see AMD64 Architecture Programmer’s Manual Volume 3: ^ This came over already broken. No idea if that's a problem of your MUA or of the mailing list

Re: [PATCH] Cygwin: pty: Add missing console API hooks.

2020-01-23 Thread Corinna Vinschen
On Jan 23 13:33, Takashi Yano wrote: > - Following console APIs are additionally hooked for cygwin programs > which directly call them. > * FillConsoleOutputAttribute() > * FillConsoleOutputCharacterA() > * FillConsoleOutputCharacterW() > * ScrollConsoleScreenBufferA() > * ScrollConsole

Re: [PATCH v2] Cygwin: pty: Revise code waiting for forwarding again.

2020-01-23 Thread Corinna Vinschen
On Jan 23 13:30, Takashi Yano wrote: > - After commit 6cc299f0e20e4b76f7dbab5ea8c296ffa4859b62, outputs of > cygwin programs which call both printf() and WriteConsole() are > frequently distorted. This patch reverts waiting function to dumb > Sleep(). I understand the need for this change, b

Re: [PATCH] Cygwin: pty: Add missing console API hooks.

2020-01-23 Thread Takashi Yano
On Thu, 23 Jan 2020 13:48:13 +0100 Corinna Vinschen wrote: > On Jan 23 13:33, Takashi Yano wrote: > > - Following console APIs are additionally hooked for cygwin programs > > which directly call them. > > * FillConsoleOutputAttribute() > > * FillConsoleOutputCharacterA() > > * FillConsoleOu

Re: [PATCH v2] Cygwin: pty: Revise code waiting for forwarding again.

2020-01-23 Thread Koichi Murase
> On Jan 23 13:30, Takashi Yano wrote: > > - After commit 6cc299f0e20e4b76f7dbab5ea8c296ffa4859b62, outputs of > > cygwin programs which call both printf() and WriteConsole() are > > frequently distorted. This patch reverts waiting function to dumb > > Sleep(). Hi, I have a question rela

Re: [PATCH v2] Cygwin: pty: Revise code waiting for forwarding again.

2020-01-23 Thread Koichi Murase
2020年1月23日(木) 21:39 Koichi Murase : > > On Jan 23 13:30, Takashi Yano wrote: > > > - After commit 6cc299f0e20e4b76f7dbab5ea8c296ffa4859b62, outputs of > > > cygwin programs which call both printf() and WriteConsole() are > > > frequently distorted. This patch reverts waiting function to dumb >

Re: [PATCH v2] Cygwin: pty: Revise code waiting for forwarding again.

2020-01-23 Thread Takashi Yano
On Thu, 23 Jan 2020 21:39:50 +0800 Koichi Murase wrote: > 0 [main] () shared_info::initialize: size of shared > memory region changed from 50104 to 49080 Is there any process alived using diffrent version of cygwin1.dll? -- Takashi Yano

Re: [PATCH v2] Cygwin: pty: Revise code waiting for forwarding again.

2020-01-23 Thread Takashi Yano
On Thu, 23 Jan 2020 13:51:54 +0100 Corinna Vinschen wrote: > On Jan 23 13:30, Takashi Yano wrote: > > - After commit 6cc299f0e20e4b76f7dbab5ea8c296ffa4859b62, outputs of > > cygwin programs which call both printf() and WriteConsole() are > > frequently distorted. This patch reverts waiting func

Re: [PATCH v2] Cygwin: pty: Revise code waiting for forwarding again.

2020-01-23 Thread Koichi Murase
2020年1月23日(木) 22:00 Takashi Yano : > Is there any process alived using diffrent version of cygwin1.dll? Ah, you were right! Actually there were no *real* processes remained (Otherwise I could not have overwritten cygwin1.dll, I think), but I remembered that there is a remaining *fake entry* in th

Re: [PATCH v2] Cygwin: pty: Revise code waiting for forwarding again.

2020-01-23 Thread Takashi Yano
On Thu, 23 Jan 2020 13:51:54 +0100 Corinna Vinschen wrote: > On Jan 23 13:30, Takashi Yano wrote: > > - After commit 6cc299f0e20e4b76f7dbab5ea8c296ffa4859b62, outputs of > > cygwin programs which call both printf() and WriteConsole() are > > frequently distorted. This patch reverts waiting func

[PATCH 3/3] Cygwin: FIFO: tweak fcntl and dup when O_PATH is set

2020-01-23 Thread Ken Brown
fhandler_fifo::fcntl and fhandler_fifo::dup now call the corresponding fhandler_base methods if the FIFO was opened with the O_PATH flag. --- winsup/cygwin/fhandler_fifo.cc | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/fhandler_fifo.cc b/winsup/cygwin/fhandl

[PATCH 1/3] Cygwin: device_access_denied: return false if O_PATH is set

2020-01-23 Thread Ken Brown
If O_PATH is set in the flags argument of fhandler_base::device_access_denied, return false. No read/write/execute access should be required in this case. Previously, the call to device_access_denied in open(2) would lead to an attempt to open the file with read access even if the O_PATH flag was

[PATCH 2/3] Cygwin: re-implement fhandler_fifo::open with O_PATH

2020-01-23 Thread Ken Brown
If the O_PATH flag is set, fhandler_fifo::open now simply calls fhandler_base::open_fs. The previous attempt to handle O_PATH in commit aa55d22c, "Cygwin: honor the O_PATH flag when opening a FIFO", fixed a hang but otherwise didn't do anything useful. --- winsup/cygwin/fhandler_fifo.cc | 10 ++--

[PATCH 0/3] Fix the O_PATH support for FIFOs

2020-01-23 Thread Ken Brown
Commit aa55d22c, "Cygwin: honor the O_PATH flag when opening a FIFO", fixed a hang but otherwise didn't accomplish the purpose of the O_PATH flag as stated in the Linux man page for open(2): Obtain a file descriptor that can be used for two purposes: to indicate a location in the filesyste

Re: [PATCH] fhandler_proc.cc:format_proc_cpuinfo add rdpru flag

2020-01-23 Thread Brian Inglis
On 2020-01-23 05:44, Corinna Vinschen wrote: > On Jan 23 02:06, Brian Inglis wrote: >> rdpru flag is cpuid xfn 8008 ebx bit 4 added in linux 5.5; >> see AMD64 Architecture Programmer’s Manual Volume 3: >^ > This came over already broken. No idea if

Re: [PATCH 0/3] Fix the O_PATH support for FIFOs

2020-01-23 Thread Ken Brown
On 1/23/2020 11:31 AM, Ken Brown wrote: > Commit aa55d22c, "Cygwin: honor the O_PATH flag when opening a FIFO", > fixed a hang but otherwise didn't accomplish the purpose of the O_PATH > flag as stated in the Linux man page for open(2): > > Obtain a file descriptor that can be used for two pu