Re: [PATCH] Cygwin: make path_conv::isdevice() return false on socket files

2019-07-19 Thread Corinna Vinschen
Hi Ken, On Jul 18 20:02, Ken Brown wrote: > As a result, socket files are no longer treated as lnk special files. > This prevents rename() from adding ".lnk" when renaming a socket file. > > Remove a redundant !pc.issocket() from fhandler_disk_file::link(). I see what you're doing here, but it's

[PATCH] Cygwin: unbreak the build with GCC 7

2019-07-19 Thread Ken Brown
The recent port to GCC 8 used the 'nonstring' attribute, which is unknown to GCC 7. Define and use an 'ATTRIBUTE_NONSTRING' macro instead. --- winsup/cygwin/include/sys/utmp.h | 11 --- winsup/cygwin/uname.cc | 8 +++- 2 files changed, 15 insertions(+), 4 deletions(-) diff

Re: [PATCH] Cygwin: unbreak the build with GCC 7

2019-07-19 Thread Corinna Vinschen
On Jul 19 18:27, Ken Brown wrote: > The recent port to GCC 8 used the 'nonstring' attribute, which is > unknown to GCC 7. Define and use an 'ATTRIBUTE_NONSTRING' macro > instead. LGTM, please push. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signatur