Re: [PATCH] strace: Fix crash caused over-optimization

2017-04-19 Thread Daniel Santos
On 04/18/2017 05:04 AM, Corinna Vinschen wrote: On Apr 17 03:39, Daniel Santos wrote: I actually did try that, although I had guessed it wouldn't (and shouldn't) work. I believe that the reason is that rather the accesses are volatile or not, gcc can see nothing else using it and memset can be

[PATCH v2] strace: Fix "over-optimization" flaw in strace.

2017-04-19 Thread Daniel Santos
Recent versions of gcc are optimizing away the TLS buffer allocated in main, so we need to tell gcc that it's really used. RtlSecureZeroMemory accomplishes this while also inlining the memset. Signed-off-by: Daniel Santos --- winsup/utils/strace.cc | 2 +- 1 file changed, 1 insertion(+), 1 dele

resend: Re: [PATCH] strace: Fix crash caused over-optimization

2017-04-19 Thread Daniel Santos
sourceware.org decided that I was a spammer for some weird reason... Maybe this one will go through... On 04/19/2017 10:52 AM, mailer-dae...@sourceware.org wrote: Hi. This is the qmail-send program at sourceware.org. I'm afraid I wasn't able to deliver your message to the following addresses. T

Re: [PATCH v2] strace: Fix "over-optimization" flaw in strace.

2017-04-19 Thread Corinna Vinschen
On Apr 19 11:06, Daniel Santos wrote: > Recent versions of gcc are optimizing away the TLS buffer allocated in > main, so we need to tell gcc that it's really used. RtlSecureZeroMemory > accomplishes this while also inlining the memset. > > Signed-off-by: Daniel Santos > --- > winsup/utils/stra

Re: [PATCH v2] strace: Fix "over-optimization" flaw in strace.

2017-04-19 Thread Daniel Santos
On 04/19/2017 01:48 PM, Corinna Vinschen wrote: Pushed. Thanks, Corinna Thanks. I hope this message goes through. Earlier when I tried to respond with both you and cygwin-patches in the To: header it bounced. I emailed cygwin-ow...@cygwin.com about this, is that the right address for mail

test message

2017-04-19 Thread Daniel Santos
Will this bounce again?

Re: [PATCH v2] strace: Fix "over-optimization" flaw in strace.

2017-04-19 Thread Daniel Santos
On 04/19/2017 05:10 PM, Daniel Santos wrote: Thanks. I hope this message goes through. Earlier when I tried to respond with both you and cygwin-patches in the To: header it bounced. I emailed cygwin-ow...@cygwin.com about this, is that the right address for mailing list problems? Actually, an