Re: [PATCH v3] Refactor to avoid nonnull checks on "this" pointer.

2016-04-05 Thread Corinna Vinschen
On Apr 4 16:52, Corinna Vinschen wrote: > On Apr 2 11:36, Peter Foley wrote: > > G++ 6.0 asserts that the "this" pointer is non-null for member > > functions. > > Refactor methods that check if "this" is non-null to resolve this. > > > > winsup/cygwin/ChangeLog: > > external.cc (cygwin_internal)

[PATCH] Be truthful about reporting whether readahead is available

2016-04-05 Thread Johannes Schindelin
In 7346568 (Make requested console reports work, 2016-03-16), code was introduced to report the current cursor position. It works by using a pointer that either points to the next byte in the readahead buffer, or to a NUL byte if the buffer is depleted, or the pointer is NULL. These conditions are

Re: [PATCH] Be truthful about reporting whether readahead is available

2016-04-05 Thread Corinna Vinschen
Thomas? Any input? On Apr 5 10:52, Johannes Schindelin wrote: > In 7346568 (Make requested console reports work, 2016-03-16), code was > introduced to report the current cursor position. It works by using a > pointer that either points to the next byte in the readahead buffer, or > to a NUL byte

Re: [PATCH v3] Refactor to avoid nonnull checks on "this" pointer.

2016-04-05 Thread Peter Foley
On Tue, Apr 5, 2016 at 4:32 AM, Corinna Vinschen wrote: > And reverted. This patch is the culprit for the problem reported in > https://cygwin.com/ml/cygwin/2016-04/msg00085.html > > Can you please take another look, Peter? Huh, that's odd... I'll take a look when I have some free time. Thanks,

Re: Fwd: Re: [PATCH] Be truthful about reporting whether readahead is available

2016-04-05 Thread Thomas Wolff
Von: Corinna Vinschen An: cygwin-patches@cygwin.com Cc: Thomas Wolff Datum: 5. April 2016 um 15:55 Betreff: Re: [PATCH] Be truthful about reporting whether readahead is available Thomas? Any input? Yes, let's fix the patch so. Sorry for the flaw. Thomas On Apr 5 10:52, Johannes Schind

Re: Fwd: Re: [PATCH] Be truthful about reporting whether readahead is available

2016-04-05 Thread Corinna Vinschen
On Apr 5 18:50, Thomas Wolff wrote: > > >>Von: Corinna Vinschen > >>An: cygwin-patches@cygwin.com > >>Cc: Thomas Wolff > >>Datum: 5. April 2016 um 15:55 > >>Betreff: Re: [PATCH] Be truthful about reporting whether readahead is > >>available > >> > >>Thomas? > >> > >>Any input? > >> > Yes, let's