Re: [PATCH] cygwin: fix errors with GCC 5

2016-02-12 Thread Corinna Vinschen
Hi Yaakov, On Feb 11 20:26, Yaakov Selkowitz wrote: > GCC 5 switched from C89 to C11 by default, which implies a change from > GNU to C99 inline. > > winsup/cygwin/ > * exceptions.cc (exception::handle): Fix always-true boolean > comparison warning. > * include/cygwin/conf

Re: [PATCH] cygwin: update child info magic

2016-02-12 Thread Corinna Vinschen
On Feb 11 20:38, Yaakov Selkowitz wrote: > winsup/cygwin/ > * child_info.h (CURR_CHILD_INFO_MAGIC): Update. > > Signed-off-by: Yaakov Selkowitz > --- > winsup/cygwin/child_info.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/winsup/cygwin/child_info.h b/wi

[PATCH] POSIX barrier implementation, take 2

2016-02-12 Thread Václav Haisman
Hi. Here is a second take on the POSIX barrier API. This time it is tested with the attached barrier.c file. Here is a change log. Newlib: * libc/include/sys/features.h (_POSIX_BARRIERS): Define for Cygwin. * libc/include/sys/types.h (pthread_barrier_t) (pthread_barriera

Re: [PATCH] POSIX barrier implementation, take 2

2016-02-12 Thread Corinna Vinschen
Hi Václav, the patch looks pretty good, I have just a few (minor) nits: On Feb 12 11:20, Václav Haisman wrote: > diff --git a/newlib/libc/include/sys/types.h b/newlib/libc/include/sys/types.h > index 5dd6c75..bfe93fa 100644 > --- a/newlib/libc/include/sys/types.h > +++ b/newlib/libc/include/sys/

Re: [PATCH] cygwin: update child info magic

2016-02-12 Thread Yaakov Selkowitz
On 2016-02-12 03:33, Corinna Vinschen wrote: On Feb 11 20:38, Yaakov Selkowitz wrote: winsup/cygwin/ * child_info.h (CURR_CHILD_INFO_MAGIC): Update. This needs an explanation. CHILD_INFO_MAGIC is still 0x30ea98f6U for me. Hmmm, in that case it's either one of the patches I j

Re: [PATCH] cygwin: update child info magic

2016-02-12 Thread Corinna Vinschen
On Feb 12 10:53, Yaakov Selkowitz wrote: > On 2016-02-12 03:33, Corinna Vinschen wrote: > >On Feb 11 20:38, Yaakov Selkowitz wrote: > >>winsup/cygwin/ > >>* child_info.h (CURR_CHILD_INFO_MAGIC): Update. > > > >This needs an explanation. CHILD_INFO_MAGIC is still 0x30ea98f6U > >for me. > >

[PATCH v2] cygwin: fix errors with GCC 5

2016-02-12 Thread Yaakov Selkowitz
GCC 5 switched from C89 to C11 by default. This implies a change from GNU to C99 inline by default, which have very different meanings of extern inline vs. static inline: https://gcc.gnu.org/onlinedocs/gcc/Inline.html Marking these as gnu_inline retains the previous behaviour. winsup/cyg

Re: [PATCH v2] cygwin: fix errors with GCC 5

2016-02-12 Thread Corinna Vinschen
On Feb 12 11:27, Yaakov Selkowitz wrote: > GCC 5 switched from C89 to C11 by default. This implies a change from > GNU to C99 inline by default, which have very different meanings of > extern inline vs. static inline: > > https://gcc.gnu.org/onlinedocs/gcc/Inline.html > > Marking these as gnu_inl

Re: [PATCH] cygwin: update child info magic

2016-02-12 Thread Yaakov Selkowitz
On 2016-02-12 11:18, Corinna Vinschen wrote: On Feb 12 10:53, Yaakov Selkowitz wrote: On 2016-02-12 03:33, Corinna Vinschen wrote: On Feb 11 20:38, Yaakov Selkowitz wrote: winsup/cygwin/ * child_info.h (CURR_CHILD_INFO_MAGIC): Update. This needs an explanation. CHILD_INFO_MA

Re: [PATCH] cygwin: update child info magic

2016-02-12 Thread Corinna Vinschen
On Feb 12 14:05, Yaakov Selkowitz wrote: > On 2016-02-12 11:18, Corinna Vinschen wrote: > >On Feb 12 10:53, Yaakov Selkowitz wrote: > >>On 2016-02-12 03:33, Corinna Vinschen wrote: > >>>On Feb 11 20:38, Yaakov Selkowitz wrote: > winsup/cygwin/ > * child_info.h (CURR_CHILD_INFO_MAGIC): U

Re: [PATCH] cygwin: update child info magic

2016-02-12 Thread Eric Blake
On 02/12/2016 01:05 PM, Yaakov Selkowitz wrote: >> Off the top of my head, I don't know. Usually only a change to >> child_info.h should affect CHILD_INFO_MAGIC. Unless the preprocessed >> output of gcc differs for some reason. > > It turns out it does. Anything that is substituted by preproce

Re: [PATCH] cygwin: update child info magic

2016-02-12 Thread Eric Blake
On 02/12/2016 01:31 PM, Corinna Vinschen wrote: >> >> extern "C" { >> extern child_info *child_proc_info; >> -extern child_info_spawn *spawn_info asm ("_" "child_proc_info"); >> -extern child_info_fork *fork_info asm ("_" "child_proc_info"); >> +extern child_info_spawn *spawn_info asm ( >> +

Re: [PATCH] POSIX barrier implementation, take 2

2016-02-12 Thread Václav Haisman
On 12.2.2016 15:25, Corinna Vinschen wrote: > Hi Václav, > > > the patch looks pretty good, I have just a few (minor) nits: > > On Feb 12 11:20, Václav Haisman wrote: >> diff --git a/newlib/libc/include/sys/types.h >> b/newlib/libc/include/sys/types.h >> index 5dd6c75..bfe93fa 100644 >> --- a/n

Re: [PATCH] POSIX barrier implementation, take 3

2016-02-12 Thread Václav Haisman
On 12.2.2016 15:25, Corinna Vinschen wrote: > Hi Václav, > > > the patch looks pretty good, I have just a few (minor) nits: > > On Feb 12 11:20, Václav Haisman wrote: >> diff --git a/newlib/libc/include/sys/types.h >> b/newlib/libc/include/sys/types.h >> index 5dd6c75..bfe93fa 100644 >> --- a/n

[PATCH v2] cygwin: work around GCC 5 preprocessor changes

2016-02-12 Thread Yaakov Selkowitz
GCC 5 adds #line directives (and hence extra newlines) for macros expansions, which confuses cygmagic. Using the -P flag avoids them entirely. https://cygwin.com/ml/cygwin-patches/2016-q1/msg00016.html Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/cygmagic | 2 +- 1 file changed, 1 inserti