Re: New modes for cygpath that terminate path with null byte, nothing

2012-08-16 Thread Corinna Vinschen
On Aug 14 22:11, Daniel Colascione wrote: > On 8/14/12 10:02 PM, Christopher Faylor wrote: > > On Tue, Aug 14, 2012 at 02:49:17PM -0700, Daniel Colascione wrote: > >> On 7/27/2012 2:32 AM, Corinna Vinschen wrote: > >>> There's just the problem of the copyright assignment. If you want to > >>> prov

Re: /dev/clipboard pasting with small read() buffer

2012-08-16 Thread Corinna Vinschen
Hi Thomas, thanks for the patch. I have a few minor nits: On Aug 14 22:56, Thomas Wolff wrote: > --- sav/fhandler_clipboard.cc 2012-07-08 02:36:47.0 +0200 > +++ ./fhandler_clipboard.cc 2012-08-14 18:25:14.903255600 +0200 > @@ -222,6 +222,7 @@ fhandler_dev_clipboard::read (void *ptr, >

Re: /dev/clipboard pasting with small read() buffer

2012-08-16 Thread Thomas Wolff
Hi Corinna, On 16.08.2012 11:33, Corinna Vinschen wrote: Hi Thomas, thanks for the patch. I have a few minor nits: On Aug 14 22:56, Thomas Wolff wrote: --- sav/fhandler_clipboard.cc 2012-07-08 02:36:47.0 +0200 +++ ./fhandler_clipboard.cc 2012-08-14 18:25:14.903255600 +0200 ...

Re: /dev/clipboard pasting with small read() buffer

2012-08-16 Thread Corinna Vinschen
On Aug 16 14:11, Thomas Wolff wrote: > Hi Corinna, > > On 16.08.2012 11:33, Corinna Vinschen wrote: > >Hi Thomas, > > > >thanks for the patch. I have a few minor nits: > > > >On Aug 14 22:56, Thomas Wolff wrote: > >>--- sav/fhandler_clipboard.cc 2012-07-08 02:36:47.0 +0200 > >>+++

Re: /dev/clipboard pasting with small read() buffer

2012-08-16 Thread Thomas Wolff
On 16.08.2012 14:30, Corinna Vinschen wrote: On Aug 16 14:11, Thomas Wolff wrote: Hi Corinna, On 16.08.2012 11:33, Corinna Vinschen wrote: Hi Thomas, thanks for the patch. I have a few minor nits: On Aug 14 22:56, Thomas Wolff wrote: ... + char cprabuf [8 + 1]; /* need this lengt

Re: /dev/clipboard pasting with small read() buffer

2012-08-16 Thread Eric Blake
On 08/16/2012 08:20 AM, Thomas Wolff wrote: >>> MB_CUR_MAX does not work because its value is 1 at this point >> So what about MB_LEN_MAX then? There's no problem using a multiplier, >> but a symbolic constant is always better than a numerical constant. > I've now used _MB_LEN_MAX from newlib.h,

Re: /dev/clipboard pasting with small read() buffer

2012-08-16 Thread Corinna Vinschen
On Aug 16 09:24, Eric Blake wrote: > On 08/16/2012 08:20 AM, Thomas Wolff wrote: > > >>> MB_CUR_MAX does not work because its value is 1 at this point > >> So what about MB_LEN_MAX then? There's no problem using a multiplier, > >> but a symbolic constant is always better than a numerical constant