Re: [PATCH] Add getmntent_r

2012-06-05 Thread Corinna Vinschen
Hi Yaakov, thanks for the patch, but this won't fly. On Jun 5 00:08, Yaakov (Cygwin/X) wrote: > This patch set implements getmntent_r, a GNU extension: > > http://man7.org/linux/man-pages/man3/getmntent.3.html > > libvirt needs this[1], as I just (re)discovered. Patches for > winsup/cygwin an

Re: [PATCH] Add getmntent_r

2012-06-05 Thread Corinna Vinschen
On Jun 5 14:42, Corinna Vinschen wrote: > Hi Yaakov, > > thanks for the patch, but this won't fly. > > On Jun 5 00:08, Yaakov (Cygwin/X) wrote: > > This patch set implements getmntent_r, a GNU extension: > > > > http://man7.org/linux/man-pages/man3/getmntent.3.html > > > > libvirt needs this[

Re: [PATCH] Add getmntent_r

2012-06-05 Thread Corinna Vinschen
And I missed a line in my dirty code example: On Jun 5 14:42, Corinna Vinschen wrote: > What you want is more like this (untested): > > struct mntent *mnt = mount_table->getmntent (_my_tls.locals.iteration++); > if (!mnt) > return NULL; >int maxlen = strlen (mnt->mnt_fsname) + strl

Re: [PATCH] Add getmntent_r

2012-06-05 Thread Corinna Vinschen
On Jun 5 16:39, Corinna Vinschen wrote: > And I missed a line in my dirty code example: And I missed to add a + 1 to the pointers returned from stpcpy. Sigh. Let's restart: struct mntent *mnt = mount_table->getmntent (_my_tls.locals.iteration++); if (!mnt) return NULL; int maxlen = st

Re: [PATCH] Add getmntent_r

2012-06-05 Thread Yaakov (Cygwin/X)
On 2012-06-05 07:42, Corinna Vinschen wrote: +extern "C" struct mntent * +getmntent_r (FILE *, struct mntent *mntbuf, char *buf, int buflen) +{ + struct mntent *mnt = mount_table->getmntent (_my_tls.locals.iteration++); + char *tmpbuf; + int len = 0, maxlen; + + if (!mnt) +{ + mntbuf

Re: elf.h incomplete

2012-06-05 Thread Christopher Faylor
On Tue, Jun 05, 2012 at 10:45:26PM -0500, Yaakov (Cygwin/X) wrote: >On 2012-05-03 17:03, Yaakov (Cygwin/X) wrote: >> On 2012-05-03 10:24, Christopher Faylor wrote: >>> Right. I've noticed the incompleteness of elf.h from time to time too but >>> extending it would be tedious since you can't just cu