Re: [Patch] Loading the registry hive on Win9x (part 2)

2004-11-22 Thread Christopher Faylor
On Sun, Nov 21, 2004 at 09:55:38PM -0500, Pierre A. Humblet wrote: >- got_something_from_registry = regopt ("default"); > if (myself->progname[0]) >-got_something_from_registry = regopt (myself->progname) || >got_something_from_registry; >+got_something_from_registry = regopt (myself->p

Re: [Patch] Loading the registry hive on Win9x (part 2)

2004-11-22 Thread Pierre A. Humblet
Christopher Faylor wrote: > > On Sun, Nov 21, 2004 at 09:55:38PM -0500, Pierre A. Humblet wrote: > >- got_something_from_registry = regopt ("default"); > > if (myself->progname[0]) > >-got_something_from_registry = regopt (myself->progname) || > >got_something_from_registry; > >+got_s

Re: [Patch] Loading the registry hive on Win9x (part 2)

2004-11-22 Thread Christopher Faylor
On Mon, Nov 22, 2004 at 10:48:30AM -0500, Pierre A. Humblet wrote: >Christopher Faylor wrote: >> >> On Sun, Nov 21, 2004 at 09:55:38PM -0500, Pierre A. Humblet wrote: >> >- got_something_from_registry = regopt ("default"); >> > if (myself->progname[0]) >> >-got_something_from_registry = reg

Re: [Patch] Fixing the PROCESS_DUP_HANDLE security hole.

2004-11-22 Thread Igor Pechtchanski
On Sat, 20 Nov 2004, Christopher Faylor wrote: > Here's the good news/bad news. > > On Tue, Nov 16, 2004 at 10:56:40AM -0500, Christopher Faylor wrote: > >The simplification of the code from removing all of the reparenting > >considerations is not something that I'm going to give up on easily. > >

Re: [Patch] Fixing the PROCESS_DUP_HANDLE security hole.

2004-11-22 Thread Christopher Faylor
On Mon, Nov 22, 2004 at 12:46:46PM -0500, Igor Pechtchanski wrote: >Can the code simply propagate the actual exit code into the exitcode >field (since Windows programs don't know about signals)? And who would use it? How would a UNIX program know that the "negative" exit code represented a window

Re: [Patch] Fixing the PROCESS_DUP_HANDLE security hole.

2004-11-22 Thread Igor Pechtchanski
On Mon, 22 Nov 2004, Christopher Faylor wrote: > On Mon, Nov 22, 2004 at 12:46:46PM -0500, Igor Pechtchanski wrote: > >Can the code simply propagate the actual exit code into the exitcode > >field (since Windows programs don't know about signals)? > > And who would use it? How would a UNIX progra

Re: [Patch] Fixing the PROCESS_DUP_HANDLE security hole.

2004-11-22 Thread Christopher Faylor
On Mon, Nov 22, 2004 at 01:20:45PM -0500, Igor Pechtchanski wrote: >On Mon, 22 Nov 2004, Christopher Faylor wrote: > >> On Mon, Nov 22, 2004 at 12:46:46PM -0500, Igor Pechtchanski wrote: >> >Can the code simply propagate the actual exit code into the exitcode >> >field (since Windows programs don't

Re: [Patch] Fixing the PROCESS_DUP_HANDLE security hole.

2004-11-22 Thread Igor Pechtchanski
On Mon, 22 Nov 2004, Christopher Faylor wrote: > On Mon, Nov 22, 2004 at 01:20:45PM -0500, Igor Pechtchanski wrote: > >On Mon, 22 Nov 2004, Christopher Faylor wrote: > > > >> On Mon, Nov 22, 2004 at 12:46:46PM -0500, Igor Pechtchanski wrote: > >> >Can the code simply propagate the actual exit code

Re: [Patch] Fixing the PROCESS_DUP_HANDLE security hole.

2004-11-22 Thread Christopher Faylor
On Mon, Nov 22, 2004 at 01:36:45PM -0500, Igor Pechtchanski wrote: >On Mon, 22 Nov 2004, Christopher Faylor wrote: >>*I've also added an 'exitcode' field to _pinfo so that a Cygwin process >>*will set the error (sic) code in a UNIX fashion based on whether it is >>*exiting *due to a signal or with