Re: {Patch]: Giving access to pinfo after seteuid and exec

2003-09-26 Thread Corinna Vinschen
On Thu, Sep 25, 2003 at 09:47:48PM -0400, Pierre A. Humblet wrote: > This patch sets the _pinfo acl in order to allow access after > seteuid and exec. > > While looking at spawn.cc I also noticed oddities in pinfo related > error handling, and reworked them. I also restored impersonation in > cas

Re: [Patch] Recent security improvements breaks proftpd

2003-09-26 Thread Corinna Vinschen
On Thu, Sep 25, 2003 at 08:46:53PM -0400, Pierre A. Humblet wrote: > 2003-09-25 Pierre Humblet <[EMAIL PROTECTED]> > > * uinfo.cc (cygheap_user::init): Make sure the current user appears > in the default DACL. Rearrange to decrease the indentation levels. > Initialize the effec

Re: [Patch] Recent security improvements breaks proftpd

2003-09-26 Thread Corinna Vinschen
On Fri, Sep 26, 2003 at 02:53:28PM +0200, Corinna Vinschen wrote: > Btw., shouldn't that be > > SetTokenInformation (ptok, TokenDefaultDacl, pdacl, pAcl->AclSize) > ^ > instead o

Re: [Patch] Recent security improvements breaks proftpd

2003-09-26 Thread Igor Pechtchanski
On Fri, 26 Sep 2003, Corinna Vinschen wrote: > [snip] > > + char buf [1024]; > > In sec_acl.cc and security.cc, this buffer is named `acl_buf' and it's > size is 3072. Let's do it the same here. I've seen amazingly big ACLs > on NT4 once. Corinna, Just a quick note: doesn't the above call for

Re: [Patch] Recent security improvements breaks proftpd

2003-09-26 Thread Corinna Vinschen
On Fri, Sep 26, 2003 at 09:08:08AM -0400, Igor Pechtchanski wrote: > On Fri, 26 Sep 2003, Corinna Vinschen wrote: > > > [snip] > > > + char buf [1024]; > > > > In sec_acl.cc and security.cc, this buffer is named `acl_buf' and it's > > size is 3072. Let's do it the same here. I've seen amazingly

Re: [Patch] Recent security improvements breaks proftpd

2003-09-26 Thread Igor Pechtchanski
On Fri, 26 Sep 2003, Corinna Vinschen wrote: > On Fri, Sep 26, 2003 at 09:08:08AM -0400, Igor Pechtchanski wrote: > > On Fri, 26 Sep 2003, Corinna Vinschen wrote: > > > > > [snip] > > > > + char buf [1024]; > > > > > > In sec_acl.cc and security.cc, this buffer is named `acl_buf' and it's > > > s

Re: {Patch]: Giving access to pinfo after seteuid and exec

2003-09-26 Thread Pierre A. Humblet
Corinna Vinschen wrote: > > On Thu, Sep 25, 2003 at 09:47:48PM -0400, Pierre A. Humblet wrote: > > This patch sets the _pinfo acl in order to allow access after > > seteuid and exec. > > > > While looking at spawn.cc I also noticed oddities in pinfo related > > error handling, and reworked them. I

Re: [Patch] Recent security improvements breaks proftpd

2003-09-26 Thread Pierre A. Humblet
Corinna Vinschen wrote: > > On Fri, Sep 26, 2003 at 02:53:28PM +0200, Corinna Vinschen wrote: > > Btw., shouldn't that be > > > > SetTokenInformation (ptok, TokenDefaultDacl, pdacl, pAcl->AclSize) > > ^ > >

Re: [Patch] Recent security improvements breaks proftpd

2003-09-26 Thread Corinna Vinschen
On Fri, Sep 26, 2003 at 09:43:38AM -0400, Pierre A. Humblet wrote: > Corinna Vinschen wrote: > > > > On Fri, Sep 26, 2003 at 02:53:28PM +0200, Corinna Vinschen wrote: > > > Btw., shouldn't that be > > > > > > SetTokenInformation (ptok, TokenDefaultDacl, pdacl, pAcl->AclSize) > > >

Re: {Patch]: Giving access to pinfo after seteuid and exec

2003-09-26 Thread Corinna Vinschen
On Fri, Sep 26, 2003 at 09:41:17AM -0400, Pierre A. Humblet wrote: > Corinna Vinschen wrote: > > Somehow I'm missing a description why that's necessary and the > > implications. > > > I am getting paranoid. Most often we duplicate DUPLICATE_SAME_ACCESS > without thinking about what access is reall

Re: [Patch] Recent security improvements breaks proftpd

2003-09-26 Thread Pierre A. Humblet
Corinna Vinschen wrote: > > On Fri, Sep 26, 2003 at 09:43:38AM -0400, Pierre A. Humblet wrote: > > Corinna Vinschen wrote: > > > > > > On Fri, Sep 26, 2003 at 02:53:28PM +0200, Corinna Vinschen wrote: > > > > Btw., shouldn't that be > > > > > > > > SetTokenInformation (ptok, TokenDefaultDacl, pd

Turning pinfo security on

2003-09-26 Thread Pierre A. Humblet
Following Chris' new signal handling approach and the previous patch "Giving access to pinfo after seteuid and exec", we can now turn pinfo security on. It's just a matter of removing the FILE_MAP_WRITE permission for Everybody, and a couple of useless PID_MAP_WRITE in pinfo constructors. I have l

Re: Turning pinfo security on

2003-09-26 Thread Christopher Faylor
On Fri, Sep 26, 2003 at 10:17:00PM -0400, Pierre A. Humblet wrote: >Following Chris' new signal handling approach and the previous >patch "Giving access to pinfo after seteuid and exec", we can >now turn pinfo security on. > >It's just a matter of removing the FILE_MAP_WRITE permission for >Everybo

Re: [PATCH] Add support for ioctl TIOCLINUX, function 6 (get key modifiers) on a TTY

2003-09-26 Thread Christopher Faylor
On Fri, Aug 01, 2003 at 02:57:05AM +0200, Pavel Tsekov wrote: >2003-08-01 Pavel Tsekov <[EMAIL PROTECTED]> > > * fhandler_console.c (fhandler_console::read): Record the state of the > SHIFT, CTRL and ALT keys at the time of the last keyboard input event. > (fhandler_console::ioc

Re: Turning pinfo security on

2003-09-26 Thread Pierre A. Humblet
At 10:21 PM 9/26/2003 -0400, Christopher Faylor wrote: >On Fri, Sep 26, 2003 at 10:17:00PM -0400, Pierre A. Humblet wrote: >>Following Chris' new signal handling approach and the previous >>patch "Giving access to pinfo after seteuid and exec", we can >>now turn pinfo security on. >> >>It's just a

Re: Turning pinfo security on

2003-09-26 Thread Christopher Faylor
On Fri, Sep 26, 2003 at 10:36:05PM -0400, Pierre A. Humblet wrote: >BTW, now that your sigpacket includes the sending pid, the commune stuff >could be simplified and avoid calling winpids. It knows whom to talk >to (but it must still double check for security). Yeah. That's one of the reasons I a

Re: setmetamode

2003-09-26 Thread Christopher Faylor
On Tue, Aug 12, 2003 at 04:47:31PM +0200, Corinna Vinschen wrote: >On Mon, Jul 28, 2003 at 09:39:53AM +0900, Kazuhiro Fujieda wrote: >> >>> On Fri, 18 Jul 2003 19:10:54 +0200 >> >>> Corinna Vinschen <[EMAIL PROTECTED]> said: >> Umm. I can't find any reason why it doesn't work. >> I'd like to confir

Re: New program: cygtweak

2003-09-26 Thread Christopher Faylor
On Fri, Aug 16, 2002 at 03:42:21PM -0400, Igor Pechtchanski wrote: >I've tried submitting this twice before, and had gotten no reaction. I'm >trying to find out what the proper procedure is and which list should this >be sent to. I'd also like to discuss the appropriate name for this little >app,

Re: Implementation of sched_rr_get_interval for NT systems.

2003-09-26 Thread Christopher Faylor
[cleaning out my cygwin-patches backlog] On Thu, Feb 06, 2003 at 01:16:17PM +0100, Vaclav Haisman wrote: >2003-02-06 Vaclav Haisman <[EMAIL PROTECTED]> >* Makefile.in: Add libusr32.a to DLL_IMPORTS. >* wincap.h (wincaps::is_server): New flag. >(wincapc::version): Change ty