Re: [PATCH] Package content search and listing functionality for cygcheck

2003-08-15 Thread Corinna Vinschen
On Thu, Aug 14, 2003 at 03:30:44PM -0400, Igor Pechtchanski wrote: > This patch adds the functionality to cygcheck to list (using the "-l" or > "--list-package" flag) the contents of and search (using the "-f" or > "--find-package" flag and passing the absolute paths to the files) for > files in th

Re: [PATCH] Package content search and listing functionality for cygcheck

2003-08-15 Thread Igor Pechtchanski
Corinna, Thanks for the feedback. Replies inline below. On Fri, 15 Aug 2003, Corinna Vinschen wrote: > On Thu, Aug 14, 2003 at 03:30:44PM -0400, Igor Pechtchanski wrote: > > This patch adds the functionality to cygcheck to list (using the "-l" or > > "--list-package" flag) the contents of and s

Re: [PATCH] Package content search and listing functionality for cygcheck

2003-08-15 Thread Corinna Vinschen
On Fri, Aug 15, 2003 at 03:38:30PM -0400, Igor Pechtchanski wrote: > > On Cygwin: > > > > $ cygcheck -f /usr/bin/tcsh.exe > > /usr/bin/tcsh.exe: found in package tcsh-6.12.00-6 > > > > On Linux: > > > > $ rpm -qf /usr/bin/tcsh > > tcsh-6.12.00-134 > > > > Shouldn't we also just print the pa

Re: [PATCH] Package content search and listing functionality forcygcheck

2003-08-15 Thread Igor Pechtchanski
On Fri, 15 Aug 2003, Corinna Vinschen wrote: > On Fri, Aug 15, 2003 at 03:38:30PM -0400, Igor Pechtchanski wrote: > > > On Cygwin: > > > > > > $ cygcheck -f /usr/bin/tcsh.exe > > > /usr/bin/tcsh.exe: found in package tcsh-6.12.00-6 > > > > > > On Linux: > > > > > > $ rpm -qf /usr/bin/tcsh >

Re: [PATCH] Package content search and listing functionality for cygcheck

2003-08-15 Thread David Rothenberger
Corinna Vinschen wrote: > Thanks for the patch, it's really cool, I agree, very cool, Igor. Any chance the return in package_find() could be changed to continue? I went to try it out for /bin/ssh and found it didn't work because diffutils is missing the package list. I didn't think to even try

Re: [PATCH] Package content search and listing functionality forcygcheck

2003-08-15 Thread Igor Pechtchanski
On Fri, 15 Aug 2003, David Rothenberger wrote: > Corinna Vinschen wrote: > > Thanks for the patch, it's really cool, > > I agree, very cool, Igor. > > Any chance the return in package_find() could be changed to > continue? I went to try it out for /bin/ssh and found it didn't > work because diffu

Re: [PATCH] Package content search and listing functionality forcygcheck

2003-08-15 Thread David Rothenberger
Igor Pechtchanski wrote: Dave, Thanks for catching this -- this was a genuine bug. Thanks also for the patch, but I have another one in the pipeline that'll conflict with yours (). How about I just resubmit that patch with your changes i

Re: [PATCH] Package content search and listing functionality forcygcheck

2003-08-15 Thread Igor Pechtchanski
On Fri, 15 Aug 2003, David Rothenberger wrote: > Igor Pechtchanski wrote: > > Dave, > > > > Thanks for catching this -- this was a genuine bug. Thanks also for the > > patch, but I have another one in the pipeline that'll conflict with yours > > (

Re: [PATCH] Package content search and listing functionality forcygcheck

2003-08-15 Thread David Rothenberger
Igor Pechtchanski writes: > On Fri, 15 Aug 2003, David Rothenberger wrote: > > > I notice that package_list() prints a message in this case with the -v > > switch, but package_find() does not. My personal pref. is for the > > message, but I'll leave it to you to decide. > > > > Dave > >