Re: etc_changed, passwd & group.

2003-01-17 Thread Corinna Vinschen
On Fri, Jan 17, 2003 at 12:29:05AM -0500, Christopher Faylor wrote: > Maybe not so "less intrusive" after all. I broke out the etc handling > stuff into a separate class and moved even more functionality into > pwdgrp than you did. I hope Corinna approves. As long as it works it's ok with me. C

Re: etc_changed, passwd & group.

2003-01-17 Thread Pierre A. Humblet
> On Thu, Jan 16, 2003 at 02:07:18PM -0500, Christopher Faylor wrote: > >On Thu, Jan 16, 2003 at 01:57:21AM -0500, Pierre A. Humblet wrote: > >>Here is the code as it stands. It compiles & runs, and passes > >>fork tests correctly. Feel free to takeover or at least > >>have a look. I will continue

Re: etc_changed, passwd & group.

2003-01-17 Thread Christopher Faylor
On Fri, Jan 17, 2003 at 10:06:02AM -0500, Pierre A. Humblet wrote: >> On Thu, Jan 16, 2003 at 02:07:18PM -0500, Christopher Faylor wrote: >> >On Thu, Jan 16, 2003 at 01:57:21AM -0500, Pierre A. Humblet wrote: >> >>Here is the code as it stands. It compiles & runs, and passes >> >>fork tests correct

nanosleep() patch

2003-01-17 Thread Jason Tishler
Attached is a patch that implements nanosleep() by attempting to reuse the current sleep() implementation which seems to provide the necessary functionality. I'm not sure if there is a better way to convey the fact that sleep_worker() was interrupted than my current implementation. Comments on thi

Re: etc_changed, passwd & group

2003-01-17 Thread Pierre A. Humblet
Hello Chris, I like your code, just made a few changes. The explanations below are detailed and longer that the changes! In load(), CloseFile wasn't called on read error, and it was called before GetFileTime. It seems that declaring passwd_buf, group_buf etc NO_COPY means that there will be a m

Re: etc_changed, passwd & group

2003-01-17 Thread Pierre A. Humblet
Chris, An ugly tought came to my mind while doing the dishes: there is a race condition left. FindFirstChangeNotification must be called from init, otherwise in the normal case it will be called after the load, leaving a window where the file can be updated without being noticed. Similarly in the