Patch for Setup.exe problem and for mklink2.cc

2002-03-27 Thread Ton van Overbeek
Found the problem causing the segment violation and probably causing Jonas Eriksson's problem. It is a typical case of 'off by 1'. In PickView::set_headers the loop filling the window header does one iteration too much, resulting in a call to DoInsertItem with a NULL string pointer and hence a cra

RE: Patch for Setup.exe problem and for mklink2.cc

2002-03-27 Thread Robert Collins
> -Original Message- > From: Ton van Overbeek [mailto:[EMAIL PROTECTED]] > Sent: Thursday, March 28, 2002 1:03 AM > To: [EMAIL PROTECTED]; [EMAIL PROTECTED] > Cc: [EMAIL PROTECTED] > Subject: Patch for Setup.exe problem and for mklink2.cc > > > Found the problem causing the segment vi

Re: Patch for Setup.exe problem and for mklink2.cc

2002-03-27 Thread tvoverbe
Robert wrote: > I'll check the off-by-one fix in tomorrow, as I'm off to bed now. > > As for the &'s, I wonder if it's a w32api reference issue? The compiler > complains if they are present for me. For me it is the opposite. g++ complains when they are *not* present. The w32api include