RE: [PATCH] Setup.exe in a property sheet

2001-12-19 Thread Gary R. Van Sickle
> Ok, first glance: > > You've diffed across versions - please update both the clean dir and > your working dir for the next patch. Thats a major reason the patch is > so big. > > * please use win32 thread API calls, not _beginthread et al. I don't think we can do that, at least not everywhere.

Re: [PATCH] Setup.exe in a property sheet

2001-12-19 Thread Robert Collins
- Original Message - From: "Gary R. Van Sickle" <[EMAIL PROTECTED]> > I don't think we can do that, at least not everywhere. The threads call many > CRT functions, and MS warns you not to use CreateThread if you're using the CRT > in your thread. Note that the threads are now "backwards

Re: [PATCH] Setup.exe in a property sheet

2001-12-19 Thread Robert Collins
=== - Original Message - From: "Gary R. Van Sickle" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Wednesday, December 19, 2001 7:42 PM Subject: RE: [PATCH] Setup.exe in a property sheet > > Ok, first glance: > > > > You've diffed across versions - please update both the clean dir an

RE: [PATCH] Setup.exe in a property sheet

2001-12-19 Thread Gary R. Van Sickle
> From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]]On Behalf Of Robert Collins [snip] > Can you give me a reference? Last I recall, the comment from MS was the > _beginthread and _endthread leak memory and were deprecated. > The November Platform SDK says this under CreateThread(): "A threa

Re: [PATCH] Setup.exe in a property sheet

2001-12-19 Thread Robert Collins
- Original Message - From: "Gary R. Van Sickle" <[EMAIL PROTECTED]> > > It's known as the Big Three Rule. The rule is that if a object needs any > > one of the three (destructor, copy con, assignment) it needs all three. > > The destructor connection is because the _only_ time an object ne

Re: [PATCH] Update - Setup.exe property sheet patch, properly diffed.

2001-12-19 Thread Robert Collins
Ok, I'll get nitty-gritty now. ChangeLog presentation: :The changelog is formatted wrongly - you have extra lines. :When you have (foo): Did bar. (foo): Did barf. write it as (foo): Did bar. Did barf. :in the main entry you have a tab halfway through the line Regarding the patch: :Please remove

RE: [PATCH] Update - Setup.exe property sheet patch, properly diffed.

2001-12-19 Thread Gary R. Van Sickle
> From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]]On Behalf Of Robert Collins > Sent: Wednesday, December 19, 2001 5:30 AM > To: Gary R. Van Sickle; [EMAIL PROTECTED] > Subject: Re: [PATCH] Update - Setup.exe property sheet patch, properly > diffed. > > > Ok, I'll get nitty-gritty now. > > Cha

Re: [PATCH] Update - Setup.exe property sheet patch, properly diffed.

2001-12-19 Thread Robert Collins
=== - Original Message - From: "Gary R. Van Sickle" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Wednesday, December 19, 2001 11:20 PM Subject: RE: [PATCH] Update - Setup.exe property sheet patch, properly diffed. > > :lets assume that chooser will subsume choose, can you please make

RE: [PATCH] Update - Setup.exe property sheet patch, properly diffed.

2001-12-19 Thread Gary R. Van Sickle
[snip] > Ok. Well correct me if I'm wrong but the current chooser.h does the > following: > it's a property page of the main window > it call do_chooser. > > That's it (high level). All I'm suggesting is that until we know that we > will need a separate chooser (ie we won't just move choose.cc's

[PATCH] Update 2 - Setup.exe property sheet patch

2001-12-19 Thread Gary R. Van Sickle
Changes as per your (Rob) last email, plus a few other improvements. Diff, new files, and ChangeLog attached. -- Gary R. Van Sickle Brewer. Patriot. setup.diff.bz2 Description: Binary data setup-newfiles.tar.bz2 Description: Binary data setup.ChangeLog Description: Binary data