Re: mmap fixes

2024-12-19 Thread Ken Brown
On 12/19/2024 3:01 PM, Jon Turney wrote: On 19/12/2024 19:50, Ken Brown wrote: Maybe this has something to do with the way scallywag is invoked to do a build.  Jon, is the problem that I don't have a .gitconfig on sourceware?  In any case, I'm inclined to ignore this unless someone tells me I

Re: mmap fixes

2024-12-19 Thread Jon Turney
On 19/12/2024 19:50, Ken Brown wrote: On 12/19/2024 12:27 PM, Corinna Vinschen wrote: On Dec 19 11:19, Ken Brown wrote: I've pushed the two modified commits to both main and cygwin-3_5-branch. When I pushed to main, I got back the following message from git: remote:  Committer: Ken Brown remo

Re: mmap fixes

2024-12-19 Thread Ken Brown
On 12/19/2024 12:27 PM, Corinna Vinschen wrote: On Dec 19 11:19, Ken Brown wrote: I've pushed the two modified commits to both main and cygwin-3_5-branch. When I pushed to main, I got back the following message from git: remote: Committer: Ken Brown remote: Your name and email address were co

Re: mmap fixes

2024-12-19 Thread Corinna Vinschen
On Dec 19 11:19, Ken Brown wrote: > I've pushed the two modified commits to both main and cygwin-3_5-branch. > When I pushed to main, I got back the following message from git: > > remote: Committer: Ken Brown > remote: Your name and email address were configured automatically based > remote: on

Re: mmap fixes

2024-12-19 Thread Corinna Vinschen
On Dec 19 09:59, Ken Brown wrote: > Hi Corinna, > > On 12/19/2024 5:17 AM, Corinna Vinschen wrote: > > Fixes: c68de3a262fe5 ("* mmap.cc (class mmap_record): Declare new map_pages > > method with address parameter.") > > Again thanks. Some time you'll have to tell me how to find those commits.

Re: mmap fixes

2024-12-19 Thread Ken Brown
I've pushed the two modified commits to both main and cygwin-3_5-branch. When I pushed to main, I got back the following message from git: remote: Committer: Ken Brown remote: Your name and email address were configured automatically based remote: on your username and hostname. Please check t

Re: mmap fixes

2024-12-19 Thread Ken Brown
Hi Corinna, On 12/19/2024 5:17 AM, Corinna Vinschen wrote: Fixes: ?? Fixes: f90e23f2714cb ("*autoload.cc (NtCreateSection): Define.") Darn the old CVS entries... Thanks. I don't know how you found that. The patch looks good. I just wonder if the new argument should be called "new_prot"

Re: mmap fixes

2024-12-19 Thread Corinna Vinschen
Hi Ken, I'm replying to your "Fixes" question right here. On Dec 18 12:16, Ken Brown wrote: > The two attached patches fix the bugs reported in > > https://cygwin.com/pipermail/cygwin/2024-December/256911.html > > and > > https://cygwin.com/pipermail/cygwin/2024-December/256913.html > > Th

Re: mmap fixes

2024-12-18 Thread Ken Brown
On 12/18/2024 12:16 PM, Ken Brown wrote: The two attached patches fix the bugs reported in  https://cygwin.com/pipermail/cygwin/2024-December/256911.html and   https://cygwin.com/pipermail/cygwin/2024-December/256913.html The second one is still under discussion on the cygwin list and may t

mmap fixes

2024-12-18 Thread Ken Brown
The two attached patches fix the bugs reported in https://cygwin.com/pipermail/cygwin/2024-December/256911.html and https://cygwin.com/pipermail/cygwin/2024-December/256913.html The second one is still under discussion on the cygwin list and may turn out to be wrong. KenFrom a8ce46ae4353