Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-20 Thread Takashi Yano
On Mon, 20 Jan 2025 12:38:24 +0100 Corinna Vinschen wrote: > On Jan 20 18:08, Takashi Yano wrote: > > On Mon, 20 Jan 2025 00:33:26 +0900 > > Takashi Yano wrote: > > > On Sun, 19 Jan 2025 09:40:14 +0900 > > > Takashi Yano wrote: > > > > However, I wonder if cw_timer is re-set by NtSetTimer() in the

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-20 Thread Takashi Yano
On Mon, 20 Jan 2025 12:43:07 +0100 Corinna Vinschen wrote: > On Jan 19 19:42, Takashi Yano wrote: > > Hi Corinna, > > > > On Sun, 19 Jan 2025 11:49:58 +0900 > > Takashi Yano wrote: > > > On Sat, 18 Jan 2025 17:06:50 -0800 (PST) > > > Jeremy Drake wrote: > > > > On Sat, 18 Jan 2025, Takashi Yano wr

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-20 Thread Corinna Vinschen
On Jan 19 19:42, Takashi Yano wrote: > Hi Corinna, > > On Sun, 19 Jan 2025 11:49:58 +0900 > Takashi Yano wrote: > > On Sat, 18 Jan 2025 17:06:50 -0800 (PST) > > Jeremy Drake wrote: > > > On Sat, 18 Jan 2025, Takashi Yano wrote: > > > > > > > While debugging this problem, I encountered another han

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-20 Thread Corinna Vinschen
On Jan 20 18:08, Takashi Yano wrote: > On Mon, 20 Jan 2025 00:33:26 +0900 > Takashi Yano wrote: > > On Sun, 19 Jan 2025 09:40:14 +0900 > > Takashi Yano wrote: > > > However, I wonder if cw_timer is re-set by NtSetTimer() in the > > > cygwait(), it will be set to WSSC (60 sec) (or 10msec) in the > >

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-20 Thread Takashi Yano
On Mon, 20 Jan 2025 00:33:26 +0900 Takashi Yano wrote: > On Sun, 19 Jan 2025 09:40:14 +0900 > Takashi Yano wrote: > > On Sat, 18 Jan 2025 20:41:37 +0900 > > Takashi Yano wrote: > > > On Fri, 17 Jan 2025 18:52:41 +0900 > > > Takashi Yano wrote: > > > > On Wed, 8 Jan 2025 18:05:53 -0800 (PST) > > > >

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-19 Thread Takashi Yano
On Sun, 19 Jan 2025 09:40:14 +0900 Takashi Yano wrote: > On Sat, 18 Jan 2025 20:41:37 +0900 > Takashi Yano wrote: > > On Fri, 17 Jan 2025 18:52:41 +0900 > > Takashi Yano wrote: > > > On Wed, 8 Jan 2025 18:05:53 -0800 (PST) > > > Jeremy Drake wrote: > > > > On Thu, 9 Jan 2025, Takashi Yano wrote: >

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-19 Thread Takashi Yano
Hi Corinna, On Sun, 19 Jan 2025 11:49:58 +0900 Takashi Yano wrote: > On Sat, 18 Jan 2025 17:06:50 -0800 (PST) > Jeremy Drake wrote: > > On Sat, 18 Jan 2025, Takashi Yano wrote: > > > > > While debugging this problem, I encountered another hang issue, > > > which is fixed by: > > > 0001-Cygwin-sig

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-19 Thread Takashi Yano
On Sat, 18 Jan 2025 19:24:51 -0800 (PST) Jeremy Drake wrote: > On Sun, 19 Jan 2025, Takashi Yano wrote: > > > Thanks for pointing out this. You are right if othre threads may > > set current_sig to non-zero value. Current cygwin sets current_sig > > to non-zero only in > > _cygtls::interrupt_set

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Jeremy Drake via Cygwin-patches
On Sun, 19 Jan 2025, Takashi Yano wrote: > Thanks for pointing out this. You are right if othre threads may > set current_sig to non-zero value. Current cygwin sets current_sig > to non-zero only in > _cygtls::interrupt_setup() > and > _cygtls::handle_SIGCONT() > both are called from sigpacket::pr

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Takashi Yano
On Sat, 18 Jan 2025 17:06:50 -0800 (PST) Jeremy Drake wrote: > On Sat, 18 Jan 2025, Takashi Yano wrote: > > > While debugging this problem, I encountered another hang issue, > > which is fixed by: > > 0001-Cygwin-signal-Avoid-frequent-tls-lock-unlock-for-SIG.patch > > I'm concerned about this pat

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Jeremy Drake via Cygwin-patches
On Sat, 18 Jan 2025, Takashi Yano wrote: > While debugging this problem, I encountered another hang issue, > which is fixed by: > 0001-Cygwin-signal-Avoid-frequent-tls-lock-unlock-for-SIG.patch I'm concerned about this patch. There's a window where current_sig could be changed after exiting the

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Takashi Yano
On Sat, 18 Jan 2025 20:41:37 +0900 Takashi Yano wrote: > On Fri, 17 Jan 2025 18:52:41 +0900 > Takashi Yano wrote: > > On Wed, 8 Jan 2025 18:05:53 -0800 (PST) > > Jeremy Drake wrote: > > > On Thu, 9 Jan 2025, Takashi Yano wrote: > > > > > > > On Wed, 8 Jan 2025 16:48:41 +0100 > > > > Corinna Vinsch

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Takashi Yano
On Fri, 17 Jan 2025 18:52:41 +0900 Takashi Yano wrote: > On Wed, 8 Jan 2025 18:05:53 -0800 (PST) > Jeremy Drake wrote: > > On Thu, 9 Jan 2025, Takashi Yano wrote: > > > > > On Wed, 8 Jan 2025 16:48:41 +0100 > > > Corinna Vinschen wrote: > > > > Does this patch fix Bruno's bash issue as well? > > >

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Takashi Yano
On Sat, 18 Jan 2025 20:41:37 +0900 Takashi Yano wrote: > On Fri, 17 Jan 2025 18:52:41 +0900 > Takashi Yano wrote: > > On Wed, 8 Jan 2025 18:05:53 -0800 (PST) > > Jeremy Drake wrote: > > > On Thu, 9 Jan 2025, Takashi Yano wrote: > > > > > > > On Wed, 8 Jan 2025 16:48:41 +0100 > > > > Corinna Vinsch

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Takashi Yano
On Sat, 18 Jan 2025 20:41:37 +0900 Takashi Yano wrote: > On Fri, 17 Jan 2025 18:52:41 +0900 > Takashi Yano wrote: > > On Wed, 8 Jan 2025 18:05:53 -0800 (PST) > > Jeremy Drake wrote: > > > On Thu, 9 Jan 2025, Takashi Yano wrote: > > > > > > > On Wed, 8 Jan 2025 16:48:41 +0100 > > > > Corinna Vinsch

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Takashi Yano
On Sat, 18 Jan 2025 10:58:34 -0800 (PST) Jeremy Drake wrote: > On Sat, 18 Jan 2025, Takashi Yano wrote: > > > Jeremy, > > could you please apply the attached patches: > > 0001-Cygwin-signal-Avoid-frequent-tls-lock-unlock-for-SIG.patch > > 0003-Cygwin-signal-Do-not-handle-signal-when-__SIGFLUSHFA.p

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Jeremy Drake via Cygwin-patches
On Sat, 18 Jan 2025, Takashi Yano wrote: > Jeremy, > could you please apply the attached patches: > 0001-Cygwin-signal-Avoid-frequent-tls-lock-unlock-for-SIG.patch > 0003-Cygwin-signal-Do-not-handle-signal-when-__SIGFLUSHFA.patch > against cygwin-3_5-branch and test if these fix the issue? I open

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Takashi Yano
On Sat, 18 Jan 2025 20:41:37 +0900 Takashi Yano wrote: > On Fri, 17 Jan 2025 18:52:41 +0900 > Takashi Yano wrote: > > On Wed, 8 Jan 2025 18:05:53 -0800 (PST) > > Jeremy Drake wrote: > > > On Thu, 9 Jan 2025, Takashi Yano wrote: > > > > > > > On Wed, 8 Jan 2025 16:48:41 +0100 > > > > Corinna Vinsch

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Takashi Yano
On Fri, 17 Jan 2025 18:52:41 +0900 Takashi Yano wrote: > On Wed, 8 Jan 2025 18:05:53 -0800 (PST) > Jeremy Drake wrote: > > On Thu, 9 Jan 2025, Takashi Yano wrote: > > > > > On Wed, 8 Jan 2025 16:48:41 +0100 > > > Corinna Vinschen wrote: > > > > Does this patch fix Bruno's bash issue as well? > > >

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-17 Thread Takashi Yano
On Wed, 8 Jan 2025 18:05:53 -0800 (PST) Jeremy Drake wrote: > On Thu, 9 Jan 2025, Takashi Yano wrote: > > > On Wed, 8 Jan 2025 16:48:41 +0100 > > Corinna Vinschen wrote: > > > Does this patch fix Bruno's bash issue as well? > > > > I'm not sure because it is not reproducible as he said. > > I also

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-09 Thread Jeremy Drake via Cygwin-patches
On Thu, 9 Jan 2025, Corinna Vinschen wrote: > Hi Jeremy, > > Can you perhaps bisect 3.5.5 to tell us which signal-related patch > exactly has introduced this specific hang? It may give us a clue. I believe Johannes was planning to do this, after holidays/vacation. It seems that Git for Windows'

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-09 Thread Corinna Vinschen
Hi Jeremy, On Jan 8 18:05, Jeremy Drake via Cygwin-patches wrote: > On Thu, 9 Jan 2025, Takashi Yano wrote: > > > On Wed, 8 Jan 2025 16:48:41 +0100 > > Corinna Vinschen wrote: > > > Does this patch fix Bruno's bash issue as well? > > > > I'm not sure because it is not reproducible as he said. >

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-08 Thread Jeremy Drake via Cygwin-patches
On Thu, 9 Jan 2025, Takashi Yano wrote: > On Wed, 8 Jan 2025 16:48:41 +0100 > Corinna Vinschen wrote: > > Does this patch fix Bruno's bash issue as well? > > I'm not sure because it is not reproducible as he said. > I also could not reproduce that. > > However, at least this fixes the issue that J

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-08 Thread Takashi Yano
On Wed, 8 Jan 2025 16:48:41 +0100 Corinna Vinschen wrote: > On Dec 23 10:33, Takashi Yano wrote: > > After the commit d243e51ef1d3, zsh sometimes hangs at startup. This > > occurs because SIGCHLD, which should trigger sigsuspend(), is handled > > in cygwait() that is used to wait for a wakeup event

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-08 Thread Corinna Vinschen
On Dec 23 10:33, Takashi Yano wrote: > After the commit d243e51ef1d3, zsh sometimes hangs at startup. This > occurs because SIGCHLD, which should trigger sigsuspend(), is handled > in cygwait() that is used to wait for a wakeup event in sig_send(), > even when __SIGFLUSHFAST is sent. Despite __SIGF