On Jan 18 18:07, Ben wrote:
>
>
> On 18-01-2021 13:13, Corinna Vinschen via Cygwin-patches wrote:
> >
> > Your code is skipping the safety checks and the has_dot_last_component()
> > check. The latter implements a check required by POSIX. Skipping
> > it introduces an incompatibility, see man
On 18-01-2021 18:07, Ben wrote:
>
> Have I missed something else?
>
Alright, I now see unlink uses isproc_dev and rmdir uses isdev_dev.
Is this correct?
Why are files and directories handled differently?
Anyway, I will add isdev_dev to the new unlink_nt
Ben...
On 18-01-2021 13:13, Corinna Vinschen via Cygwin-patches wrote:
>
> Your code is skipping the safety checks and the has_dot_last_component()
> check. The latter implements a check required by POSIX. Skipping
> it introduces an incompatibility, see man 2 rmdir.
>
Yes, I missed has_dot_last_c
On Jan 15 14:45, Ben Wijen wrote:
> Speedup deletion of directories.
> ---
> winsup/cygwin/dir.cc | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/winsup/cygwin/dir.cc b/winsup/cygwin/dir.cc
> index f912a9e47..2e7da3638 100644
> --- a/winsup/cygwin/dir.cc
> +++ b/winsup/cygwin/dir.c
