Re: [PATCH] Cygwin: Provide more COM devices

2019-12-15 Thread Achim Gratz
Brian Inglis writes: > On 2019-12-14 11:38, Achim Gratz wrote: > > [Sorry, thought I'd sent this, it was backgrounded!] > > What are the distinctions between /dev/sd[a-c][a-z], /dev/sdd[a-z], and > /dev/sd[a-z] appearing in parts of devices.cc? /dev/sd is the base name for disks, letters denote di

Re: [PATCH] Cygwin: Provide more COM devices

2019-12-15 Thread Brian Inglis
On 2019-12-14 11:38, Achim Gratz wrote: [Sorry, thought I'd sent this, it was backgrounded!] What are the distinctions between /dev/sd[a-c][a-z], /dev/sdd[a-z], and /dev/sd[a-z] appearing in parts of devices.cc? s[6] == 'd'? Better: > if (len > 7 && len < 12 && s[7] == 'd' - if (len > 7 &&

Re: [PATCH] Cygwin: Provide more COM devices

2019-12-15 Thread Achim Gratz
Brian Inglis writes: > On 2019-12-14 11:38, Achim Gratz wrote: > > s[6] == 'd'? Indeed. >> if (len > 7 && len < 12 && s[7] == 'd' > - if (len > 7 && len < 12 && s[7] == 'd' > + if (len > 7 && len < 12 && s[DP_LEN - 1] == 'd' Yes, that's better. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46

Re: [PATCH] Cygwin: Provide more COM devices

2019-12-14 Thread Brian Inglis
On 2019-12-14 11:38, Achim Gratz wrote: s[6] == 'd'? > if (len > 7 && len < 12 && s[7] == 'd' - if (len > 7 && len < 12 && s[7] == 'd' + if (len > 7 && len < 12 && s[DP_LEN - 1] == 'd' > /* Generic check for /dev/sd[a-z] prefix */ > && strncmp (s, DISK_PREFIX, DP_LEN) == 0 >

Re: [PATCH] Cygwin: Provide more COM devices

2019-12-14 Thread Achim Gratz
Achim Gratz writes: > Corinna Vinschen writes: > […] >> ttyS%(0-255) takes another 23K btw. Even that should be ok, if >> the need arises. Alternatively we could shortcut shilka as for >> /dev/sd*, but that involved much bigger numbers. > > I've searched for some documentation (anywhere the glob

Re: [PATCH] Cygwin: Provide more COM devices

2019-11-04 Thread Corinna Vinschen
On Nov 3 20:13, Achim Gratz wrote: > Corinna Vinschen writes: > […] > > ttyS%(0-255) takes another 23K btw. Even that should be ok, if > > the need arises. Alternatively we could shortcut shilka as for > > /dev/sd*, but that involved much bigger numbers. > > I've searched for some documentation

Re: [PATCH] Cygwin: Provide more COM devices

2019-11-03 Thread Achim Gratz
Corinna Vinschen writes: […] > ttyS%(0-255) takes another 23K btw. Even that should be ok, if > the need arises. Alternatively we could shortcut shilka as for > /dev/sd*, but that involved much bigger numbers. I've searched for some documentation (anywhere the glob syntax %(1-128) would turn up,

Re: [PATCH] Cygwin: Provide more COM devices

2019-10-23 Thread Corinna Vinschen
On Oct 22 19:52, Achim Gratz wrote: > > As requested: > > >From 7908d09f547e0a7a707139d0faaccc151b88024c Mon Sep 17 00:00:00 2001 > From: Achim Gratz > Date: Tue, 22 Oct 2019 19:50:50 +0200 > Subject: [PATCH] Cygwin: provide more COM devices > > * winsup/cygwin/devices.in: Provide for 128 COM d

Re: [PATCH] Cygwin: Provide more COM devices

2019-10-22 Thread Achim Gratz
As requested: >From 7908d09f547e0a7a707139d0faaccc151b88024c Mon Sep 17 00:00:00 2001 From: Achim Gratz Date: Tue, 22 Oct 2019 19:50:50 +0200 Subject: [PATCH] Cygwin: provide more COM devices * winsup/cygwin/devices.in: Provide for 128 COM devices since Windows likes to create lots of these

Re: [PATCH] Cygwin: Provide more COM devices

2019-10-22 Thread Corinna Vinschen
On Oct 22 19:36, Achim Gratz wrote: > Corinna Vinschen writes: > >> So how about we only do this on 64bit as an added bonus for folks who > >> "get it"? > > > > I'm not hot on doing that, and I'm not sure shilka likes ifdef's > > inside the %% block. > > OK, then let's forget about that. > > >> O

Re: [PATCH] Cygwin: Provide more COM devices

2019-10-22 Thread Achim Gratz
Corinna Vinschen writes: >> So how about we only do this on 64bit as an added bonus for folks who >> "get it"? > > I'm not hot on doing that, and I'm not sure shilka likes ifdef's > inside the %% block. OK, then let's forget about that. >> One particular machine I've recently worked on presented

Re: [PATCH] Cygwin: Provide more COM devices

2019-10-22 Thread Corinna Vinschen
On Oct 21 20:10, Achim Gratz wrote: > Corinna Vinschen writes: > > That's not the right way to patch this. devices.cc gets generated from > > devices.in by the gendevices script which in turn calls shilka from the > > cocom package. > > Now that you mention it I remember… :-( > > > Apart from t

Re: [PATCH] Cygwin: Provide more COM devices

2019-10-21 Thread Achim Gratz
Corinna Vinschen writes: > That's not the right way to patch this. devices.cc gets generated from > devices.in by the gendevices script which in turn calls shilka from the > cocom package. Now that you mention it I remember… :-( > Apart from the struct members you added here, it will > also add

Re: [PATCH] Cygwin: Provide more COM devices

2019-10-21 Thread Corinna Vinschen
Hi Achim, On Oct 20 15:27, Achim Gratz wrote: > > This was requested on IRC. > > >From a80b1c9ba67f94237948e85ad2dee744cdfbdcad Mon Sep 17 00:00:00 2001 > From: Achim Gratz > Date: Sun, 20 Oct 2019 15:23:04 +0200 > Subject: [PATCH] Cygwin: provide more COM devices > > * winsup/cygwin/devices.c