Re: [PATCH] Add fenv.h and support.

2010-09-11 Thread Dave Korn
On 11/09/2010 12:17, Corinna Vinschen wrote: > On Sep 11 12:22, Dave Korn wrote: >> How's this look? >> >> winsup/doc/ChangeLog: >> >> * new-features.sgml: Mention fenv support. > > I would remove the opengroup link and just keep the gnu C lib one, > but other than that it looks good. S

Re: [PATCH] Add fenv.h and support.

2010-09-11 Thread Corinna Vinschen
On Sep 11 12:22, Dave Korn wrote: > On 11/09/2010 09:09, Corinna Vinschen wrote: > > Hi Dave, > > Morning! > > > On Sep 11 08:11, Dave Korn wrote: > >> So, I ended up committing it like so: > > > > Can you please add some words to doc/new-features.sgml? > > How's this look? > > winsup/doc/

Re: [PATCH] Add fenv.h and support.

2010-09-11 Thread Dave Korn
On 11/09/2010 09:09, Corinna Vinschen wrote: > Hi Dave, Morning! > On Sep 11 08:11, Dave Korn wrote: >> So, I ended up committing it like so: > > Can you please add some words to doc/new-features.sgml? How's this look? winsup/doc/ChangeLog: * new-features.sgml: Mention fenv suppor

Re: [PATCH] Add fenv.h and support.

2010-09-11 Thread Corinna Vinschen
Hi Dave, On Sep 11 08:11, Dave Korn wrote: > On 11/09/2010 06:10, Christopher Faylor wrote: > > On Sat, Sep 11, 2010 at 01:42:49AM +0100, Dave Korn wrote: > >> On 10/09/2010 22:43, Christopher Faylor wrote: > >> > >>> Looks nice to me with one HUGE caveat: Please maintain the pseudo-sorted > >>>

Re: [PATCH] Add fenv.h and support.

2010-09-10 Thread Dave Korn
On 11/09/2010 06:10, Christopher Faylor wrote: > On Sat, Sep 11, 2010 at 01:42:49AM +0100, Dave Korn wrote: >> On 10/09/2010 22:43, Christopher Faylor wrote: >> >>> Looks nice to me with one HUGE caveat: Please maintain the pseudo-sorted >>> order in cygwin.din. Sorry to have to impose this burde

Re: [PATCH] Add fenv.h and support.

2010-09-10 Thread Christopher Faylor
On Sat, Sep 11, 2010 at 01:42:49AM +0100, Dave Korn wrote: >On 10/09/2010 22:43, Christopher Faylor wrote: > >> Looks nice to me with one HUGE caveat: Please maintain the pseudo-sorted >> order in cygwin.din. Sorry to have to impose this burden on you. > > No, that's fine; I've never been sure w

Re: [PATCH] Add fenv.h and support.

2010-09-10 Thread Dave Korn
On 10/09/2010 22:43, Christopher Faylor wrote: > Looks nice to me with one HUGE caveat: Please maintain the pseudo-sorted > order in cygwin.din. Sorry to have to impose this burden on you. No, that's fine; I've never been sure whether we need to care about the ordinal numbers or not in that f

Re: [PATCH] Add fenv.h and support.

2010-09-10 Thread Christopher Faylor
On Fri, Sep 10, 2010 at 09:53:28PM +0100, Dave Korn wrote: > > >Hi folks, > > This patch adds fenv.h and the related support routines in the Cygwin DLL. >It's an entirely unencumbered implementation that I wrote from scratch using >only the public docs for reference. We've been missing this f