RE: [EXTERNAL] Re: [PATCH 2/7] Use matching format for NTSTATUS

2022-01-15 Thread Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches
> Just the suggestion that as all standards support using %#08x to prefix > with 0x (prefix output capitalization follows format letter > capitalization) and would be preferable to hacking the text 0x onto the > format %08X, doing all of the formatting work with the format flags. First off, I am p

Re: [EXTERNAL] Re: [PATCH 2/7] Use matching format for NTSTATUS

2022-01-15 Thread Brian Inglis
Just the suggestion that as all standards support using %#08x to prefix with 0x (prefix output capitalization follows format letter capitalization) and would be preferable to hacking the text 0x onto the format %08X, doing all of the formatting work with the format flags. My awareness and atti

RE: [EXTERNAL] Re: [PATCH 2/7] Use matching format for NTSTATUS

2022-01-15 Thread Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches
So? With %X (capital X) the alternate form has the prefix 0X capital, too; and it's really hard to read. IDK what is exactly your point that you are trying to make, is my patch somehow incorrect, or what? Anton Lavrentiev Contractor NIH/NLM/NCBI > -Original Message- > From: Brian Ingl