Re: [PATCH] Setup.exe in a property sheet

2001-12-19 Thread Robert Collins
- Original Message - From: "Gary R. Van Sickle" <[EMAIL PROTECTED]> > > It's known as the Big Three Rule. The rule is that if a object needs any > > one of the three (destructor, copy con, assignment) it needs all three. > > The destructor connection is because the _only_ time an object ne

RE: [PATCH] Setup.exe in a property sheet

2001-12-19 Thread Gary R. Van Sickle
> From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]]On Behalf Of Robert Collins [snip] > Can you give me a reference? Last I recall, the comment from MS was the > _beginthread and _endthread leak memory and were deprecated. > The November Platform SDK says this under CreateThread(): "A threa

Re: [PATCH] Setup.exe in a property sheet

2001-12-19 Thread Robert Collins
=== - Original Message - From: "Gary R. Van Sickle" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Wednesday, December 19, 2001 7:42 PM Subject: RE: [PATCH] Setup.exe in a property sheet > > Ok, first glance: > > > > You've diffed acros

Re: [PATCH] Setup.exe in a property sheet

2001-12-19 Thread Robert Collins
- Original Message - From: "Gary R. Van Sickle" <[EMAIL PROTECTED]> > I don't think we can do that, at least not everywhere. The threads call many > CRT functions, and MS warns you not to use CreateThread if you're using the CRT > in your thread. Note that the threads are now "backwards

RE: [PATCH] Setup.exe in a property sheet

2001-12-19 Thread Gary R. Van Sickle
> Ok, first glance: > > You've diffed across versions - please update both the clean dir and > your working dir for the next patch. Thats a major reason the patch is > so big. > > * please use win32 thread API calls, not _beginthread et al. I don't think we can do that, at least not everywhere.

Re: [PATCH] Setup.exe in a property sheet

2001-12-18 Thread Robert Collins
Ok, first glance: You've diffed across versions - please update both the clean dir and your working dir for the next patch. Thats a major reason the patch is so big. * please use win32 thread API calls, not _beginthread et al. * All classes with an explicit destructor need copy constructors and