Re: Part 2 of Fixing a security hole in pinfo.

2003-09-16 Thread Corinna Vinschen
On Mon, Sep 15, 2003 at 09:01:52PM -0400, Pierre A. Humblet wrote: > There is also a change I'd like to make eventually: the original_sid > and the sid are cmalloc'ed. As they have a fixed size and every process > needs them, we might as well make them cygsid's in the user structure. > That would b

Re: Part 2 of Fixing a security hole in pinfo.

2003-09-15 Thread Pierre A. Humblet
At 10:03 AM 9/15/2003 +0200, you wrote: >On Sat, Sep 13, 2003 at 10:30:55PM -0400, Christopher Faylor wrote: >> On Sat, Sep 13, 2003 at 10:07:42PM -0400, Pierre A. Humblet wrote: >> >This is the second and final part of the pinfo security patch. >> >> Looks like a Corinna yea or nay on this one.

Re: Part 2 of Fixing a security hole in pinfo.

2003-09-15 Thread Corinna Vinschen
On Sat, Sep 13, 2003 at 10:30:55PM -0400, Christopher Faylor wrote: > On Sat, Sep 13, 2003 at 10:07:42PM -0400, Pierre A. Humblet wrote: > >This is the second and final part of the pinfo security patch. > > Looks like a Corinna yea or nay on this one. The changes look good. Please apply, Pierre

Re: Part 2 of Fixing a security hole in pinfo.

2003-09-13 Thread Christopher Faylor
On Sat, Sep 13, 2003 at 10:07:42PM -0400, Pierre A. Humblet wrote: >This is the second and final part of the pinfo security patch. Looks like a Corinna yea or nay on this one. I am going to be checking in *all* of my stuff soon, including the long promised device reorg that I started back in Dec

[Oops] Part 2 of Fixing a security hole in pinfo.

2003-09-13 Thread Pierre A. Humblet
Here is the patch. Index: security.h === RCS file: /cvs/src/src/winsup/cygwin/security.h,v retrieving revision 1.44 diff -u -p -r1.44 security.h --- security.h 10 Sep 2003 02:12:25 - 1.44 +++ security.h 13 Sep 2003 21:29:56

Part 2 of Fixing a security hole in pinfo.

2003-09-13 Thread Pierre A. Humblet
This is the second and final part of the pinfo security patch. It creates the _pinfo mapping with appropriate security attributes. They temporarily still give write access to Everyone, until Chris releases his new method for children to signal their parents. However things are not that simple.