Re: [Patch] "strace ./app.exe" probably runs application from /bin

2007-06-03 Thread Christopher Faylor
On Sat, Jun 02, 2007 at 04:28:34PM -0700, Brian Dessent wrote: >Christopher Faylor wrote: > >> Let me rephrase the problem: >> >> "cygpath does not properly deal with the current directory" >> >> Thanks for the patch but we won't be applying it in this form. > >I've been meaning to take a look at

Re: [Patch] "strace ./app.exe" probably runs application from /bin

2007-06-03 Thread Christopher Faylor
On Sun, Jun 03, 2007 at 06:21:12PM +0200, Christian Franke wrote: > The attached patch is a quick hack (again, sorry ;-) to fix this. Was I too polite in my previous refusal of a "quick hack"? cgf

Re: [Patch] "strace ./app.exe" probably runs application from /bin

2007-06-03 Thread Christian Franke
Brian Dessent wrote: Christopher Faylor wrote: Let me rephrase the problem: "cygpath does not properly deal with the current directory" Thanks for the patch but we won't be applying it in this form. I've been meaning to take a look at fixing this myself, because I'm tired of: $ cd

Re: [Patch] "strace ./app.exe" probably runs application from /bin

2007-06-03 Thread Christian Franke
cygcheck is also affected by the same issue like strace: $ cd /tmp $ cygcheck ./ls C:\cygwin\bin\ls.exe ... $ cygcheck ././ls ls - cannot open. The attached patch fixes this for strace and cygcheck. It does not fix the cygcheck issue reported by Brian. All other calls to path.cc:cygpath() us

Re: [Patch] "strace ./app.exe" probably runs application from /bin

2007-06-02 Thread Brian Dessent
Christopher Faylor wrote: > Let me rephrase the problem: > > "cygpath does not properly deal with the current directory" > > Thanks for the patch but we won't be applying it in this form. I've been meaning to take a look at fixing this myself, because I'm tired of: $ cd /usr/bin $ cygcheck ./

Re: [Patch] "strace ./app.exe" probably runs application from /bin

2007-06-02 Thread Christian Franke
Christopher Faylor wrote: ... Thanks for the problem report and test case but this is pretty clearly not the right way to deal with the issue. Putting a special case catch of "./" around a function call which is intended to deal with paths is pretty clearly a band-aid. Yes. Let me re

Re: [Patch] "strace ./app.exe" probably runs application from /bin

2007-06-02 Thread Christopher Faylor
On Sat, Jun 02, 2007 at 04:51:31PM +0200, Christian Franke wrote: >Running an application with strace from current directory may not work >as expected. >The "./" is not passed to CreateProcess() and the default app search >rules apply >(1. strace.exe directory, 2. cwd, ..., 6. PATH) > >Therefore

[Patch] "strace ./app.exe" probably runs application from /bin

2007-06-02 Thread Christian Franke
Running an application with strace from current directory may not work as expected. The "./" is not passed to CreateProcess() and the default app search rules apply (1. strace.exe directory, 2. cwd, ..., 6. PATH) Therefore, an old version of the same app already installed in /bin may be run i