Re: [PATCH v6 2/3] Cygwin: cygwait: Make cygwait() reentrant

2025-01-21 Thread Takashi Yano
On Tue, 21 Jan 2025 10:00:23 -0800 (PST) Jeremy Drake wrote: > Not important, but > > On Tue, 21 Jan 2025, Takashi Yano wrote: > > > + if (!_my_tls.locals.cw_timer_inuse) > > + _my_tls.locals.cw_timer_inuse = true; > > Couldn't you leave the if out? That's right, I'm aware of that, but I

Re: [PATCH v6 2/3] Cygwin: cygwait: Make cygwait() reentrant

2025-01-21 Thread Jeremy Drake via Cygwin-patches
Not important, but On Tue, 21 Jan 2025, Takashi Yano wrote: > + if (!_my_tls.locals.cw_timer_inuse) > + _my_tls.locals.cw_timer_inuse = true; Couldn't you leave the if out?

[PATCH v6 2/3] Cygwin: cygwait: Make cygwait() reentrant

2025-01-20 Thread Takashi Yano
To allow cygwait() to be called in the signal handler, a locally created timer is used instead of _cygtls::locals.cw_timer if it is in use. Co-Authored-By: Corinna Vinschen Signed-off-by: Takashi Yano --- winsup/cygwin/cygtls.cc | 2 ++ winsup/cygwin/cygwait.cc | 22