Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sep 11 11:05, Corinna Vinschen wrote: > On Sep 10 21:34, Takashi Yano via Cygwin-patches wrote: > > On Thu, 10 Sep 2020 09:15:00 +0900 > > Takashi Yano via Cygwin-patches wrote: > > > I'd propose the patch: > > > > > > diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sep 10 21:34, Takashi Yano via Cygwin-patches wrote: > On Thu, 10 Sep 2020 09:15:00 +0900 > Takashi Yano via Cygwin-patches wrote: > > I'd propose the patch: > > > > diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc > > index 37d033bbe..95b28c3da 100644 > > --- a/winsu

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Thu, 10 Sep 2020 23:16:10 +0900 Takashi Yano wrote: > On Thu, 10 Sep 2020 16:04:07 +0200 > Corinna Vinschen wrote: > > > Hi Takashi, > > > > On Sep 10 09:15, Takashi Yano via Cygwin-patches wrote: > > > On Wed, 9 Sep 2020 09:21:23 +0200 > > > Corinna Vinschen wrote: > > > > Takashi, does the

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Thu, 10 Sep 2020 16:04:07 +0200 Corinna Vinschen wrote: > Hi Takashi, > > On Sep 10 09:15, Takashi Yano via Cygwin-patches wrote: > > On Wed, 9 Sep 2020 09:21:23 +0200 > > Corinna Vinschen wrote: > > > Takashi, does the patch from > > > https://cygwin.com/pipermail/cygwin-developers/2020-Augus

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Takashi, On Sep 10 09:15, Takashi Yano via Cygwin-patches wrote: > On Wed, 9 Sep 2020 09:21:23 +0200 > Corinna Vinschen wrote: > > Takashi, does the patch from > > https://cygwin.com/pipermail/cygwin-developers/2020-August/011951.html > > still apply to the latest from master? Question is, sho

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Tue, 8 Sep 2020 18:45:36 +0900 Takashi Yano via Cygwin-patches wrote: > Hi Corinna, > > On Tue, 8 Sep 2020 10:40:34 +0200 > Corinna Vinschen wrote: > > On Sep 7 13:45, Takashi Yano via Cygwin-patches wrote: > > > On Mon, 7 Sep 2020 01:04:13 +0900 > > > > > Chages: > > > > > - If global local

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Thu, 10 Sep 2020 09:15:00 +0900 Takashi Yano via Cygwin-patches wrote: > Hi Corinna, > > On Wed, 9 Sep 2020 09:21:23 +0200 > Corinna Vinschen wrote: > > On Sep 8 17:16, Takashi Yano via Cygwin-patches wrote: > > > On Mon, 7 Sep 2020 23:17:36 +0200 (CEST) > > > Johannes Schindelin wrote: > > >

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Corinna, On Wed, 9 Sep 2020 09:21:23 +0200 Corinna Vinschen wrote: > On Sep 8 17:16, Takashi Yano via Cygwin-patches wrote: > > On Mon, 7 Sep 2020 23:17:36 +0200 (CEST) > > Johannes Schindelin wrote: > > > Hi Takashi, > > > > > > On Sat, 5 Sep 2020, Takashi Yano wrote: > > > > > > > On Fri,

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sep 8 17:16, Takashi Yano via Cygwin-patches wrote: > On Mon, 7 Sep 2020 23:17:36 +0200 (CEST) > Johannes Schindelin wrote: > > Hi Takashi, > > > > On Sat, 5 Sep 2020, Takashi Yano wrote: > > > > > On Fri, 4 Sep 2020 08:23:42 +0200 (CEST) > > > Johannes Schindelin wrote: > > > > > > > > On Fr

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sep 8 18:45, Takashi Yano via Cygwin-patches wrote: > Hi Corinna, > > On Tue, 8 Sep 2020 10:40:34 +0200 > Corinna Vinschen wrote: > > On Sep 7 13:45, Takashi Yano via Cygwin-patches wrote: > > > On Mon, 7 Sep 2020 01:04:13 +0900 > > > > > Chages: > > > > > - If global locale is set, it takes

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Corinna, On Tue, 8 Sep 2020 10:40:34 +0200 Corinna Vinschen wrote: > On Sep 7 13:45, Takashi Yano via Cygwin-patches wrote: > > On Mon, 7 Sep 2020 01:04:13 +0900 > > > > Chages: > > > > - If global locale is set, it takes precedence. > > > > > > Changes: > > > - Use __get_current_locale() ins

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sep 7 13:45, Takashi Yano via Cygwin-patches wrote: > On Mon, 7 Sep 2020 01:04:13 +0900 > > > Chages: > > > - If global locale is set, it takes precedence. > > > > Changes: > > - Use __get_current_locale() instead of __get_global_locale(). > > - Fix a bug for ISO-8859-* charset. > > Changes:

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Mon, 7 Sep 2020 23:17:36 +0200 (CEST) Johannes Schindelin wrote: > Hi Takashi, > > On Sat, 5 Sep 2020, Takashi Yano wrote: > > > On Fri, 4 Sep 2020 08:23:42 +0200 (CEST) > > Johannes Schindelin wrote: > > > > > > On Fri, 4 Sep 2020, Takashi Yano via Cygwin-patches wrote: > > > > > > > On Tue,

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sep 7 22:40, Takashi Yano via Cygwin-patches wrote: > Here is a summary of my points: > > [Senario 1] > 1) Start mintty (UTF-8). > 2) Start another mintty by > mintty -o charset=SJIS >from the first mintty. > > [Senario 2] > int pm = getpt(); > if (fork()) { > [do the master

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On 2020-09-07 15:08, Johannes Schindelin wrote: > On Mon, 7 Sep 2020, Takashi Yano via Cygwin-patches wrote: >> On Mon, 7 Sep 2020 10:26:33 +0200 >> Corinna Vinschen wrote: >>> Hi Takashi, >>> On Sep 5 17:43, Takashi Yano via Cygwin-patches wrote: On Fri, 4 Sep 2020 21:22:35 +0200 Corinn

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Takashi, On Sat, 5 Sep 2020, Takashi Yano wrote: > On Fri, 4 Sep 2020 08:23:42 +0200 (CEST) > Johannes Schindelin wrote: > > > > On Fri, 4 Sep 2020, Takashi Yano via Cygwin-patches wrote: > > > > > On Tue, 1 Sep 2020 18:19:16 +0200 (CEST) > > > Johannes Schindelin wrote: > > > > > > > When `LA

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi, On Mon, 7 Sep 2020, Takashi Yano via Cygwin-patches wrote: > On Mon, 7 Sep 2020 10:26:33 +0200 > Corinna Vinschen wrote: > > Hi Takashi, > > On Sep 5 17:43, Takashi Yano via Cygwin-patches wrote: > > > On Fri, 4 Sep 2020 21:22:35 +0200 > > > Corinna Vinschen wrote: > > > > > > > Btw., the ma

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Mon, 7 Sep 2020 18:36:59 +0900 Takashi Yano via Cygwin-patches wrote: > > This is really confusing me. We never set the console codepage in the > > old pty code before, it was just pipes transmitting bytes. Why do we > > suddenly have to handle native apps running in a console in this case?!?

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Here is a summary of my points: [Senario 1] 1) Start mintty (UTF-8). 2) Start another mintty by mintty -o charset=SJIS from the first mintty. [Senario 2] int pm = getpt(); if (fork()) { [do the master operations] } else { setsid(); ps = open(ptsname(pm), O_RDWR); cl

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Mon, 7 Sep 2020 10:26:33 +0200 Corinna Vinschen wrote: > processes via cygheap. The idea is to get rid of the complex > setup_locale code in every execve call and just set it once in a process > tree starting at the process creating the ptys. This cause a problem if mintty is started from anot

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Mon, 7 Sep 2020 18:54:45 +0900 Takashi Yano via Cygwin-patches wrote: > On Mon, 7 Sep 2020 11:08:23 +0200 > Corinna Vinschen wrote: > > Hi Takashi, > > > > On Sep 7 13:45, Takashi Yano via Cygwin-patches wrote: > > > #if 0 /* Let's try this if setting codepage at pty open time is not > > >

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Mon, 7 Sep 2020 11:08:23 +0200 Corinna Vinschen wrote: > Hi Takashi, > > On Sep 7 13:45, Takashi Yano via Cygwin-patches wrote: > > #if 0 /* Let's try this if setting codepage at pty open time is not enough > > */ > > - if (!cygheap->locale.term_code_page) > > -cygheap->locale.term_code

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Mon, 7 Sep 2020 10:26:33 +0200 Corinna Vinschen wrote: > Hi Takashi, > > On Sep 5 17:43, Takashi Yano via Cygwin-patches wrote: > > On Fri, 4 Sep 2020 21:22:35 +0200 > > Corinna Vinschen wrote: > > > So this boils down to the fact that term_code_page must be set > > > after the application is

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sep 7 17:38, Takashi Yano via Cygwin-patches wrote: > On Mon, 7 Sep 2020 10:27:38 +0200 > Corinna Vinschen wrote: > > On Sep 5 20:15, Takashi Yano via Cygwin-patches wrote: > > > On Sat, 5 Sep 2020 17:43:01 +0900 > > > Takashi Yano via Cygwin-patches wrote: > > > No. This does not fix enough.

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Takashi, On Sep 7 13:45, Takashi Yano via Cygwin-patches wrote: > #if 0 /* Let's try this if setting codepage at pty open time is not enough */ > - if (!cygheap->locale.term_code_page) > -cygheap->locale.term_code_page = __eval_codepage_from_internal_charset > (); > + if (!get_ttyp ()-

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Mon, 7 Sep 2020 10:27:38 +0200 Corinna Vinschen wrote: > On Sep 5 20:15, Takashi Yano via Cygwin-patches wrote: > > On Sat, 5 Sep 2020 17:43:01 +0900 > > Takashi Yano via Cygwin-patches wrote: > > No. This does not fix enough. > > > > In the test case above, if it does not call setlocale(), >

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sep 6 19:28, Takashi Yano via Cygwin-patches wrote: > Hi Corinna, > > On Fri, 4 Sep 2020 14:44:00 +0200 > Corinna Vinschen wrote: > > +case 'I': /* ISO-8859-x */ > > + codepage = strtoul (charset + 9, NULL, 10); > > + break; > > This should be: > codepage = strtoul (charset + 9

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sep 5 20:15, Takashi Yano via Cygwin-patches wrote: > On Sat, 5 Sep 2020 17:43:01 +0900 > Takashi Yano via Cygwin-patches wrote: > No. This does not fix enough. > > In the test case above, if it does not call setlocale(), > __eval_codepage_from_internal_charset() always returns "ASCII" ??? _

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Takashi, On Sep 5 17:43, Takashi Yano via Cygwin-patches wrote: > On Fri, 4 Sep 2020 21:22:35 +0200 > Corinna Vinschen wrote: > > So this boils down to the fact that term_code_page must be set > > after the application is already running and as soo as it creates > > the pty, me thinks. What i

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Mon, 7 Sep 2020 01:04:13 +0900 Takashi Yano via Cygwin-patches wrote: > On Sun, 6 Sep 2020 19:15:30 +0900 > Takashi Yano via Cygwin-patches wrote: > > On Sun, 6 Sep 2020 17:57:03 +0900 > > Takashi Yano via Cygwin-patches wrote: > > > On Sat, 5 Sep 2020 23:15:16 +0900 > > > Takashi Yano via Cy

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sun, 6 Sep 2020 19:15:30 +0900 Takashi Yano via Cygwin-patches wrote: > On Sun, 6 Sep 2020 17:57:03 +0900 > Takashi Yano via Cygwin-patches wrote: > > On Sat, 5 Sep 2020 23:15:16 +0900 > > Takashi Yano via Cygwin-patches wrote: > > > Hi Corinna, > > > > > > On Sat, 5 Sep 2020 20:15:06 +0900

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Corinna, On Fri, 4 Sep 2020 14:44:00 +0200 Corinna Vinschen wrote: > +case 'I': /* ISO-8859-x */ > + codepage = strtoul (charset + 9, NULL, 10); > + break; This should be: codepage = strtoul (charset + 9, NULL, 10) + 28590; shouldn't it? -- Takashi Yano

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sun, 6 Sep 2020 17:57:03 +0900 Takashi Yano via Cygwin-patches wrote: > On Sat, 5 Sep 2020 23:15:16 +0900 > Takashi Yano via Cygwin-patches wrote: > > Hi Corinna, > > > > On Sat, 5 Sep 2020 20:15:06 +0900 > > Takashi Yano via Cygwin-patches wrote: > > > On Sat, 5 Sep 2020 17:43:01 +0900 > >

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sat, 5 Sep 2020 23:15:16 +0900 Takashi Yano via Cygwin-patches wrote: > Hi Corinna, > > On Sat, 5 Sep 2020 20:15:06 +0900 > Takashi Yano via Cygwin-patches wrote: > > On Sat, 5 Sep 2020 17:43:01 +0900 > > Takashi Yano via Cygwin-patches wrote: > > > Hi Corinna, > > > > > > On Fri, 4 Sep 202

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Corinna, On Sat, 5 Sep 2020 20:15:06 +0900 Takashi Yano via Cygwin-patches wrote: > On Sat, 5 Sep 2020 17:43:01 +0900 > Takashi Yano via Cygwin-patches wrote: > > Hi Corinna, > > > > On Fri, 4 Sep 2020 21:22:35 +0200 > > Corinna Vinschen wrote: > > > Hi Takashi, > > > > > > On Sep 4 23:50,

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sat, 5 Sep 2020 17:43:01 +0900 Takashi Yano via Cygwin-patches wrote: > Hi Corinna, > > On Fri, 4 Sep 2020 21:22:35 +0200 > Corinna Vinschen wrote: > > Hi Takashi, > > > > On Sep 4 23:50, Takashi Yano via Cygwin-patches wrote: > > > Hi Corinna, > > > > > > On Fri, 4 Sep 2020 14:44:00 +0200

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Corinna, On Fri, 4 Sep 2020 21:22:35 +0200 Corinna Vinschen wrote: > Hi Takashi, > > On Sep 4 23:50, Takashi Yano via Cygwin-patches wrote: > > Hi Corinna, > > > > On Fri, 4 Sep 2020 14:44:00 +0200 > > Corinna Vinschen wrote: > > > On Sep 4 18:21, Takashi Yano via Cygwin-patches wrote: > >

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Takashi, On Sep 4 23:50, Takashi Yano via Cygwin-patches wrote: > Hi Corinna, > > On Fri, 4 Sep 2020 14:44:00 +0200 > Corinna Vinschen wrote: > > On Sep 4 18:21, Takashi Yano via Cygwin-patches wrote: > > > I think I have found the answer to your request. > > > Patch attached. What do you th

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Johannes, On Fri, 4 Sep 2020 08:23:42 +0200 (CEST) Johannes Schindelin wrote: > Hi Takashi, > > On Fri, 4 Sep 2020, Takashi Yano via Cygwin-patches wrote: > > > Hi Johannes and Corinna, > > > > On Tue, 1 Sep 2020 18:19:16 +0200 (CEST) > > Johannes Schindelin wrote: > > > > > When `LANG=en_US.

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Corinna, On Fri, 4 Sep 2020 14:44:00 +0200 Corinna Vinschen wrote: > Hi Takashi, > > On Sep 4 18:21, Takashi Yano via Cygwin-patches wrote: > > Hi Corinna, > > > > On Thu, 3 Sep 2020 19:59:12 +0200 > > Corinna Vinschen wrote: > > > The only idea I had so far was, changing the way __set_chars

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Takashi, On Fri, 4 Sep 2020, Takashi Yano via Cygwin-patches wrote: > Hi Johannes and Corinna, > > On Tue, 1 Sep 2020 18:19:16 +0200 (CEST) > Johannes Schindelin wrote: > > > When `LANG=en_US.UTF-8`, the detected `LCID` is 0x0409, which is > > correct, but after that (at least if Pseudo Consol

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On 2020-09-04 06:44, Corinna Vinschen wrote: > Hi Takashi, > > On Sep 4 18:21, Takashi Yano via Cygwin-patches wrote: >> Hi Corinna, >> >> On Thu, 3 Sep 2020 19:59:12 +0200 >> Corinna Vinschen wrote: >>> The only idea I had so far was, changing the way __set_charset_from_locale >>> works from wit

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Takashi, On Sep 4 18:21, Takashi Yano via Cygwin-patches wrote: > Hi Corinna, > > On Thu, 3 Sep 2020 19:59:12 +0200 > Corinna Vinschen wrote: > > The only idea I had so far was, changing the way __set_charset_from_locale > > works from within _setlocale_r: > > > > We could add a Cygwin-speci

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Johannes and Corinna, On Tue, 1 Sep 2020 18:19:16 +0200 (CEST) Johannes Schindelin wrote: > When `LANG=en_US.UTF-8`, the detected `LCID` is 0x0409, which is > correct, but after that (at least if Pseudo Console support is enabled), > we try to find the default code page for that `LCID`, which

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Corinna, On Thu, 3 Sep 2020 19:59:12 +0200 Corinna Vinschen wrote: > On Sep 2 18:38, Corinna Vinschen wrote: > > Hi Takashi, > > > > On Sep 3 01:25, Takashi Yano via Cygwin-patches wrote: > > > Hi Corinna, > > > > > > On Wed, 2 Sep 2020 17:24:50 +0200 > > > Corinna Vinschen wrote: > > > >

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sep 2 18:38, Corinna Vinschen wrote: > Hi Takashi, > > On Sep 3 01:25, Takashi Yano via Cygwin-patches wrote: > > Hi Corinna, > > > > On Wed, 2 Sep 2020 17:24:50 +0200 > > Corinna Vinschen wrote: > > > > > get_locale_from_env() and get_langinfo() should go away. If we just > > > > > need a

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Takashi, On Sep 3 01:25, Takashi Yano via Cygwin-patches wrote: > Hi Corinna, > > On Wed, 2 Sep 2020 17:24:50 +0200 > Corinna Vinschen wrote: > > > > get_locale_from_env() and get_langinfo() should go away. If we just > > > > need a codepage for get_ttyp ()->term_code_page, we should really

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Corinna, On Wed, 2 Sep 2020 17:24:50 +0200 Corinna Vinschen wrote: > On Sep 2 19:54, Takashi Yano via Cygwin-patches wrote: > > Hi Corinna, > > > > On Wed, 2 Sep 2020 10:38:18 +0200 > > Corinna Vinschen wrote: > > > On Sep 2 10:30, Corinna Vinschen wrote: > > > > Ok guys, I'm not opposed to

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sep 2 17:24, Corinna Vinschen wrote: > On Sep 2 19:54, Takashi Yano via Cygwin-patches wrote: > > Hi Corinna, > > > > On Wed, 2 Sep 2020 10:38:18 +0200 > > Corinna Vinschen wrote: > > > On Sep 2 10:30, Corinna Vinschen wrote: > > > > Ok guys, I'm not opposed to this change in terms of its re

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sep 2 19:54, Takashi Yano via Cygwin-patches wrote: > Hi Corinna, > > On Wed, 2 Sep 2020 10:38:18 +0200 > Corinna Vinschen wrote: > > On Sep 2 10:30, Corinna Vinschen wrote: > > > Ok guys, I'm not opposed to this change in terms of its result, > > > but I'm starting to wonder why all this loc

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Wed, 2 Sep 2020 11:12:53 +0200 (CEST) Johannes Schindelin wrote: > On Wed, 2 Sep 2020, Takashi Yano wrote: > > OK, I will check Angular/CLI next. But I am not familier with > > Agnular/CLI. Could you please provide simple steps to reproduce > > the problem? > > Here is a report: https://github.

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Takashi, On Wed, 2 Sep 2020, Takashi Yano wrote: > On Wed, 2 Sep 2020 08:26:04 +0200 (CEST) > Johannes Schindelin wrote: > > Hi Takashi, > > > > On Wed, 2 Sep 2020, Takashi Yano via Cygwin-patches wrote: > > > > > On Wed, 2 Sep 2020 10:30:14 +0200 > > > Corinna Vinschen wrote: > > > > On Sep

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Wed, 2 Sep 2020 08:26:04 +0200 (CEST) Johannes Schindelin wrote: > Hi Takashi, > > On Wed, 2 Sep 2020, Takashi Yano via Cygwin-patches wrote: > > > On Wed, 2 Sep 2020 10:30:14 +0200 > > Corinna Vinschen wrote: > > > On Sep 1 18:19, Johannes Schindelin wrote: > > > > When `LANG=en_US.UTF-8`, t

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Takashi, On Wed, 2 Sep 2020, Takashi Yano via Cygwin-patches wrote: > On Wed, 2 Sep 2020 10:30:14 +0200 > Corinna Vinschen wrote: > > On Sep 1 18:19, Johannes Schindelin wrote: > > > When `LANG=en_US.UTF-8`, the detected `LCID` is 0x0409, which is > > > correct, but after that (at least if Ps

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi, On Tue, 1 Sep 2020, Johannes Schindelin wrote: > When `LANG=en_US.UTF-8`, the detected `LCID` is 0x0409, which is > correct, but after that (at least if Pseudo Console support is enabled), > we try to find the default code page for that `LCID`, which is ASCII > (437). Subsequently, we set the

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Corinna, On Wed, 2 Sep 2020 10:38:18 +0200 Corinna Vinschen wrote: > On Sep 2 10:30, Corinna Vinschen wrote: > > Ok guys, I'm not opposed to this change in terms of its result, > > but I'm starting to wonder why all this locale code in fhandler_tty > > is necessary at all. > > > > I see that

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Wed, 2 Sep 2020 10:30:14 +0200 Corinna Vinschen wrote: > On Sep 1 18:19, Johannes Schindelin wrote: > > When `LANG=en_US.UTF-8`, the detected `LCID` is 0x0409, which is > > correct, but after that (at least if Pseudo Console support is enabled), > > we try to find the default code page for that

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sep 2 10:30, Corinna Vinschen wrote: > On Sep 1 18:19, Johannes Schindelin wrote: > > When `LANG=en_US.UTF-8`, the detected `LCID` is 0x0409, which is > > correct, but after that (at least if Pseudo Console support is enabled), > > we try to find the default code page for that `LCID`, which is

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sep 1 18:19, Johannes Schindelin wrote: > When `LANG=en_US.UTF-8`, the detected `LCID` is 0x0409, which is > correct, but after that (at least if Pseudo Console support is enabled), > we try to find the default code page for that `LCID`, which is ASCII > (437). Subsequently, we set the Console

[PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

When `LANG=en_US.UTF-8`, the detected `LCID` is 0x0409, which is correct, but after that (at least if Pseudo Console support is enabled), we try to find the default code page for that `LCID`, which is ASCII (437). Subsequently, we set the Console output code page to that value, completely ignoring