Re: [PATCH 1/2] Cygwin: cache IsWow64Process2 host arch in wincap.

2024-11-25 Thread Corinna Vinschen
On Nov 22 08:54, Jeremy Drake via Cygwin-patches wrote: > On Fri, 22 Nov 2024, Corinna Vinschen wrote: > > > On Nov 21 11:42, Jeremy Drake via Cygwin-patches wrote: > > > +#if defined (__x86_64__) > > > + host_mach = IMAGE_FILE_MACHINE_AMD64; > > > +#elif defined (__i386__) > > > + host_

Re: [PATCH 1/2] Cygwin: cache IsWow64Process2 host arch in wincap.

2024-11-22 Thread Jeremy Drake via Cygwin-patches
On Fri, 22 Nov 2024, Corinna Vinschen wrote: > On Nov 21 11:42, Jeremy Drake via Cygwin-patches wrote: > > Note the elif defined (__i386__) case won't compile because it references > > the no-longer-present `wow64` value. This was written and tested against > > 3.3.6, and the __i386__ case could

Re: [PATCH 1/2] Cygwin: cache IsWow64Process2 host arch in wincap.

2024-11-22 Thread Jon Turney
On 21/11/2024 19:42, Jeremy Drake via Cygwin-patches wrote: @@ -282,4 +284,30 @@ wincapc::init () __small_sprintf (osnam, "NT-%d.%d", version.dwMajorVersion, version.dwMinorVersion); + + if (!IsWow64Process2 (GetCurrentProcess (), &emul_mach, &host_mach)) +{ + /

Re: [PATCH 1/2] Cygwin: cache IsWow64Process2 host arch in wincap.

2024-11-22 Thread Corinna Vinschen
On Nov 21 11:42, Jeremy Drake via Cygwin-patches wrote: > This was already used in the FAST_CWD check, and could be used in a > couple other places. > > I found the "emulated"/process value returned from the function largely > useless, so I did not cache it. It is useless because, as the docs say

[PATCH 1/2] Cygwin: cache IsWow64Process2 host arch in wincap.

2024-11-21 Thread Jeremy Drake via Cygwin-patches
This was already used in the FAST_CWD check, and could be used in a couple other places. I found the "emulated"/process value returned from the function largely useless, so I did not cache it. It is useless because, as the docs say, it is set to IMAGE_FILE_MACHINE_UNKNOWN (0) if the process is no