Re: [PATCH 05/11] Cygwin: Move post-dir unlink check

2021-01-18 Thread Corinna Vinschen via Cygwin-patches
On Jan 18 15:31, Ben wrote: > On 18-01-2021 12:08, Corinna Vinschen via Cygwin-patches wrote: > > On Jan 15 14:45, Ben Wijen wrote: > >> Move post-dir unlink check from > >> fhandler_disk_file::rmdir to _unlink_nt > > > > Why? It's not much of a problem, codewise, but the commit message > > could

Re: [PATCH 05/11] Cygwin: Move post-dir unlink check

2021-01-18 Thread Ben
On 18-01-2021 12:08, Corinna Vinschen via Cygwin-patches wrote: > On Jan 15 14:45, Ben Wijen wrote: >> Move post-dir unlink check from >> fhandler_disk_file::rmdir to _unlink_nt > > Why? It's not much of a problem, codewise, but the commit message > could be improved here. > Something like this?

Re: [PATCH 05/11] Cygwin: Move post-dir unlink check

2021-01-18 Thread Corinna Vinschen via Cygwin-patches
On Jan 15 14:45, Ben Wijen wrote: > Move post-dir unlink check from > fhandler_disk_file::rmdir to _unlink_nt Why? It's not much of a problem, codewise, but the commit message could be improved here. Corinna

[PATCH 05/11] Cygwin: Move post-dir unlink check

2021-01-15 Thread Ben Wijen
Move post-dir unlink check from fhandler_disk_file::rmdir to _unlink_nt --- winsup/cygwin/fhandler_disk_file.cc | 20 winsup/cygwin/syscalls.cc | 21 + 2 files changed, 21 insertions(+), 20 deletions(-) diff --git a/winsup/cygwin/fhandler_disk_fi