Re: [PATCH] ccwrap: fix build with non-english locale set

2016-03-04 Thread Corinna Vinschen
On Mar 4 10:22, Patrick Bendorf wrote: > hi corinna, > > i might find some time this weekend. this last few days were just > too much to look into the issue. Cool, thanks! Corinna > patrick > > Am 04.03.2016 um 09:56 schrieb Corinna Vinschen: > >Patrick, > > > >On Feb 29 17:55, Jon Turney w

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-03-04 Thread Patrick Bendorf
hi corinna, i might find some time this weekend. this last few days were just too much to look into the issue. patrick Am 04.03.2016 um 09:56 schrieb Corinna Vinschen: Patrick, On Feb 29 17:55, Jon Turney wrote: On 29/02/2016 16:56, Patrick Bendorf wrote: thanks eric. just changed and teste

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-03-04 Thread Corinna Vinschen
Patrick, On Feb 29 17:55, Jon Turney wrote: > On 29/02/2016 16:56, Patrick Bendorf wrote: > >thanks eric. > >just changed and tested it. > >hopefully the last patch for this matter. > > > >@corinna: as attachment to overcome previous problems. > > Unfortunately, this still isn't quite right, as i

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-02-29 Thread Jon Turney
On 29/02/2016 16:56, Patrick Bendorf wrote: thanks eric. just changed and tested it. hopefully the last patch for this matter. @corinna: as attachment to overcome previous problems. Unfortunately, this still isn't quite right, as it forces the 2nd invocation of the compiler to be with LC_ALL,

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-02-29 Thread Patrick Bendorf
thanks eric. just changed and tested it. hopefully the last patch for this matter. @corinna: as attachment to overcome previous problems. patrick Am 29.02.2016 um 16:41 schrieb Eric Blake: On 02/29/2016 06:19 AM, patrick bendorf wrote: after some discussion on irc and the list i'm resubmittin

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-02-29 Thread Eric Blake
On 02/29/2016 06:19 AM, patrick bendorf wrote: > after some discussion on irc and the list i'm resubmitting a simpler > version of the patch. > setting the locale on cygwin to 'C.UTF-8' is not needed, so i'm always > setting it to 'C' which is sufficient for the build process and the most > simple

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-02-29 Thread Corinna Vinschen
On Feb 29 14:34, Patrick Bendorf wrote: > sorry, now it's based on current git head. and hopefully without formatting > issues. > > /winsup/ > * ccwrap: change locale to 'C' as ccwrap searches for literal strings > "search starts here" and "End of search list" which may be localized. > > --- > w

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-02-29 Thread Patrick Bendorf
sorry, now it's based on current git head. and hopefully without formatting issues. /winsup/ * ccwrap: change locale to 'C' as ccwrap searches for literal strings "search starts here" and "End of search list" which may be localized. --- winsup/ccwrap | 6 +- 1 file changed, 1 insertion(+

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-02-29 Thread patrick bendorf
after some discussion on irc and the list i'm resubmitting a simpler version of the patch. setting the locale on cygwin to 'C.UTF-8' is not needed, so i'm always setting it to 'C' which is sufficient for the build process and the most simple fix. /winsup/ * ccwrap: change locale to 'C' as ccwr

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-02-29 Thread Corinna Vinschen
On Feb 29 12:46, Jon Turney wrote: > On 29/02/2016 12:19, m...@patrick-bendorf.de wrote: > >+if (`uname -o` =~ /cygwin/i) { > >+$ENV{'LANG'} = 'C.UTF-8'; > >+} else { > >+$ENV{'LANG'} = 'C'; > > This can just say "$ENV{'LANG'} = 'C';" right? As that has to work > everywhere? Uh, I missed

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-02-29 Thread Corinna Vinschen
On Feb 29 13:19, m...@patrick-bendorf.de wrote: > Hi Corinna, > > Am 2016-02-29 11:33, schrieb Corinna Vinschen: > >Hi Patrick, > > > >On Feb 29 08:12, Patrick Bendorf wrote: > >>/winsup/ > >>* ccwrap: fix build with non-english locale set > > > >First of all, why fix it? Without at least a short

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-02-29 Thread Jon Turney
On 29/02/2016 12:19, m...@patrick-bendorf.de wrote: +if (`uname -o` =~ /cygwin/i) { +$ENV{'LANG'} = 'C.UTF-8'; +} else { +$ENV{'LANG'} = 'C'; This can just say "$ENV{'LANG'} = 'C';" right? As that has to work everywhere?

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-02-29 Thread mail
Hi Corinna, Am 2016-02-29 11:33, schrieb Corinna Vinschen: Hi Patrick, On Feb 29 08:12, Patrick Bendorf wrote: /winsup/ * ccwrap: fix build with non-english locale set First of all, why fix it? Without at least a short explanation what you observe without this patch, this change seems arb

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-02-29 Thread Corinna Vinschen
Hi Patrick, On Feb 29 08:12, Patrick Bendorf wrote: > /winsup/ > * ccwrap: fix build with non-english locale set First of all, why fix it? Without at least a short explanation what you observe without this patch, this change seems arbitrary. > --- > winsup/ccwrap | 1 + > 1 file changed, 1 ins

[PATCH] ccwrap: fix build with non-english locale set

2016-02-28 Thread Patrick Bendorf
/winsup/ * ccwrap: fix build with non-english locale set --- winsup/ccwrap | 1 + 1 file changed, 1 insertion(+) diff --git a/winsup/ccwrap b/winsup/ccwrap index 7580e7a..ef83085 100755 --- a/winsup/ccwrap +++ b/winsup/ccwrap @@ -12,6 +12,7 @@ if ($ARGV[0] ne '++') { $cxx = 1; } die "$0: