Re: [PATCH] better stackdumps

2008-03-20 Thread Christopher Faylor
On Thu, Mar 20, 2008 at 11:35:32AM +0100, Corinna Vinschen wrote: >On Mar 19 08:56, Brian Dessent wrote: >> Christopher Faylor wrote: >> >> > Sorry, but I don't like this concept. This bloats the cygwin DLL for a >> > condition that would be better served by either using gdb or generating >> > a

Re: [PATCH] better stackdumps

2008-03-20 Thread Corinna Vinschen
On Mar 19 08:56, Brian Dessent wrote: > Christopher Faylor wrote: > > > Sorry, but I don't like this concept. This bloats the cygwin DLL for a > > condition that would be better served by either using gdb or generating > > a real coredump. > > I hear you, but part of the motivation for writing t

Re: [PATCH] better stackdumps

2008-03-19 Thread Brian Dessent
Pedro Alves wrote: > Sorry I missed the discussion at [EMAIL PROTECTED] What does info > sharelibrary say? > The last I looked at this, it worked. Is this broken in gdb head > and on the cygwin distributed gdb? With gdb CVS HEAD, it gives: (gdb) i sh >FromTo Syms Read Share

Re: [PATCH] better stackdumps

2008-03-19 Thread Pedro Alves
A Wednesday 19 March 2008 15:56:55, Brian Dessent wrote: > Christopher Faylor wrote: > > Sorry, but I don't like this concept. This bloats the cygwin DLL for a > > condition that would be better served by either using gdb or generating > > a real coredump. > > I hear you, but part of the motivatio

Re: [PATCH] better stackdumps

2008-03-19 Thread Brian Dessent
Christopher Faylor wrote: > Sorry, but I don't like this concept. This bloats the cygwin DLL for a > condition that would be better served by either using gdb or generating > a real coredump. I hear you, but part of the motivation for writing this was a recent thread the other week on the gdb li

Re: [PATCH] better stackdumps

2008-03-18 Thread Christopher Faylor
On Tue, Mar 18, 2008 at 05:24:20PM -0700, Brian Dessent wrote: > >This patch adds the ability to see functions/symbols in the .stackdump >files generated when there's a fault. It parses the export sections of >each loaded module and finds the closest exported address for each stack >frame address.

Re: [PATCH] better stackdumps

2008-03-18 Thread Brian Dessent
Igor Peshansky wrote: > Would it make sense to force a newline before the function name and to > display it with a small indent? That way people who want the old-style > stackdump could just feed the new one into "grep -v '^ '" or something... Yes, that would be one way. That actually reminds

Re: [PATCH] better stackdumps

2008-03-18 Thread Igor Peshansky
On Tue, 18 Mar 2008, Brian Dessent wrote: > Brian Dessent wrote: > > > Of course the labeling works for any module/dll, not just cygwin1.dll, > > but I didn't have a more elaborate testcase to demonstrate. > > Forgot to mention... > > The symbols are just tacked on on the right hand side there for

Re: [PATCH] better stackdumps

2008-03-18 Thread Brian Dessent
Brian Dessent wrote: > Of course the labeling works for any module/dll, not just cygwin1.dll, > but I didn't have a more elaborate testcase to demonstrate. Forgot to mention... The symbols are just tacked on on the right hand side there for now. I wasn't really sure how to handle that. I didn

[PATCH] better stackdumps

2008-03-18 Thread Brian Dessent
This patch adds the ability to see functions/symbols in the .stackdump files generated when there's a fault. It parses the export sections of each loaded module and finds the closest exported address for each stack frame address. This of course won't be perfect as it will show the wrong function