Re: [PATCH] Fix possible segmentation fault in strnstr() on 64-bit systems

2017-09-14 Thread Johannes Schindelin
Hi Yaakov, On Wed, 13 Sep 2017, Yaakov Selkowitz wrote: > On 2017-09-13 10:44, Johannes Schindelin wrote: > > As of f22054c94d (Modify strnstr.c., 2017-08-30), the strnstr() > > implementation was replaced by a version that segfaults (at least > > sometimes) on 64-bit systems. > > > > The reason

Re: [PATCH] Fix possible segmentation fault in strnstr() on 64-bit systems

2017-09-14 Thread cyg Simple
On 9/13/2017 5:55 PM, Yaakov Selkowitz wrote: > On 2017-09-13 10:44, Johannes Schindelin wrote: >> As of f22054c94d (Modify strnstr.c., 2017-08-30), the strnstr() >> implementation was replaced by a version that segfaults (at least >> sometimes) on 64-bit systems. >> >> The reason: the new implemen

Re: [PATCH] Fix possible segmentation fault in strnstr() on 64-bit systems

2017-09-13 Thread Yaakov Selkowitz
On 2017-09-13 10:44, Johannes Schindelin wrote: > As of f22054c94d (Modify strnstr.c., 2017-08-30), the strnstr() > implementation was replaced by a version that segfaults (at least > sometimes) on 64-bit systems. > > The reason: the new implementation uses memmem(), and the prototype of > memmem(

[PATCH] Fix possible segmentation fault in strnstr() on 64-bit systems

2017-09-13 Thread Johannes Schindelin
As of f22054c94d (Modify strnstr.c., 2017-08-30), the strnstr() implementation was replaced by a version that segfaults (at least sometimes) on 64-bit systems. The reason: the new implementation uses memmem(), and the prototype of memmem() is missing because the _GNU_SOURCE constant is not defined