Re: [PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-07 Thread Takashi Yano
Hi Ken, On Sat, 7 Sep 2024 02:00:55 +0900 Takashi Yano wrote: > On Fri, 6 Sep 2024 18:01:27 +0900 > Takashi Yano wrote: > > On Thu, 5 Sep 2024 17:38:11 +0200 > > Corinna Vinschen wrote: > > > I think you should push your original patch to the 3.5 branch for now, > > > and we test the big change in

Re: [PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-06 Thread Takashi Yano
On Fri, 6 Sep 2024 18:01:27 +0900 Takashi Yano wrote: > On Thu, 5 Sep 2024 17:38:11 +0200 > Corinna Vinschen wrote: > > I think you should push your original patch to the 3.5 branch for now, > > and we test the big change in the main branch first. > > Sounds reasonable. I'll submit a v2 patch for

Re: [PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-06 Thread Takashi Yano
On Thu, 5 Sep 2024 17:38:11 +0200 Corinna Vinschen wrote: > I think you should push your original patch to the 3.5 branch for now, > and we test the big change in the main branch first. Sounds reasonable. I'll submit a v2 patch for 3.5 branch: [PATCH v2] Cygwin: pipe: Restore blocking mode of read

Re: [PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-05 Thread Corinna Vinschen
Hi Takashi, I think you should push your original patch to the 3.5 branch for now, and we test the big change in the main branch first. Thanks, Corinna On Sep 5 22:18, Takashi Yano wrote: > Hi Corinna, Ken and Johannes > > On Mon, 2 Sep 2024 23:33:13 +0900 > Takashi Yano wrote: > > On Mon, 2

Re: [PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-05 Thread Takashi Yano
Hi Corinna, Ken and Johannes On Mon, 2 Sep 2024 23:33:13 +0900 Takashi Yano wrote: > On Mon, 2 Sep 2024 22:50:45 +0900 > Takashi Yano wrote: > > On Mon, 2 Sep 2024 14:48:35 +0200 (CEST) > > Johannes Schindelin wrote: > > > I have tested it and the symptom is addressed. > > > > Thanks for testing.

Re: [PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-02 Thread Takashi Yano
On Mon, 2 Sep 2024 22:50:45 +0900 Takashi Yano wrote: > On Mon, 2 Sep 2024 14:48:35 +0200 (CEST) > Johannes Schindelin wrote: > > I have tested it and the symptom is addressed. > > Thanks for testing. > > > I do have to wonder whether it is intentional that calling > > `set_pipe_non_blocking(fals

Re: [PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-02 Thread Takashi Yano
On Mon, 2 Sep 2024 22:50:45 +0900 Takashi Yano wrote: > On Mon, 2 Sep 2024 14:48:35 +0200 (CEST) > Johannes Schindelin wrote: > > That would potentially be a remedy, but I would worry that this design > > takes a decidedly single-thread world-view. While that may be appropriate > > in the context o

Re: [PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-02 Thread Takashi Yano
On Mon, 2 Sep 2024 14:48:35 +0200 (CEST) Johannes Schindelin wrote: > I have tested it and the symptom is addressed. Thanks for testing. > I do have to wonder whether it is intentional that calling > `set_pipe_non_blocking(false)` followed by `set_pipe_non_blocking(true)` > on an originally-non-b

Re: [PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-02 Thread Takashi Yano
On Mon, 2 Sep 2024 20:49:28 +0900 Takashi Yano wrote: > On Mon, 2 Sep 2024 13:10:31 +0200 > Corinna Vinschen wrote: > > On Aug 30 23:15, Takashi Yano wrote: > > > If a cygwin app is executed from a non-cygwin app and the cygwin > > > app exits, read pipe remains on non-blocking mode because of the

Re: [PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-02 Thread Johannes Schindelin
Hi Corinna and Takashi, On Mon, 2 Sep 2024, Corinna Vinschen wrote: > On Aug 30 23:15, Takashi Yano wrote: > > If a cygwin app is executed from a non-cygwin app and the cygwin > > app exits, read pipe remains on non-blocking mode because of the > > commit fc691d0246b9. Due to this behaviour, the

Re: [PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-02 Thread Takashi Yano
On Mon, 2 Sep 2024 13:10:31 +0200 Corinna Vinschen wrote: > On Aug 30 23:15, Takashi Yano wrote: > > If a cygwin app is executed from a non-cygwin app and the cygwin > > app exits, read pipe remains on non-blocking mode because of the > > commit fc691d0246b9. Due to this behaviour, the non-cygwin a

Re: [PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-09-02 Thread Corinna Vinschen
On Aug 30 23:15, Takashi Yano wrote: > If a cygwin app is executed from a non-cygwin app and the cygwin > app exits, read pipe remains on non-blocking mode because of the > commit fc691d0246b9. Due to this behaviour, the non-cygwin app > cannot read the pipe correctly after that. With this patch, t

[PATCH] Cygwin: pipe: Restore blocking mode of read pipe on close()

2024-08-30 Thread Takashi Yano
If a cygwin app is executed from a non-cygwin app and the cygwin app exits, read pipe remains on non-blocking mode because of the commit fc691d0246b9. Due to this behaviour, the non-cygwin app cannot read the pipe correctly after that. With this patch, the blocking mode of the read pipe is stored i