Re: [PATCH] Cygwin: dtable: Delete old kludge code for /dev/tty.

2023-07-06 Thread Takashi Yano
On Tue, 4 Jul 2023 17:59:41 +0200 (CEST) Johannes Schindelin wrote: > Hi Takashi, > > On Tue, 4 Jul 2023, Takashi Yano wrote: > > > On Mon, 3 Jul 2023 12:52:25 +0200 > > Corinna Vinschen wrote: > > > > > > On Jun 27 22:28, Takashi Yano wrote: > > > > > > > > diff --git a/winsup/cygwin/dtable.cc b

Re: [PATCH] Cygwin: dtable: Delete old kludge code for /dev/tty.

2023-07-04 Thread Johannes Schindelin
Hi Takashi, On Tue, 4 Jul 2023, Takashi Yano wrote: > On Mon, 3 Jul 2023 12:52:25 +0200 > Corinna Vinschen wrote: > > > > On Jun 27 22:28, Takashi Yano wrote: > > > > > > diff --git a/winsup/cygwin/dtable.cc b/winsup/cygwin/dtable.cc > > > index 18e0f3097..9427e238e 100644 > > > --- a/winsup/cygw

Re: [PATCH] Cygwin: dtable: Delete old kludge code for /dev/tty.

2023-07-04 Thread Takashi Yano
Hi Corinna, Thanks for reviewing the patch. On Mon, 3 Jul 2023 12:52:25 +0200 Corinna Vinschen wrote: > Hi Takashi, > > On Jun 27 22:28, Takashi Yano wrote: > > This old kludge code assigns fhandler_console for /dev/tty even > > if the CTTY is not a console when stat() has been called. Due to >

Re: [PATCH] Cygwin: dtable: Delete old kludge code for /dev/tty.

2023-07-03 Thread Corinna Vinschen
Hi Takashi, On Jun 27 22:28, Takashi Yano wrote: > This old kludge code assigns fhandler_console for /dev/tty even > if the CTTY is not a console when stat() has been called. Due to > this, the problem reported in > https://cygwin.com/pipermail/cygwin/2023-June/253888.html > occurs after the commi

[PATCH] Cygwin: dtable: Delete old kludge code for /dev/tty.

2023-06-27 Thread Takashi Yano
This old kludge code assigns fhandler_console for /dev/tty even if the CTTY is not a console when stat() has been called. Due to this, the problem reported in https://cygwin.com/pipermail/cygwin/2023-June/253888.html occurs after the commit 3721a756b0d8 ("Cygwin: console: Make the console accessibl