Re: [PATCH] Cygwin: console: Fix exit code for non-cygwin process.

2024-02-03 Thread Corinna Vinschen
On Feb 4 00:04, Takashi Yano wrote: > On Sat, 3 Feb 2024 15:27:06 +0100 (CET) > Johannes Schindelin wrote: > > On IRC, you reported that the thread would crash if `cons` was not fixed > > up. The symptom was that that crash would apparently prevent the exit code > > from being read, and it would b

Re: [PATCH] Cygwin: console: Fix exit code for non-cygwin process.

2024-02-03 Thread Takashi Yano
On Sat, 3 Feb 2024 15:27:06 +0100 (CET) Johannes Schindelin wrote: > On IRC, you reported that the thread would crash if `cons` was not fixed > up. The symptom was that that crash would apparently prevent the exit code > from being read, and it would be left at 0, indicating potentially > incorrect

Re: [PATCH] Cygwin: console: Fix exit code for non-cygwin process.

2024-02-03 Thread Johannes Schindelin
Hi Takashi, On Sat, 3 Feb 2024, Johannes Schindelin wrote: > On Fri, 2 Feb 2024, Takashi Yano wrote: > > > If non-cygwin process is executed in console, the exit code is not > > set correctly. This is because the stub process for non-cygwin app > > crashes in fhandler_console::set_disable_master_

Re: [PATCH] Cygwin: console: Fix exit code for non-cygwin process.

2024-02-03 Thread Johannes Schindelin
Hi Takashi, On Fri, 2 Feb 2024, Takashi Yano wrote: > If non-cygwin process is executed in console, the exit code is not > set correctly. This is because the stub process for non-cygwin app > crashes in fhandler_console::set_disable_master_thread() due to NULL > pointer dereference. This bug was

[PATCH] Cygwin: console: Fix exit code for non-cygwin process.

2024-02-01 Thread Takashi Yano
If non-cygwin process is executed in console, the exit code is not set correctly. This is because the stub process for non-cygwin app crashes in fhandler_console::set_disable_master_thread() due to NULL pointer dereference. This bug was introduced by the commit: 3721a756b0d8 ("Cygwin: console: Make