RE: [PATCH] CYGWIN: Fix resolver debugging output

2021-02-02 Thread Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches
> with some customizations, and not noticed any issues so far. Should I be wary > in future? Have you used the / APIs, or low-level DNS other than with getXbyY(), or maybe debugged DNS? The changes are not to remove any existing functionality -- I don't see how that was not clear -- but to mak

Re: [PATCH] CYGWIN: Fix resolver debugging output

2021-02-02 Thread Brian Inglis
On 2021-02-01 12:02, Corinna Vinschen via Cygwin-patches wrote: On Feb 1 15:46, Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches wrote: Except, the value has no meaning for ipv6. It'll print all 0's :-) But: minires does not make use of the _ext field. It does use the conventional nsa

Re: [PATCH] CYGWIN: Fix resolver debugging output

2021-02-01 Thread Corinna Vinschen via Cygwin-patches
On Feb 1 15:46, Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches wrote: > > Except, the value has no meaning for ipv6. > > It'll print all 0's :-) But: > > minires does not make use of the _ext field. It does use the conventional > nsaddr_list (which is IPv4), > but only if Windows nat

RE: [PATCH] CYGWIN: Fix resolver debugging output

2021-02-01 Thread Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches
> Except, the value has no meaning for ipv6. It'll print all 0's :-) But: minires does not make use of the _ext field. It does use the conventional nsaddr_list (which is IPv4), but only if Windows native DNS API is not used: "osquery"(aka use_os)=0. For debugging purposes, that is enough and

Re: [PATCH] CYGWIN: Fix resolver debugging output

2021-02-01 Thread Corinna Vinschen via Cygwin-patches
On Feb 1 14:23, Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches wrote: > > Please use %ls, %S is non-standard. > > Sure. > > > For instance, write_record appears to handle DNS_TYPE_A, > > but not DNS_TYPE_. > > I can add that, it's not a problem. But indeed, reparsing of Windows pa

RE: [PATCH] CYGWIN: Fix resolver debugging output

2021-02-01 Thread Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches
> Please use %ls, %S is non-standard. Sure. > For instance, write_record appears to handle DNS_TYPE_A, > but not DNS_TYPE_. I can add that, it's not a problem. But indeed, reparsing of Windows packets, does miss (as well as some other types, such as URI -- not sure if Windows has it, t

Re: [PATCH] CYGWIN: Fix resolver debugging output

2021-02-01 Thread Corinna Vinschen via Cygwin-patches
Hi Anton, On Jan 29 14:29, Anton Lavrentiev via Cygwin-patches wrote: > - Use %S (instead of %s) when a wide-character output is due; Please use %ls, %S is non-standard. > - Use native byte order for host and add port when doing I/O with DNS server; This puzzeled me a bit so I took another look

[PATCH] CYGWIN: Fix resolver debugging output

2021-01-29 Thread Anton Lavrentiev via Cygwin-patches
- Use %S (instead of %s) when a wide-character output is due; - Use native byte order for host and add port when doing I/O with DNS server; - Use forward way for resolv.conf's "options" processing, so listing "debug" as a first option, will show all following option(s) as they are read; - Re-eva