Re: Problem with: Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-12-08 Thread Christian Franke
Christopher Faylor wrote: On Thu, Dec 08, 2011 at 07:42:48AM +0100, Christian Franke wrote: Fix: #ifdef __cplusplus +extern "C++" { ... inline int __wait_status_to_int(int __status) { } inline int __wait_status_to_int(const union wait&__status) { } ... +} #endif I've added that to sys

Re: Problem with: Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-12-08 Thread Christopher Faylor
On Thu, Dec 08, 2011 at 07:42:48AM +0100, Christian Franke wrote: >Christopher Faylor wrote: >> On Thu, Dec 08, 2011 at 12:17:11AM +0100, Christian Franke wrote: >>> Christopher Faylor wrote: ... /usr/local/src/trunk/objdir.withada/./prev-gcc/g++ -B/usr/local/src/trunk/objdir.withada

Re: Problem with: Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-12-07 Thread Christian Franke
Christopher Faylor wrote: On Thu, Dec 08, 2011 at 12:17:11AM +0100, Christian Franke wrote: Christopher Faylor wrote: ... /usr/local/src/trunk/objdir.withada/./prev-gcc/g++ -B/usr/local/src/trunk/objdir.withada/./prev-gcc/ ... -I/usr/local/src/trunk/gcc/gcc/../libdecnumber/bid -I../libdecnumber

Re: Problem with: Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-12-07 Thread Christopher Faylor
On Thu, Dec 08, 2011 at 12:17:11AM +0100, Christian Franke wrote: >Christopher Faylor wrote: >> >> I guess this is why there was a __INSIDE_CYGWIN__ test. >> >> Christian, could you submit a new patch to rectify this problem? > >OK, will try soon. > > >> ... >> /usr/local/src/trunk/objdir.withada/.

Re: Problem with: Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-12-07 Thread Christian Franke
Christopher Faylor wrote: I guess this is why there was a __INSIDE_CYGWIN__ test. Christian, could you submit a new patch to rectify this problem? OK, will try soon. ... /usr/local/src/trunk/objdir.withada/./prev-gcc/g++ -B/usr/local/src/trunk/objdir.withada/./prev-gcc/ ... -I/usr/local/sr

Problem with: Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-12-07 Thread Christopher Faylor
On Thu, Oct 06, 2011 at 01:17:49PM -0400, Christopher Faylor wrote: >On Thu, Oct 06, 2011 at 06:12:35PM +0200, Christian Franke wrote: >>Christopher Faylor wrote: >>> On Thu, Oct 06, 2011 at 01:03:41PM +0200, Christian Franke wrote: ... OK, __INSIDE_CYGWIN__ is not needed here in practice

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-06 Thread Christopher Faylor
On Thu, Oct 06, 2011 at 06:12:35PM +0200, Christian Franke wrote: >Christopher Faylor wrote: >> On Thu, Oct 06, 2011 at 01:03:41PM +0200, Christian Franke wrote: >>> ... >>> OK, __INSIDE_CYGWIN__ is not needed here in practice (but possibly in >>> theory :-) >> I would rather see as little __INSIDE

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-06 Thread Christian Franke
Christopher Faylor wrote: On Thu, Oct 06, 2011 at 01:03:41PM +0200, Christian Franke wrote: ... OK, __INSIDE_CYGWIN__ is not needed here in practice (but possibly in theory :-) I would rather see as little __INSIDE_CYGWIN__ as possible in external headers. OK, removed and Cygwin compilation t

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-06 Thread Christopher Faylor
On Thu, Oct 06, 2011 at 01:03:41PM +0200, Christian Franke wrote: >Christopher Faylor wrote: >> On Wed, Oct 05, 2011 at 11:17:58PM +0200, Christian Franke wrote: >>> Christopher Faylor wrote: On Wed, Oct 05, 2011 at 12:57:44PM +0200, Christian Franke wrote: > ... > diff --git a/winsup/

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-06 Thread Christian Franke
Christopher Faylor wrote: On Wed, Oct 05, 2011 at 11:17:58PM +0200, Christian Franke wrote: Christopher Faylor wrote: On Wed, Oct 05, 2011 at 12:57:44PM +0200, Christian Franke wrote: ... diff --git a/winsup/cygwin/include/cygwin/wait.h b/winsup/cygwin/include/cygwin/wait.h index bed81b7..e4e

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-05 Thread Christopher Faylor
On Wed, Oct 05, 2011 at 11:17:58PM +0200, Christian Franke wrote: >Christopher Faylor wrote: >> On Wed, Oct 05, 2011 at 12:57:44PM +0200, Christian Franke wrote: >>> ... >>> diff --git a/winsup/cygwin/include/cygwin/wait.h >>> b/winsup/cygwin/include/cygwin/wait.h >>> index bed81b7..e4edba2 100644

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-05 Thread Christian Franke
Christopher Faylor wrote: On Wed, Oct 05, 2011 at 12:57:44PM +0200, Christian Franke wrote: ... diff --git a/winsup/cygwin/include/cygwin/wait.h b/winsup/cygwin/include/cygwin/wait.h index bed81b7..e4edba2 100644 --- a/winsup/cygwin/include/cygwin/wait.h +++ b/winsup/cygwin/include/cygwin/wait.

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-05 Thread Eric Blake
On 10/05/2011 04:57 AM, Christian Franke wrote: The file include/sys/wait.h provides union wait but neither the wait() functions nor the W*() macros allow to actually use it. Compilation of cdrkit 1.1.11 fails because the configure check assumes that union wait is the status parameter type if its

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-05 Thread Christopher Faylor
On Wed, Oct 05, 2011 at 12:57:44PM +0200, Christian Franke wrote: >The file include/sys/wait.h provides union wait but neither the wait() >functions nor the W*() macros allow to actually use it. Compilation of >cdrkit 1.1.11 fails because the configure check assumes that union wait >is the statu

[PATCH] Allow usage of union wait for wait() functions and macros

2011-10-05 Thread Christian Franke
The file include/sys/wait.h provides union wait but neither the wait() functions nor the W*() macros allow to actually use it. Compilation of cdrkit 1.1.11 fails because the configure check assumes that union wait is the status parameter type if its declaration exists. The attached patch fixes