Re: [PATCH 01/01] machine/_types.h: __blkcnt_t should be signed

On Thu, Jul 14, 2016 at 6:12 PM, Corinna Vinschen wrote: > On Jul 14 16:37, Ray Donnelly wrote: >> Hi, >> >> Please review and consider applying the attached patch. The commit message >> is: >> >> [1] states: "blkcnt_t and off_t shall be signed intege

[PATCH 01/01] machine/_types.h: __blkcnt_t should be signed

Hi, Please review and consider applying the attached patch. The commit message is: [1] states: "blkcnt_t and off_t shall be signed integer types." This causes pacman to fail when the size requirement of the net update operation is negative, instead it calculated a huge positive number. [1] http:

Re: [PATCH] Expand $CYGWIN error_start processing

What about the token side of things? and ? For my use case, its important that I can do something like that too. On Sun, Feb 9, 2014 at 8:33 PM, Christopher Faylor <> wrote: > On Sun, Feb 09, 2014 at 12:25:40AM +0000, Ray Donnelly wrote: >>I want to use QtCreator as my debugger bu

[PATCH] Expand $CYGWIN error_start processing

:C:/Qt/bin/qtcreator.exe|-debug| .. note, QtCreator doesn't work if passed the program name and must be invoked with the -debug option. Ray Donnelly (1): * winsup/cygwin/exceptions.cc: Expand $CYGWIN error_start processing so that custom commandlines can be passed to the d

[PATCH] * winsup/cygwin/exceptions.cc: Expand $CYGWIN error_start processing so that custom commandlines can be passed to the debugger program using '|' as an argument delimiter and

--- winsup/cygwin/exceptions.cc | 50 + 1 file changed, 46 insertions(+), 4 deletions(-) diff --git a/winsup/cygwin/exceptions.cc b/winsup/cygwin/exceptions.cc index ceddbbc..99392a7 100644 --- a/winsup/cygwin/exceptions.cc +++ b/winsup/cygwin/exception

Re: [PATCH] Fix potentially uninitialized variable p

On Wed, Jan 8, 2014 at 2:38 PM, Christopher Faylor wrote: > On Wed, Jan 08, 2014 at 11:00:14AM +0000, Ray Donnelly wrote: >>On Sun, Dec 22, 2013 at 7:11 AM, Christopher Faylor wrote: >>> On Sun, Dec 22, 2013 at 12:40:20AM +, Ray Donnelly wrote: >>>>- PWCHAR

Re: [PATCH] Fix potentially uninitialized variable p

On Sun, Dec 22, 2013 at 7:11 AM, Christopher Faylor wrote: > On Sun, Dec 22, 2013 at 12:40:20AM +0000, Ray Donnelly wrote: >>- PWCHAR p; >>+ PWCHAR p = NULL; > > AFAICT, that would result in a NULL dereference. I've checked in > a different change to

Re: [PATCH] Reattach trailing dirsep on existing directories too.

On Wed, Jan 8, 2014 at 9:20 AM, Corinna Vinschen wrote: > On Jan 7 18:15, Ray Donnelly wrote: >> On Tue, Jan 7, 2014 at 3:12 PM, Corinna Vinschen wrote: >> > On Dec 22 01:03, Ray Donnelly wrote: >> >> I hope this is OK and I've done it in the best place.

Re: [PATCH] Reattach trailing dirsep on existing directories too.

On Tue, Jan 7, 2014 at 3:12 PM, Corinna Vinschen wrote: > On Dec 22 01:03, Ray Donnelly wrote: >> I hope this is OK and I've done it in the best place. Please advise if >> it needs any changes. > > I have no idea if this is ok. This is a patch to a very crucial &

Request for feedback on 3 patches I posted in December.

Hi, Could someone please look over these and give me some feedback? http://www.cygwin.com/ml/cygwin-patches/2013-q4/msg00017.html http://www.cygwin.com/ml/cygwin-patches/2013-q4/msg00018.html http://www.cygwin.com/ml/cygwin-patches/2013-q4/msg00019.html Cheers, Ray.

[PATCH] Reattach trailing dirsep on existing directories too.

I hope this is OK and I've done it in the best place. Please advise if it needs any changes. 0003-winsup-cygwin-path.cc-path_conv-check-Reattach-trail.patch Description: Binary data

[PATCH] Fix potentially uninitialized variable p

0002-winsup-cygwin-strace.cc-strace-vsprntf-Fix-potential.patch Description: Binary data

[PATCH] Fix some debug string format specifiers.

I hope patches generated with git are OK? Best regards, Ray. 0001-winsup-cygwin-gmon.c-_mcleanup-Fix-some-debug-string.patch Description: Binary data