Re: [PATCH v6] Cygwin: rewrite cmdline parser

2021-05-13 Thread Mingye Wang
Oh, I should also mention that this patch does *not* fix globbing with Windows paths. Although stuff like (in node-js): child_process.spawnSync("C:\\cygwin64\\bin\\echo.exe", ["C:\\Qt\\*"], {encoding: 'utf-8'}) is correctly fed to glob(3), the glob() function does not perform any interpr

[PATCH v6] Cygwin: rewrite cmdline parser

2021-05-13 Thread Mingye Wang
This commit rewrites the cmdline parser to achieve the following: * MSVCRT compatibility. Except for the single-quote handling (an extension for compatibility with old Cygwin), the parser now interprets option boundaries exactly like MSVCR since 2008. This fixes the issue where our escaping d

[PATCH] Cygwin: rewrite cmdline parser

2020-11-07 Thread Mingye Wang
This commit rewrites the cmdline parser to achieve the following: * MSVCRT compatibility. Except for the single-quote handling (an extension for compatibility with old Cygwin), the parser now interprets option boundaries exactly like MSVCR since 2008. This fixes the issue where our escaping d

[PATCH v5] Cygwin: rewrite cmdline parser

2020-11-07 Thread Mingye Wang
This is the fifth version of the patch. I thought I sent this in October...

Re: Re: [PATCH v4 1/3] Cygwin: rewrite and make public cmdline parser

2020-09-24 Thread Mingye Wang (Artoria2e5)
On 2020/9/7 17:39, Corinna Vinschen wrote: Nope, we won't do that. The command line parsing is an internal thing, and we won't export arbitrary internal functions using their own symbol. *If* we should export this stuff at all, which I highly doubt as necessary, it should use the cygwin_intern

[PATCH v4 1/3] Cygwin: rewrite and make public cmdline parser

2020-09-04 Thread Mingye Wang
This commit rewrites the cmdline parser to achieve the following: * MSVCRT compatibility. Except for the single-quote handling (an extension for compatibility with old Cygwin), the parser now interprets option boundaries exactly like MSVCR since 2008. This fixes the issue where our escaping d

[PATCH v4 3/3] testsuite: don't strip dir from obj files

2020-09-04 Thread Mingye Wang
Make has no idea how to build an o file when the correspoinding c file is not there. That happens when we strip the dir. --- winsup/testsuite/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/winsup/testsuite/Makefile.in b/winsup/testsuite/Makefile.in index bdc116d12.

[PATCH v4 2/3] regparm: make code highlight happy

2020-09-04 Thread Mingye Wang
--- winsup/cygwin/regparm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/winsup/cygwin/regparm.h b/winsup/cygwin/regparm.h index cce1bab4a..a14c501db 100644 --- a/winsup/cygwin/regparm.h +++ b/winsup/cygwin/regparm.h @@ -8,7 +8,7 @@ details. */ #pragma once -#if defined

Re: [PATCH v2] Cygwin: rewrite cmdline parser

2020-06-25 Thread Mingye Wang
On 2020/6/25 22:43, Mingye Wang wrote: + free (word); Grrr, this should not be in there. Waiting for reviews and saving that up for v3.

[PATCH v2] Cygwin: rewrite cmdline parser

2020-06-25 Thread Mingye Wang
This commit rewrites the cmdline parser to achieve the following: * MSVCRT compatibility. Except for the single-quote handling (an extension for compatibility with old Cygwin), the parser now interprets option boundaries exactly like MSVCR since 2008. This fixes the issue where our escaping d

[PATCH] Cygwin: rewrite cmdline parser

2020-06-24 Thread Mingye Wang
This commit rewrites the cmdline parser to achieve the following: * MSVCRT compatibility. Except for the single-quote handling (an extension for compatibility with old Cygwin), the parser now interprets option boundaries exactly like MSVCR since 2008. This fixes the issue where our escaping d